* [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
@ 2012-06-28 4:56 dennis lan
2012-06-28 6:02 ` Dennis.Yxun
2012-06-28 17:27 ` Saul Wold
0 siblings, 2 replies; 7+ messages in thread
From: dennis lan @ 2012-06-28 4:56 UTC (permalink / raw)
To: openembedded-core
From: Dennis Lan <dennis.yxun@gmail.com>
Using Gentoo Linux as the build host, it fails without this patch
Use Getopt::Std in place of getopts.pl.
https://bugs.gentoo.org/show_bug.cgi?id=420083
which following error:
/usr/bin/perl -w ./../msggen.pl -l jstyleModule InterpreterMessages.msg
/usr/bin/perl -w ./../msggen.pl -l jstyleModule DssslAppMessages.msg
Undefined subroutine &main::Getopts called at ./../msggen.pl line 22.
make[2]: *** [InterpreterMessages.h] Error 2
make[2]: *** Waiting for unfinished jobs....
Undefined subroutine &main::Getopts called at ./../msggen.pl line 22.
make[2]: *** [DssslAppMessages.h] Error 2
Upstream-Status: Submitted [openjade-devel@lists.sourceforge.net]
Signed-off-by: Dennis Lan <dennis.yxun@gmail.com>
---
.../openjade/openjade-1.3.2/msggen.pl.patch | 32 ++++++++++++++++++++
.../openjade/openjade-native_1.3.2.bb | 1 +
2 files changed, 33 insertions(+), 0 deletions(-)
create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
diff --git a/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
new file mode 100644
index 0000000..1afe68b
--- /dev/null
+++ b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
@@ -0,0 +1,32 @@
+Use Getopt::Std in place of getopts.pl.
+https://bugs.gentoo.org/show_bug.cgi?id=420083
+
+--- a/msggen.pl
++++ b/msggen.pl
+@@ -4,6 +4,7 @@
+ # See the file COPYING for copying permission.
+
+ use POSIX;
++use Getopt::Std;
+
+ # Package and version.
+ $package = 'openjade';
+@@ -18,8 +19,7 @@
+ undef $opt_l;
+ undef $opt_p;
+ undef $opt_t;
+-do 'getopts.pl';
+-&Getopts('l:p:t:');
++getopts('l:p:t:');
+ $module = $opt_l;
+ $pot_file = $opt_p;
+
+@@ -72,7 +72,7 @@
+ else {
+ $field[0] =~ /^[IWQXE][0-9]$/ || &error("invalid first field");;
+ $type[$num] = substr($field[0], 0, 1);
+- $argc = int(substr($field[0], 1, 1));
++ $argc = substr($field[0], 1, 1);
+ }
+ $nargs[$num] = $argc;
+ $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ || &error("invalid tag");
diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
index 5b29c1f..efd1e11 100644
--- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
+++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
@@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \
file://makefile.patch \
+ file://msggen.pl.patch \
file://reautoconf.patch \
file://user-declared-default-constructor.patch"
--
1.7.8.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
2012-06-28 4:56 [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace dennis lan
@ 2012-06-28 6:02 ` Dennis.Yxun
2012-06-28 17:27 ` Saul Wold
1 sibling, 0 replies; 7+ messages in thread
From: Dennis.Yxun @ 2012-06-28 6:02 UTC (permalink / raw)
To: openembedded-core; +Cc: floppym
Hi ALL:
Since Mike "floppym" Gilbert is the original author of this patch,
so I add "CC-" to him here
Thanks
Dennis
On Thu, Jun 28, 2012 at 12:56 PM, dennis lan <dennis.yxun@gmail.com> wrote:
> From: Dennis Lan <dennis.yxun@gmail.com>
>
> Using Gentoo Linux as the build host, it fails without this patch
> Use Getopt::Std in place of getopts.pl.
>
> https://bugs.gentoo.org/show_bug.cgi?id=420083
>
> which following error:
> /usr/bin/perl -w ./../msggen.pl -l jstyleModule InterpreterMessages.msg
> /usr/bin/perl -w ./../msggen.pl -l jstyleModule DssslAppMessages.msg
> Undefined subroutine &main::Getopts called at ./../msggen.pl line 22.
> make[2]: *** [InterpreterMessages.h] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Undefined subroutine &main::Getopts called at ./../msggen.pl line 22.
> make[2]: *** [DssslAppMessages.h] Error 2
>
> Upstream-Status: Submitted [openjade-devel@lists.sourceforge.net]
>
> Signed-off-by: Dennis Lan <dennis.yxun@gmail.com>
> ---
> .../openjade/openjade-1.3.2/msggen.pl.patch | 32 ++++++++++++++++++++
> .../openjade/openjade-native_1.3.2.bb | 1 +
> 2 files changed, 33 insertions(+), 0 deletions(-)
> create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
>
> diff --git a/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
> new file mode 100644
> index 0000000..1afe68b
> --- /dev/null
> +++ b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
> @@ -0,0 +1,32 @@
> +Use Getopt::Std in place of getopts.pl.
> +https://bugs.gentoo.org/show_bug.cgi?id=420083
> +
> +--- a/msggen.pl
> ++++ b/msggen.pl
> +@@ -4,6 +4,7 @@
> + # See the file COPYING for copying permission.
> +
> + use POSIX;
> ++use Getopt::Std;
> +
> + # Package and version.
> + $package = 'openjade';
> +@@ -18,8 +19,7 @@
> + undef $opt_l;
> + undef $opt_p;
> + undef $opt_t;
> +-do 'getopts.pl';
> +-&Getopts('l:p:t:');
> ++getopts('l:p:t:');
> + $module = $opt_l;
> + $pot_file = $opt_p;
> +
> +@@ -72,7 +72,7 @@
> + else {
> + $field[0] =~ /^[IWQXE][0-9]$/ || &error("invalid first field");;
> + $type[$num] = substr($field[0], 0, 1);
> +- $argc = int(substr($field[0], 1, 1));
> ++ $argc = substr($field[0], 1, 1);
> + }
> + $nargs[$num] = $argc;
> + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ || &error("invalid tag");
> diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> index 5b29c1f..efd1e11 100644
> --- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> +++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \
> file://makefile.patch \
> + file://msggen.pl.patch \
> file://reautoconf.patch \
> file://user-declared-default-constructor.patch"
>
> --
> 1.7.8.6
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
2012-06-28 4:56 [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace dennis lan
2012-06-28 6:02 ` Dennis.Yxun
@ 2012-06-28 17:27 ` Saul Wold
2012-07-02 22:24 ` Dennis.Yxun
1 sibling, 1 reply; 7+ messages in thread
From: Saul Wold @ 2012-06-28 17:27 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 06/27/2012 09:56 PM, dennis lan wrote:
> From: Dennis Lan<dennis.yxun@gmail.com>
>
> Using Gentoo Linux as the build host, it fails without this patch
> Use Getopt::Std in place of getopts.pl.
>
> https://bugs.gentoo.org/show_bug.cgi?id=420083
>
> which following error:
> /usr/bin/perl -w ./../msggen.pl -l jstyleModule InterpreterMessages.msg
> /usr/bin/perl -w ./../msggen.pl -l jstyleModule DssslAppMessages.msg
> Undefined subroutine&main::Getopts called at ./../msggen.pl line 22.
> make[2]: *** [InterpreterMessages.h] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Undefined subroutine&main::Getopts called at ./../msggen.pl line 22.
> make[2]: *** [DssslAppMessages.h] Error 2
>
> Upstream-Status: Submitted [openjade-devel@lists.sourceforge.net]
>
This needs to be in the patch file itself, we can track the patches
better that way.
> Signed-off-by: Dennis Lan<dennis.yxun@gmail.com>
> ---
> .../openjade/openjade-1.3.2/msggen.pl.patch | 32 ++++++++++++++++++++
> .../openjade/openjade-native_1.3.2.bb | 1 +
> 2 files changed, 33 insertions(+), 0 deletions(-)
> create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
>
> diff --git a/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
> new file mode 100644
> index 0000000..1afe68b
> --- /dev/null
> +++ b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch
Please add comment Upstream-Status and SOB to the patch itself.
Thanks
Sau!
> @@ -0,0 +1,32 @@
> +Use Getopt::Std in place of getopts.pl.
> +https://bugs.gentoo.org/show_bug.cgi?id=420083
> +
> +--- a/msggen.pl
> ++++ b/msggen.pl
> +@@ -4,6 +4,7 @@
> + # See the file COPYING for copying permission.
> +
> + use POSIX;
> ++use Getopt::Std;
> +
> + # Package and version.
> + $package = 'openjade';
> +@@ -18,8 +19,7 @@
> + undef $opt_l;
> + undef $opt_p;
> + undef $opt_t;
> +-do 'getopts.pl';
> +-&Getopts('l:p:t:');
> ++getopts('l:p:t:');
> + $module = $opt_l;
> + $pot_file = $opt_p;
> +
> +@@ -72,7 +72,7 @@
> + else {
> + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first field");;
> + $type[$num] = substr($field[0], 0, 1);
> +- $argc = int(substr($field[0], 1, 1));
> ++ $argc = substr($field[0], 1, 1);
> + }
> + $nargs[$num] = $argc;
> + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid tag");
> diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> index 5b29c1f..efd1e11 100644
> --- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> +++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \
> file://makefile.patch \
> + file://msggen.pl.patch \
> file://reautoconf.patch \
> file://user-declared-default-constructor.patch"
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
2012-06-28 17:27 ` Saul Wold
@ 2012-07-02 22:24 ` Dennis.Yxun
2012-07-02 23:46 ` Saul Wold
0 siblings, 1 reply; 7+ messages in thread
From: Dennis.Yxun @ 2012-07-02 22:24 UTC (permalink / raw)
To: Saul Wold, floppym; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 3691 bytes --]
hi saul:
please see my comment as following
dennis
At 2012-6-29 AM1:27，"Saul Wold" &
>
> On 06/27/2012 09:56 PM, dennis lan wrote:
>
>> From: Dennis Lan<dennis.yxun@gmail.com>
>>
>> Using Gentoo Linux as the build host, it fails without this patch
>> Use Getopt::Std in place of getopts.pl.
>>
>> https://bugs.gentoo.org/show_**bug.cgi?id=420083<https://bugs.gentoo.org/show_bug.cgi?id=420083>
>>
>> which following error:
>> /usr/bin/perl -w ./../msggen.pl -l jstyleModule InterpreterMessages.msg
>> /usr/bin/perl -w ./../msggen.pl -l jstyleModule DssslAppMessages.msg
>> Undefined subroutine&main::Getopts called at ./../msggen.pl line 22.
>> make[2]: *** [InterpreterMessages.h] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>> Undefined subroutine&main::Getopts called at ./../msggen.pl line 22.
>> make[2]: *** [DssslAppMessages.h] Error 2
>>
>> Upstream-Status: Submitted [openjade-devel@lists.**sourceforge.net<openjade-devel@lists.sourceforge.net>
>> ]
>>
>> This needs to be in the patch file itself, we can track the patches
> better that way.
>
>> Signed-off-by: Dennis Lan<dennis.yxun@gmail.com>
>> ---
>> .../openjade/openjade-1.3.2/**msggen.pl.patch | 32
>> ++++++++++++++++++++
>> .../openjade/openjade-native_**1.3.2.bb<http://openjade-native_1.3.2.bb> | 1 +
>> 2 files changed, 33 insertions(+), 0 deletions(-)
>> create mode 100644 meta/recipes-devtools/**openjade/openjade-1.3.2/**
>> msggen.pl.patch
>>
>> diff --git a/meta/recipes-devtools/**openjade/openjade-1.3.2/**msggen.pl.patch
>> b/meta/recipes-devtools/**openjade/openjade-1.3.2/**msggen.pl.patch
>> new file mode 100644
>> index 0000000..1afe68b
>> --- /dev/null
>> +++ b/meta/recipes-devtools/**openjade/openjade-1.3.2/**msggen.pl.patch
>>
>
> Please add comment Upstream-Status and SOB to the patch itself.
>
> Thanks
> Sau!
>
> @@ -0,0 +1,32 @@
>> +Use Getopt::Std in place of getopts.pl.
>> +https://bugs.gentoo.org/show_**bug.cgi?id=420083<https://bugs.gentoo.org/show_bug.cgi?id=420083>
>> +
>> +--- a/msggen.pl
>> ++++ b/msggen.pl
>> +@@ -4,6 +4,7 @@
>> + # See the file COPYING for copying permission.
>> +
>> + use POSIX;
>> ++use Getopt::Std;
>> +
>> + # Package and version.
>> + $package = 'openjade';
>> +@@ -18,8 +19,7 @@
>> + undef $opt_l;
>> + undef $opt_p;
>> + undef $opt_t;
>> +-do 'getopts.pl';
>> +-&Getopts('l:p:t:');
>> ++getopts('l:p:t:');
>> + $module = $opt_l;
>> + $pot_file = $opt_p;
>> +
>> +@@ -72,7 +72,7 @@
>> + else {
>> + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first field");;
>> + $type[$num] = substr($field[0], 0, 1);
>> +- $argc = int(substr($field[0], 1, 1));
>> ++ $argc = substr($field[0], 1, 1);
>> + }
>> + $nargs[$num] = $argc;
>> + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid tag");
>> diff --git a/meta/recipes-devtools/**openjade/openjade-native_1.3.**2.bb<http://openjade-native_1.3.2.bb>b/meta/recipes-devtools/
>> **openjade/openjade-native_1.3.**2.bb <http://openjade-native_1.3.2.bb>
>> index 5b29c1f..efd1e11 100644
>> --- a/meta/recipes-devtools/**openjade/openjade-native_1.3.**2.bb<http://openjade-native_1.3.2.bb>
>> +++ b/meta/recipes-devtools/**openjade/openjade-native_1.3.**2.bb<http://openjade-native_1.3.2.bb>
>> @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
>>
>> SRC_URI = "${SOURCEFORGE_MIRROR}/**openjade/openjade-${PV}.tar.gz \
>> file://makefile.patch \
>> + file://msggen.pl.patch \
>> file://reautoconf.patch \
>> file://user-declared-default-**constructor.patch"
>>
>>
[-- Attachment #2: Type: text/html, Size: 5325 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
2012-07-02 22:24 ` Dennis.Yxun
@ 2012-07-02 23:46 ` Saul Wold
2012-07-03 0:29 ` Dennis.Yxun
0 siblings, 1 reply; 7+ messages in thread
From: Saul Wold @ 2012-07-02 23:46 UTC (permalink / raw)
To: Dennis.Yxun; +Cc: floppym, Patches and discussions about the oe-core layer
On 07/02/2012 03:24 PM, Dennis.Yxun wrote:
> hi saul:
> please see my comment as following
>
I do not understand what you are getting at here?
You PATCH file openjade-1.3.2/msggen.pl.patch is what is missing the
Upsteam-Status: and SOB (Signed-off-by), the commit message what you
have for SOB is Ok, the commit message itself should not have the
Upstream-Status: tag, it belongs in the .patch file header.
Sau!
> dennis
>
> At 2012-6-29 AM1:27，"Saul Wold" &
>
> On 06/27/2012 09:56 PM, dennis lan wrote:
>
> From: Dennis Lan<dennis.yxun@gmail.com
> <mailto:dennis.yxun@gmail.com>>
>
> Using Gentoo Linux as the build host, it fails without this patch
> Use Getopt::Std in place of getopts.pl <http://getopts.pl>.
>
> https://bugs.gentoo.org/show___bug.cgi?id=420083
> <https://bugs.gentoo.org/show_bug.cgi?id=420083>
>
> which following error:
> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl> -l
> jstyleModule InterpreterMessages.msg
> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl> -l
> jstyleModule DssslAppMessages.msg
> Undefined subroutine&main::Getopts called at ./../msggen.pl
> <http://msggen.pl> line 22.
> make[2]: *** [InterpreterMessages.h] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Undefined subroutine&main::Getopts called at ./../msggen.pl
> <http://msggen.pl> line 22.
> make[2]: *** [DssslAppMessages.h] Error 2
>
> Upstream-Status: Submitted
> [openjade-devel@lists.__sourceforge.net
> <mailto:openjade-devel@lists.sourceforge.net>]
>
> This needs to be in the patch file itself, we can track the patches
> better that way.
>
> Signed-off-by: Dennis Lan<dennis.yxun@gmail.com
> <mailto:dennis.yxun@gmail.com>>
> ---
> .../openjade/openjade-1.3.2/__msggen.pl.patch | 32
> ++++++++++++++++++++
> .../openjade/openjade-native___1.3.2.bb
> <http://openjade-native_1.3.2.bb> | 1 +
> 2 files changed, 33 insertions(+), 0 deletions(-)
> create mode 100644
> meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
>
> diff --git
> a/meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
> b/meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
> new file mode 100644
> index 0000000..1afe68b
> --- /dev/null
> +++
> b/meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
>
>
> Please add comment Upstream-Status and SOB to the patch itself.
>
> Thanks
> Sau!
>
> @@ -0,0 +1,32 @@
> +Use Getopt::Std in place of getopts.pl <http://getopts.pl>.
> +https://bugs.gentoo.org/show___bug.cgi?id=420083
> <https://bugs.gentoo.org/show_bug.cgi?id=420083>
> +
> +--- a/msggen.pl <http://msggen.pl>
> ++++ b/msggen.pl <http://msggen.pl>
> +@@ -4,6 +4,7 @@
> + # See the file COPYING for copying permission.
> +
> + use POSIX;
> ++use Getopt::Std;
> +
> + # Package and version.
> + $package = 'openjade';
> +@@ -18,8 +19,7 @@
> + undef $opt_l;
> + undef $opt_p;
> + undef $opt_t;
> +-do 'getopts.pl <http://getopts.pl>';
> +-&Getopts('l:p:t:');
> ++getopts('l:p:t:');
> + $module = $opt_l;
> + $pot_file = $opt_p;
> +
> +@@ -72,7 +72,7 @@
> + else {
> + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first
> field");;
> + $type[$num] = substr($field[0], 0, 1);
> +- $argc = int(substr($field[0], 1, 1));
> ++ $argc = substr($field[0], 1, 1);
> + }
> + $nargs[$num] = $argc;
> + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid
> tag");
> diff --git
> a/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> b/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> index 5b29c1f..efd1e11 100644
> ---
> a/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> +++
> b/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
>
> SRC_URI =
> "${SOURCEFORGE_MIRROR}/__openjade/openjade-${PV}.tar.gz \
> file://makefile.patch \
> + file://msggen.pl.patch \
> file://reautoconf.patch \
> file://user-declared-default-__constructor.patch"
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
2012-07-02 23:46 ` Saul Wold
@ 2012-07-03 0:29 ` Dennis.Yxun
2012-07-03 0:46 ` Saul Wold
0 siblings, 1 reply; 7+ messages in thread
From: Dennis.Yxun @ 2012-07-03 0:29 UTC (permalink / raw)
To: Saul Wold; +Cc: floppym, Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 6358 bytes --]
hi saul:
it seems that my inline comments got lost.
ok, since the origial patch is took from gentoo upstream. so, i thought
better to keep what it was, instead of trying to modify. but if you insist,
i could cook another patch, put mike(floppym) as author-of?
besides, as mike already point out, the openjade upstream is dead, and i
still got no response from them, chance that patch will got accept is rare.
what's the upstream-status do you suggest?
在 2012-7-3 上午7:46，"Saul Wold" <sgw@linux.intel.com>写道：
> On 07/02/2012 03:24 PM, Dennis.Yxun wrote:
>
>> hi saul:
>> please see my comment as following
>>
>> I do not understand what you are getting at here?
>
> You PATCH file openjade-1.3.2/msggen.pl.patch is what is missing the
> Upsteam-Status: and SOB (Signed-off-by), the commit message what you have
> for SOB is Ok, the commit message itself should not have the
> Upstream-Status: tag, it belongs in the .patch file header.
>
> Sau!
>
> dennis
>>
>> At 2012-6-29 AM1:27，"Saul Wold" &
>>
>> On 06/27/2012 09:56 PM, dennis lan wrote:
>>
>> From: Dennis Lan<dennis.yxun@gmail.com
>> <mailto:dennis.yxun@gmail.com>**>
>>
>> Using Gentoo Linux as the build host, it fails without this patch
>> Use Getopt::Std in place of getopts.pl <http://getopts.pl>.
>>
>> https://bugs.gentoo.org/show__**_bug.cgi?id=420083<https://bugs.gentoo.org/show___bug.cgi?id=420083>
>> <https://bugs.gentoo.org/show_**bug.cgi?id=420083<https://bugs.gentoo.org/show_bug.cgi?id=420083>
>> >
>>
>> which following error:
>> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl> -l
>> jstyleModule InterpreterMessages.msg
>> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl> -l
>> jstyleModule DssslAppMessages.msg
>> Undefined subroutine&main::Getopts called at ./../msggen.pl
>> <http://msggen.pl> line 22.
>> make[2]: *** [InterpreterMessages.h] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>> Undefined subroutine&main::Getopts called at ./../msggen.pl
>> <http://msggen.pl> line 22.
>> make[2]: *** [DssslAppMessages.h] Error 2
>>
>> Upstream-Status: Submitted
>> [openjade-devel@lists.__source**forge.net<http://sourceforge.net>
>> <mailto:openjade-devel@lists.**sourceforge.net<openjade-devel@lists.sourceforge.net>
>> >]
>>
>> This needs to be in the patch file itself, we can track the patches
>> better that way.
>>
>> Signed-off-by: Dennis Lan<dennis.yxun@gmail.com
>> <mailto:dennis.yxun@gmail.com>**>
>> ---
>> .../openjade/openjade-1.3.2/__**msggen.pl.patch | 32
>> ++++++++++++++++++++
>> .../openjade/openjade-native__**_1.3.2.bb<http://openjade-native___1.3.2.bb>
>> <http://openjade-native_1.3.2.**bb<http://openjade-native_1.3.2.bb>>
>> | 1 +
>> 2 files changed, 33 insertions(+), 0 deletions(-)
>> create mode 100644
>> meta/recipes-devtools/__**openjade/openjade-1.3.2/__**
>> msggen.pl.patch
>>
>> diff --git
>> a/meta/recipes-devtools/__**openjade/openjade-1.3.2/__**
>> msggen.pl.patch
>> b/meta/recipes-devtools/__**openjade/openjade-1.3.2/__**
>> msggen.pl.patch
>> new file mode 100644
>> index 0000000..1afe68b
>> --- /dev/null
>> +++
>> b/meta/recipes-devtools/__**openjade/openjade-1.3.2/__**
>> msggen.pl.patch
>>
>>
>> Please add comment Upstream-Status and SOB to the patch itself.
>>
>> Thanks
>> Sau!
>>
>> @@ -0,0 +1,32 @@
>> +Use Getopt::Std in place of getopts.pl <http://getopts.pl>.
>> +https://bugs.gentoo.org/show_**__bug.cgi?id=420083<https://bugs.gentoo.org/show___bug.cgi?id=420083>
>> <https://bugs.gentoo.org/show_**bug.cgi?id=420083<https://bugs.gentoo.org/show_bug.cgi?id=420083>
>> >
>> +
>> +--- a/msggen.pl <http://msggen.pl>
>> ++++ b/msggen.pl <http://msggen.pl>
>> +@@ -4,6 +4,7 @@
>> + # See the file COPYING for copying permission.
>> +
>> + use POSIX;
>> ++use Getopt::Std;
>> +
>> + # Package and version.
>> + $package = 'openjade';
>> +@@ -18,8 +19,7 @@
>> + undef $opt_l;
>> + undef $opt_p;
>> + undef $opt_t;
>> +-do 'getopts.pl <http://getopts.pl>';
>> +-&Getopts('l:p:t:');
>> ++getopts('l:p:t:');
>> + $module = $opt_l;
>> + $pot_file = $opt_p;
>> +
>> +@@ -72,7 +72,7 @@
>> + else {
>> + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first
>> field");;
>> + $type[$num] = substr($field[0], 0, 1);
>> +- $argc = int(substr($field[0], 1, 1));
>> ++ $argc = substr($field[0], 1, 1);
>> + }
>> + $nargs[$num] = $argc;
>> + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid
>> tag");
>> diff --git
>> a/meta/recipes-devtools/__**openjade/openjade-native_1.3._**_2.bb
>> <http://openjade-native_1.3.2.**bb<http://openjade-native_1.3.2.bb>
>> >
>> b/meta/recipes-devtools/__**openjade/openjade-native_1.3._**_2.bb
>> <http://openjade-native_1.3.2.**bb<http://openjade-native_1.3.2.bb>
>> >
>> index 5b29c1f..efd1e11 100644
>> ---
>> a/meta/recipes-devtools/__**openjade/openjade-native_1.3._**_2.bb
>> <http://openjade-native_1.3.2.**bb<http://openjade-native_1.3.2.bb>
>> >
>> +++
>> b/meta/recipes-devtools/__**openjade/openjade-native_1.3._**_2.bb
>> <http://openjade-native_1.3.2.**bb<http://openjade-native_1.3.2.bb>
>> >
>> @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
>>
>> SRC_URI =
>> "${SOURCEFORGE_MIRROR}/__**openjade/openjade-${PV}.tar.gz \
>> file://makefile.patch \
>> + file://msggen.pl.patch \
>> file://reautoconf.patch \
>> file://user-declared-default-_**_constructor.patch"
>>
>>
[-- Attachment #2: Type: text/html, Size: 9392 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
2012-07-03 0:29 ` Dennis.Yxun
@ 2012-07-03 0:46 ` Saul Wold
0 siblings, 0 replies; 7+ messages in thread
From: Saul Wold @ 2012-07-03 0:46 UTC (permalink / raw)
To: Dennis.Yxun; +Cc: floppym, Patches and discussions about the oe-core layer
On 07/02/2012 05:29 PM, Dennis.Yxun wrote:
> hi saul:
> it seems that my inline comments got lost.
> ok, since the origial patch is took from gentoo upstream. so, i
> thought better to keep what it was, instead of trying to modify. but if
> you insist, i could cook another patch, put mike(floppym) as author-of?
Sure, that seems OK
> besides, as mike already point out, the openjade upstream is dead,
> and i still got no response from them, chance that patch will got accept
> is rare. what's the upstream-status do you suggest?
>
Upstream-Status: Inappropriate [no upstream]
> 在 2012-7-3 上午7:46，"Saul Wold" <sgw@linux.intel.com
> <mailto:sgw@linux.intel.com>>写道：
>
> On 07/02/2012 03:24 PM, Dennis.Yxun wrote:
>
> hi saul:
> please see my comment as following
>
> I do not understand what you are getting at here?
>
> You PATCH file openjade-1.3.2/msggen.pl.patch is what is missing the
> Upsteam-Status: and SOB (Signed-off-by), the commit message what you
> have for SOB is Ok, the commit message itself should not have the
> Upstream-Status: tag, it belongs in the .patch file header.
>
> Sau!
>
> dennis
>
> At 2012-6-29 AM1:27，"Saul Wold" &
>
> On 06/27/2012 09:56 PM, dennis lan wrote:
>
> From: Dennis Lan<dennis.yxun@gmail.com
> <mailto:dennis.yxun@gmail.com>
> <mailto:dennis.yxun@gmail.com <mailto:dennis.yxun@gmail.com>>__>
>
> Using Gentoo Linux as the build host, it fails without
> this patch
> Use Getopt::Std in place of getopts.pl
> <http://getopts.pl> <http://getopts.pl>.
>
> https://bugs.gentoo.org/show_____bug.cgi?id=420083
> <https://bugs.gentoo.org/show___bug.cgi?id=420083>
> <https://bugs.gentoo.org/show___bug.cgi?id=420083
> <https://bugs.gentoo.org/show_bug.cgi?id=420083>>
>
> which following error:
> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl>
> <http://msggen.pl> -l
> jstyleModule InterpreterMessages.msg
> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl>
> <http://msggen.pl> -l
> jstyleModule DssslAppMessages.msg
> Undefined subroutine&main::Getopts called at
> ./../msggen.pl <http://msggen.pl>
> <http://msggen.pl> line 22.
> make[2]: *** [InterpreterMessages.h] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Undefined subroutine&main::Getopts called at
> ./../msggen.pl <http://msggen.pl>
> <http://msggen.pl> line 22.
> make[2]: *** [DssslAppMessages.h] Error 2
>
> Upstream-Status: Submitted
> [openjade-devel@lists.__source__forge.net
> <http://sourceforge.net>
> <mailto:openjade-devel@lists.__sourceforge.net
> <mailto:openjade-devel@lists.sourceforge.net>>]
>
> This needs to be in the patch file itself, we can track the
> patches
> better that way.
>
> Signed-off-by: Dennis Lan<dennis.yxun@gmail.com
> <mailto:dennis.yxun@gmail.com>
> <mailto:dennis.yxun@gmail.com <mailto:dennis.yxun@gmail.com>>__>
> ---
> .../openjade/openjade-1.3.2/____msggen.pl.patch
> | 32
> ++++++++++++++++++++
> .../openjade/openjade-native_____1.3.2.bb
> <http://openjade-native___1.3.2.bb>
> <http://openjade-native_1.3.2.__bb
> <http://openjade-native_1.3.2.bb>> | 1 +
> 2 files changed, 33 insertions(+), 0 deletions(-)
> create mode 100644
>
> meta/recipes-devtools/____openjade/openjade-1.3.2/____msggen.pl.patch
>
> diff --git
>
> a/meta/recipes-devtools/____openjade/openjade-1.3.2/____msggen.pl.patch
>
> b/meta/recipes-devtools/____openjade/openjade-1.3.2/____msggen.pl.patch
> new file mode 100644
> index 0000000..1afe68b
> --- /dev/null
> +++
>
> b/meta/recipes-devtools/____openjade/openjade-1.3.2/____msggen.pl.patch
>
>
> Please add comment Upstream-Status and SOB to the patch itself.
>
> Thanks
> Sau!
>
> @@ -0,0 +1,32 @@
> +Use Getopt::Std in place of getopts.pl
> <http://getopts.pl> <http://getopts.pl>.
> +https://bugs.gentoo.org/show_____bug.cgi?id=420083
> <https://bugs.gentoo.org/show___bug.cgi?id=420083>
> <https://bugs.gentoo.org/show___bug.cgi?id=420083
> <https://bugs.gentoo.org/show_bug.cgi?id=420083>>
> +
> +--- a/msggen.pl <http://msggen.pl> <http://msggen.pl>
> ++++ b/msggen.pl <http://msggen.pl> <http://msggen.pl>
> +@@ -4,6 +4,7 @@
> + # See the file COPYING for copying permission.
> +
> + use POSIX;
> ++use Getopt::Std;
> +
> + # Package and version.
> + $package = 'openjade';
> +@@ -18,8 +19,7 @@
> + undef $opt_l;
> + undef $opt_p;
> + undef $opt_t;
> +-do 'getopts.pl <http://getopts.pl> <http://getopts.pl>';
> +-&Getopts('l:p:t:');
> ++getopts('l:p:t:');
> + $module = $opt_l;
> + $pot_file = $opt_p;
> +
> +@@ -72,7 +72,7 @@
> + else {
> + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid
> first
> field");;
> + $type[$num] = substr($field[0], 0, 1);
> +- $argc = int(substr($field[0], 1, 1));
> ++ $argc = substr($field[0], 1, 1);
> + }
> + $nargs[$num] = $argc;
> + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/
> ||&error("invalid
> tag");
> diff --git
>
> a/meta/recipes-devtools/____openjade/openjade-native_1.3.____2.bb <http://2.bb>
> <http://openjade-native_1.3.2.__bb
> <http://openjade-native_1.3.2.bb>>
>
> b/meta/recipes-devtools/____openjade/openjade-native_1.3.____2.bb <http://2.bb>
> <http://openjade-native_1.3.2.__bb
> <http://openjade-native_1.3.2.bb>>
> index 5b29c1f..efd1e11 100644
> ---
>
> a/meta/recipes-devtools/____openjade/openjade-native_1.3.____2.bb <http://2.bb>
> <http://openjade-native_1.3.2.__bb
> <http://openjade-native_1.3.2.bb>>
> +++
>
> b/meta/recipes-devtools/____openjade/openjade-native_1.3.____2.bb <http://2.bb>
> <http://openjade-native_1.3.2.__bb
> <http://openjade-native_1.3.2.bb>>
> @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
>
> SRC_URI =
> "${SOURCEFORGE_MIRROR}/____openjade/openjade-${PV}.tar.gz \
> file://makefile.patch \
> + file://msggen.pl.patch \
> file://reautoconf.patch \
>
> file://user-declared-default-____constructor.patch"
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-07-03 0:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-28 4:56 [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace dennis lan
2012-06-28 6:02 ` Dennis.Yxun
2012-06-28 17:27 ` Saul Wold
2012-07-02 22:24 ` Dennis.Yxun
2012-07-02 23:46 ` Saul Wold
2012-07-03 0:29 ` Dennis.Yxun
2012-07-03 0:46 ` Saul Wold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.