From: William Zhang <william.zhang@broadcom.com> To: Florian Fainelli <f.fainelli@gmail.com>, Linux ARM List <linux-arm-kernel@lists.infradead.org> Cc: dan.beygelman@broadcom.com, philippe.reynes@softathome.com, anand.gore@broadcom.com, tomer.yacoby@broadcom.com, samyon.furman@broadcom.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] arm64: dts: add dts files for bcmbca SoC bcm4912 Date: Wed, 1 Jun 2022 09:20:14 -0700 [thread overview] Message-ID: <4a78703b-7c58-913c-3c36-1fec4455b946@broadcom.com> (raw) In-Reply-To: <0b4abf17-f44d-dec4-56f4-0ae12e49b05b@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2134 bytes --] On 6/1/22 02:47, Florian Fainelli wrote: > > > On 5/31/2022 5:42 PM, William Zhang wrote: >> Add dts for ARMv8 based broadband SoC BCM4912. bcm4912.dtsi is the >> SoC description dts header and bcm94912.dts is a simple dts file for >> Broadcom BCM94912 Reference board that only enable the UART port. >> >> Signed-off-by: William Zhang <william.zhang@broadcom.com> >> >> --- > > [snip] > >> + >> + axi@81000000 { >> + compatible = "simple-bus"; >> + #address-cells = <2>; >> + #size-cells = <2>; > > See comment below for the ubus node. > >> + ranges = <0x0 0x0 0x0 0x81000000 0x0 0x8000>; >> + >> + gic: interrupt-controller@1000 { >> + compatible = "arm,gic-400"; >> + #interrupt-cells = <3>; >> + interrupt-controller; >> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | >> IRQ_TYPE_LEVEL_HIGH)>; >> + reg = <0x0 0x1000 0x0 0x1000>, >> + <0x0 0x2000 0x0 0x2000>, >> + <0x0 0x4000 0x0 0x2000>, >> + <0x0 0x6000 0x0 0x2000>; >> + }; >> + }; >> + >> + bus@ff800000 { >> + compatible = "simple-bus"; >> + #address-cells = <2>; >> + #size-cells = <2>; > > This does not quite make sense, as I doubt that this part of the bus is > 64-bit capable, rather, I would expect to find both #address-cells and > #size-cells to be set to 1 and ... (see below) > Agree. It can be simplified to use 32 bit address and size. >> + ranges = <0x0 0x0 0x0 0xff800000 0x0 0x800000>; >> + >> + uart0: serial@12000 { >> + compatible = "arm,pl011", "arm,primecell"; >> + reg = <0x0 0x12000 0x0 0x1000>; > > ... have this become simply: > > reg = <0x12000 0x1000>: > > which also looks awfully big for an UART block, an entire 4KB worth of > register space? That is the correct based on the rdb. [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4212 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: William Zhang <william.zhang@broadcom.com> To: Florian Fainelli <f.fainelli@gmail.com>, Linux ARM List <linux-arm-kernel@lists.infradead.org> Cc: dan.beygelman@broadcom.com, philippe.reynes@softathome.com, anand.gore@broadcom.com, tomer.yacoby@broadcom.com, samyon.furman@broadcom.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] arm64: dts: add dts files for bcmbca SoC bcm4912 Date: Wed, 1 Jun 2022 09:20:14 -0700 [thread overview] Message-ID: <4a78703b-7c58-913c-3c36-1fec4455b946@broadcom.com> (raw) In-Reply-To: <0b4abf17-f44d-dec4-56f4-0ae12e49b05b@gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 2134 bytes --] On 6/1/22 02:47, Florian Fainelli wrote: > > > On 5/31/2022 5:42 PM, William Zhang wrote: >> Add dts for ARMv8 based broadband SoC BCM4912. bcm4912.dtsi is the >> SoC description dts header and bcm94912.dts is a simple dts file for >> Broadcom BCM94912 Reference board that only enable the UART port. >> >> Signed-off-by: William Zhang <william.zhang@broadcom.com> >> >> --- > > [snip] > >> + >> + axi@81000000 { >> + compatible = "simple-bus"; >> + #address-cells = <2>; >> + #size-cells = <2>; > > See comment below for the ubus node. > >> + ranges = <0x0 0x0 0x0 0x81000000 0x0 0x8000>; >> + >> + gic: interrupt-controller@1000 { >> + compatible = "arm,gic-400"; >> + #interrupt-cells = <3>; >> + interrupt-controller; >> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | >> IRQ_TYPE_LEVEL_HIGH)>; >> + reg = <0x0 0x1000 0x0 0x1000>, >> + <0x0 0x2000 0x0 0x2000>, >> + <0x0 0x4000 0x0 0x2000>, >> + <0x0 0x6000 0x0 0x2000>; >> + }; >> + }; >> + >> + bus@ff800000 { >> + compatible = "simple-bus"; >> + #address-cells = <2>; >> + #size-cells = <2>; > > This does not quite make sense, as I doubt that this part of the bus is > 64-bit capable, rather, I would expect to find both #address-cells and > #size-cells to be set to 1 and ... (see below) > Agree. It can be simplified to use 32 bit address and size. >> + ranges = <0x0 0x0 0x0 0xff800000 0x0 0x800000>; >> + >> + uart0: serial@12000 { >> + compatible = "arm,pl011", "arm,primecell"; >> + reg = <0x0 0x12000 0x0 0x1000>; > > ... have this become simply: > > reg = <0x12000 0x1000>: > > which also looks awfully big for an UART block, an entire 4KB worth of > register space? That is the correct based on the rdb. [-- Attachment #1.2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4212 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-01 16:20 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-01 0:42 [PATCH v2 0/3] arm64: bcmbca: add bcm4912 SoC support William Zhang 2022-06-01 0:42 ` William Zhang 2022-06-01 0:42 ` [PATCH v2 1/3] dt-bindings: arm64: add bcm4912 SoC William Zhang 2022-06-01 0:42 ` William Zhang 2022-06-01 9:29 ` Krzysztof Kozlowski 2022-06-01 9:29 ` Krzysztof Kozlowski 2022-06-01 0:42 ` [PATCH v2 2/3] arm64: dts: add dts files for bcmbca SoC bcm4912 William Zhang 2022-06-01 0:42 ` William Zhang 2022-06-01 9:47 ` Florian Fainelli 2022-06-01 9:47 ` Florian Fainelli 2022-06-01 16:20 ` William Zhang [this message] 2022-06-01 16:20 ` William Zhang 2022-06-01 0:42 ` [PATCH v2 3/3] MAINTAINERS: add bcm4912 to bcmbca arch entry William Zhang 2022-06-01 0:42 ` William Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4a78703b-7c58-913c-3c36-1fec4455b946@broadcom.com \ --to=william.zhang@broadcom.com \ --cc=anand.gore@broadcom.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=dan.beygelman@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=joel.peshkin@broadcom.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kursad.oney@broadcom.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=philippe.reynes@softathome.com \ --cc=robh+dt@kernel.org \ --cc=samyon.furman@broadcom.com \ --cc=tomer.yacoby@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.