[dm-devel] [PATCH v3 resend] multipathd: fix path checkint not changed when path state changed from delay to failed

[dm-devel] [PATCH v3 resend] multipathd: fix path checkint not changed when path state changed from delay to failed

[Chongyun Wu]

Thank you, Ben and Martin, this is the resend version in text format.

 From 45dad5fa6a9fb42648c8f5f54d6db974974d9612 Mon Sep 17 00:00:00 2001
From: Chongyun Wu <wucy11@chinatelecom.cn>
Date: Wed, 16 Dec 2020 13:59:16 +0800
Subject: [PATCH] multipathd: fix path checkint not changed when path 
state changed from delay to failed

Check_path: when path state change back to failed from delay state, 
should change this path's check interval time to the shortest delay to 
faster path state check.

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Chongyun Wu <wucy11@chinatelecom.cn>
---
  multipathd/main.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/multipathd/main.c b/multipathd/main.c
index a4abbb27..9fd34e97 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2166,6 +2166,11 @@ check_path (struct vectors * vecs, struct path * 
pp, unsigned int ticks)
  			(pp->state == PATH_DELAYED)) {
  		/* If path state become failed again cancel path delay state */
  		pp->state = newstate;
+		/*
+		 * path state bad again should change the check interval time
+		 * to the shortest delay
+		 */
+		pp->checkint = checkint;
  		return 1;
  	}
  	if (!pp->mpp) {
-- 
2.29.2.windows.3

-- 
Best Regard,
Chongyun Wu

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v3 resend] multipathd: fix path checkint not changed when path state changed from delay to failed

[Martin Wilck]

On Wed, 2021-01-06 at 09:39 +0800, Chongyun Wu wrote:
> Thank you, Ben and Martin, this is the resend version in text format.
> 
>  From 45dad5fa6a9fb42648c8f5f54d6db974974d9612 Mon Sep 17 00:00:00
> 2001
> From: Chongyun Wu <wucy11@chinatelecom.cn>
> Date: Wed, 16 Dec 2020 13:59:16 +0800
> Subject: [PATCH] multipathd: fix path checkint not changed when path 
> state changed from delay to failed
> 
> Check_path: when path state change back to failed from delay state, 
> should change this path's check interval time to the shortest delay
> to 
> faster path state check.
> 
> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Signed-off-by: Chongyun Wu <wucy11@chinatelecom.cn>

Thanks again, pushed to the "upstream-queue" branch on
github.com/openSUSE/multipath-tools.

Martin



--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel