From: Nathan Chancellor <nathan@kernel.org> To: Nick Desaulniers <ndesaulniers@google.com>, Michael Ellerman <mpe@ellerman.id.au> Cc: Oliver O'Halloran <oohall@gmail.com>, Joe Perches <joe@perches.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] powerpc/powernv/pci: fix header guard Date: Tue, 18 May 2021 13:41:49 -0700 [thread overview] Message-ID: <4aa06438-7bea-a5a6-ff64-0cf8c28e2511@kernel.org> (raw) In-Reply-To: <20210518204044.2390064-1-ndesaulniers@google.com> On 5/18/2021 1:40 PM, Nick Desaulniers wrote: > While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a > possible candidate to convert to #ifdef CONFIG_EEH. > > It seems that based on Kconfig dependencies it's not possible to build > this file without CONFIG_EEH enabled, but based on upstream discussion, > it's not clear yet that CONFIG_EEH should be enabled by default. > > For now, simply fix the -Wundef warning. > > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Joe Perches <joe@perches.com> > Link: https://github.com/ClangBuiltLinux/linux/issues/570 > Link: https://lore.kernel.org/lkml/67f6cd269684c9aa8463ff4812c3b4605e6739c3.camel@perches.com/ > Link: https://lore.kernel.org/lkml/CAOSf1CGoN5R0LUrU=Y=UWho1Z_9SLgCX8s3SbFJXwJXc5BYz4A@mail.gmail.com/ > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Makes sense, thanks for the patch! Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > arch/powerpc/platforms/powernv/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c > index b18468dc31ff..6bb3c52633fb 100644 > --- a/arch/powerpc/platforms/powernv/pci.c > +++ b/arch/powerpc/platforms/powernv/pci.c > @@ -711,7 +711,7 @@ int pnv_pci_cfg_write(struct pci_dn *pdn, > return PCIBIOS_SUCCESSFUL; > } > > -#if CONFIG_EEH > +#ifdef CONFIG_EEH > static bool pnv_pci_cfg_check(struct pci_dn *pdn) > { > struct eeh_dev *edev = NULL; >
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org> To: Nick Desaulniers <ndesaulniers@google.com>, Michael Ellerman <mpe@ellerman.id.au> Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, linux-kernel@vger.kernel.org, Oliver O'Halloran <oohall@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Joe Perches <joe@perches.com>, Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] powerpc/powernv/pci: fix header guard Date: Tue, 18 May 2021 13:41:49 -0700 [thread overview] Message-ID: <4aa06438-7bea-a5a6-ff64-0cf8c28e2511@kernel.org> (raw) In-Reply-To: <20210518204044.2390064-1-ndesaulniers@google.com> On 5/18/2021 1:40 PM, Nick Desaulniers wrote: > While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a > possible candidate to convert to #ifdef CONFIG_EEH. > > It seems that based on Kconfig dependencies it's not possible to build > this file without CONFIG_EEH enabled, but based on upstream discussion, > it's not clear yet that CONFIG_EEH should be enabled by default. > > For now, simply fix the -Wundef warning. > > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Joe Perches <joe@perches.com> > Link: https://github.com/ClangBuiltLinux/linux/issues/570 > Link: https://lore.kernel.org/lkml/67f6cd269684c9aa8463ff4812c3b4605e6739c3.camel@perches.com/ > Link: https://lore.kernel.org/lkml/CAOSf1CGoN5R0LUrU=Y=UWho1Z_9SLgCX8s3SbFJXwJXc5BYz4A@mail.gmail.com/ > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Makes sense, thanks for the patch! Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > arch/powerpc/platforms/powernv/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c > index b18468dc31ff..6bb3c52633fb 100644 > --- a/arch/powerpc/platforms/powernv/pci.c > +++ b/arch/powerpc/platforms/powernv/pci.c > @@ -711,7 +711,7 @@ int pnv_pci_cfg_write(struct pci_dn *pdn, > return PCIBIOS_SUCCESSFUL; > } > > -#if CONFIG_EEH > +#ifdef CONFIG_EEH > static bool pnv_pci_cfg_check(struct pci_dn *pdn) > { > struct eeh_dev *edev = NULL; >
next prev parent reply other threads:[~2021-05-18 20:41 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 19:54 [PATCH] powerpc/powernv/pci: remove dead code from !CONFIG_EEH Nick Desaulniers 2021-04-22 19:54 ` Nick Desaulniers 2021-04-22 23:09 ` Daniel Axtens 2021-04-22 23:09 ` Daniel Axtens 2021-04-23 1:13 ` Oliver O'Halloran 2021-04-23 1:13 ` Oliver O'Halloran 2021-05-18 0:16 ` Nick Desaulniers 2021-05-18 0:16 ` Nick Desaulniers 2021-05-18 6:13 ` Michael Ellerman 2021-05-18 6:13 ` Michael Ellerman 2021-05-18 20:40 ` [PATCH v2] powerpc/powernv/pci: fix header guard Nick Desaulniers 2021-05-18 20:40 ` Nick Desaulniers 2021-05-18 20:41 ` Nathan Chancellor [this message] 2021-05-18 20:41 ` Nathan Chancellor 2021-06-06 12:08 ` Michael Ellerman 2021-06-06 12:08 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4aa06438-7bea-a5a6-ff64-0cf8c28e2511@kernel.org \ --to=nathan@kernel.org \ --cc=aik@ozlabs.ru \ --cc=benh@kernel.crashing.org \ --cc=gregkh@linuxfoundation.org \ --cc=joe@perches.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=ndesaulniers@google.com \ --cc=oohall@gmail.com \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.