From: Vladimir Zapolskiy <vz@mleia.com> To: Kuldeep Singh <singh.kuldeep87k@gmail.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, soc@kernel.org, Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] ARM: dts: lpc32xx: Update spi clock properties Date: Fri, 11 Mar 2022 15:20:41 +0200 [thread overview] Message-ID: <4aae560d-d266-d0d0-136f-32891b15bc01@mleia.com> (raw) In-Reply-To: <20220311093800.18778-4-singh.kuldeep87k@gmail.com> On 3/11/22 11:38 AM, Kuldeep Singh wrote: > PL022 binding require two clocks to be defined but lpc platform doesn't > comply with bindings and define only one clock i.e apb_pclk. > > Update spi clocks and clocks-names property by adding appropriate clock > reference to make it compliant with bindings. > > CC: Vladimir Zapolskiy <vz@mleia.com> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > v2: > - New patch with similar changeset > - Send to soc ML > > arch/arm/boot/dts/lpc32xx.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi > index c87066d6c995..30958e02d5e2 100644 > --- a/arch/arm/boot/dts/lpc32xx.dtsi > +++ b/arch/arm/boot/dts/lpc32xx.dtsi > @@ -178,8 +178,8 @@ ssp0: spi@20084000 { > compatible = "arm,pl022", "arm,primecell"; > reg = <0x20084000 0x1000>; > interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk LPC32XX_CLK_SSP0>; > - clock-names = "apb_pclk"; > + clocks = <&clk LPC32XX_CLK_SSP0>, <&clk LPC32XX_CLK_SSP0>; > + clock-names = "sspclk", "apb_pclk"; In fact I'm uncertain if it is the right change, could it happen that the commit cc0f6e96c4fd ("spi: dt-bindings: Convert Arm pl022 to json-schema") sets a wrong schema pattern? Apparently just one clock is wanted on all observed platforms and cases, this is implicitly confirmed by clock handling in the drivers/spi/spi-pl022.c : pl022->clk = devm_clk_get(&adev->dev, NULL); So, I would vote to fix the device tree bindings schema. > #address-cells = <1>; > #size-cells = <0>; > status = "disabled"; > @@ -202,8 +202,8 @@ ssp1: spi@2008c000 { > compatible = "arm,pl022", "arm,primecell"; > reg = <0x2008c000 0x1000>; > interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk LPC32XX_CLK_SSP1>; > - clock-names = "apb_pclk"; > + clocks = <&clk LPC32XX_CLK_SSP1>, <&clk LPC32XX_CLK_SSP1>; > + clock-names = "sspclk", "apb_pclk"; > #address-cells = <1>; > #size-cells = <0>; > status = "disabled"; > -- Best wishes, Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vz@mleia.com> To: Kuldeep Singh <singh.kuldeep87k@gmail.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, soc@kernel.org, Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] ARM: dts: lpc32xx: Update spi clock properties Date: Fri, 11 Mar 2022 15:20:41 +0200 [thread overview] Message-ID: <4aae560d-d266-d0d0-136f-32891b15bc01@mleia.com> (raw) In-Reply-To: <20220311093800.18778-4-singh.kuldeep87k@gmail.com> On 3/11/22 11:38 AM, Kuldeep Singh wrote: > PL022 binding require two clocks to be defined but lpc platform doesn't > comply with bindings and define only one clock i.e apb_pclk. > > Update spi clocks and clocks-names property by adding appropriate clock > reference to make it compliant with bindings. > > CC: Vladimir Zapolskiy <vz@mleia.com> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > v2: > - New patch with similar changeset > - Send to soc ML > > arch/arm/boot/dts/lpc32xx.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi > index c87066d6c995..30958e02d5e2 100644 > --- a/arch/arm/boot/dts/lpc32xx.dtsi > +++ b/arch/arm/boot/dts/lpc32xx.dtsi > @@ -178,8 +178,8 @@ ssp0: spi@20084000 { > compatible = "arm,pl022", "arm,primecell"; > reg = <0x20084000 0x1000>; > interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk LPC32XX_CLK_SSP0>; > - clock-names = "apb_pclk"; > + clocks = <&clk LPC32XX_CLK_SSP0>, <&clk LPC32XX_CLK_SSP0>; > + clock-names = "sspclk", "apb_pclk"; In fact I'm uncertain if it is the right change, could it happen that the commit cc0f6e96c4fd ("spi: dt-bindings: Convert Arm pl022 to json-schema") sets a wrong schema pattern? Apparently just one clock is wanted on all observed platforms and cases, this is implicitly confirmed by clock handling in the drivers/spi/spi-pl022.c : pl022->clk = devm_clk_get(&adev->dev, NULL); So, I would vote to fix the device tree bindings schema. > #address-cells = <1>; > #size-cells = <0>; > status = "disabled"; > @@ -202,8 +202,8 @@ ssp1: spi@2008c000 { > compatible = "arm,pl022", "arm,primecell"; > reg = <0x2008c000 0x1000>; > interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk LPC32XX_CLK_SSP1>; > - clock-names = "apb_pclk"; > + clocks = <&clk LPC32XX_CLK_SSP1>, <&clk LPC32XX_CLK_SSP1>; > + clock-names = "sspclk", "apb_pclk"; > #address-cells = <1>; > #size-cells = <0>; > status = "disabled"; > -- Best wishes, Vladimir _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-11 13:21 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-11 9:37 [PATCH v2 0/3] PL022 DT fixes for seattle, lg and lpc platform Kuldeep Singh 2022-03-11 9:37 ` Kuldeep Singh 2022-03-11 9:37 ` [PATCH v2 1/3] arm64: dts: seattle: Update spi clock properties Kuldeep Singh 2022-03-11 9:37 ` Kuldeep Singh 2022-03-11 9:37 ` [PATCH v2 2/3] arm64: dts: lg131x: " Kuldeep Singh 2022-03-11 9:37 ` Kuldeep Singh 2022-03-11 9:38 ` [PATCH v2 3/3] ARM: dts: lpc32xx: " Kuldeep Singh 2022-03-11 9:38 ` Kuldeep Singh 2022-03-11 13:20 ` Vladimir Zapolskiy [this message] 2022-03-11 13:20 ` Vladimir Zapolskiy 2022-03-11 13:38 ` Arnd Bergmann 2022-03-11 13:38 ` Arnd Bergmann 2022-03-11 14:07 ` Vladimir Zapolskiy 2022-03-11 14:07 ` Vladimir Zapolskiy 2022-03-11 14:33 ` Krzysztof Kozlowski 2022-03-11 14:33 ` Krzysztof Kozlowski 2022-03-11 21:26 ` Vladimir Zapolskiy 2022-03-11 21:26 ` Vladimir Zapolskiy 2022-03-12 10:23 ` Krzysztof Kozlowski 2022-03-12 10:23 ` Krzysztof Kozlowski 2022-03-12 12:26 ` Vladimir Zapolskiy 2022-03-12 12:26 ` Vladimir Zapolskiy 2022-03-14 11:43 ` Robin Murphy 2022-03-14 11:43 ` Robin Murphy 2022-03-14 11:50 ` Vladimir Zapolskiy 2022-03-14 11:50 ` Vladimir Zapolskiy 2022-03-14 12:20 ` Robin Murphy 2022-03-14 12:20 ` Robin Murphy 2022-03-14 12:32 ` Arnd Bergmann 2022-03-14 12:32 ` Arnd Bergmann 2022-03-14 17:55 ` Robin Murphy 2022-03-14 17:55 ` Robin Murphy 2022-03-14 12:34 ` Vladimir Zapolskiy 2022-03-14 12:34 ` Vladimir Zapolskiy 2022-03-27 2:57 ` Trevor Woerner 2022-03-27 16:27 ` Vladimir Zapolskiy 2022-03-27 16:27 ` Vladimir Zapolskiy 2022-03-27 18:32 ` Trevor Woerner 2022-03-27 18:32 ` Trevor Woerner 2022-03-11 10:50 ` [PATCH v2 0/3] PL022 DT fixes for seattle, lg and lpc platform patchwork-bot+linux-soc
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4aae560d-d266-d0d0-136f-32891b15bc01@mleia.com \ --to=vz@mleia.com \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=olof@lixom.net \ --cc=robh+dt@kernel.org \ --cc=singh.kuldeep87k@gmail.com \ --cc=soc@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.