All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rafael Aquini <aquini@redhat.com>
To: linux-mm@kvack.org
Cc: Rik van Riel <riel@redhat.com>, Rafael Aquini <aquini@redhat.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Minchan Kim <minchan@kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rafael Aquini <aquini@linux.com>
Subject: [PATCH v4 3/3] mm: add vm event counters for balloon pages compaction
Date: Tue, 17 Jul 2012 13:50:43 -0300	[thread overview]
Message-ID: <4af2f0d495db34075d6bf4f921f326c6eb71cf2d.1342485774.git.aquini__33936.7527085871$1342543918$gmane$org@redhat.com> (raw)
In-Reply-To: <cover.1342485774.git.aquini@redhat.com>
In-Reply-To: <cover.1342485774.git.aquini@redhat.com>

This patch is only for testing report purposes and shall be dropped in case of
the rest of this patchset getting accepted for merging.

Signed-off-by: Rafael Aquini <aquini@redhat.com>
---
 drivers/virtio/virtio_balloon.c |    1 +
 include/linux/vm_event_item.h   |    2 ++
 mm/compaction.c                 |    1 +
 mm/migrate.c                    |    6 ++++--
 mm/vmstat.c                     |    4 ++++
 5 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 7669bc8..c4ddcd7 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -410,6 +410,7 @@ int virtballoon_migratepage(struct address_space *mapping,
 
 	mutex_unlock(&balloon_lock);
 
+	count_vm_event(COMPACTBALLOONMIGRATED);
 	return 0;
 }
 
diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index 06f8e38..e330c5a 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -40,6 +40,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
 #ifdef CONFIG_COMPACTION
 		COMPACTBLOCKS, COMPACTPAGES, COMPACTPAGEFAILED,
 		COMPACTSTALL, COMPACTFAIL, COMPACTSUCCESS,
+		COMPACTBALLOONMIGRATED, COMPACTBALLOONFAILED,
+		COMPACTBALLOONISOLATED, COMPACTBALLOONFREED,
 #endif
 #ifdef CONFIG_HUGETLB_PAGE
 		HTLB_BUDDY_PGALLOC, HTLB_BUDDY_PGALLOC_FAIL,
diff --git a/mm/compaction.c b/mm/compaction.c
index 51eac0c..d212dde 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -72,6 +72,7 @@ static bool isolate_balloon_page(struct page *page)
 			if (is_balloon_page(page) && (page_count(page) == 2)) {
 				__isolate_balloon_page(page);
 				unlock_page(page);
+				count_vm_event(COMPACTBALLOONISOLATED);
 				return true;
 			}
 			unlock_page(page);
diff --git a/mm/migrate.c b/mm/migrate.c
index 59c7bc5..5838719 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -78,9 +78,10 @@ void putback_lru_pages(struct list_head *l)
 		list_del(&page->lru);
 		dec_zone_page_state(page, NR_ISOLATED_ANON +
 				page_is_file_cache(page));
-		if (unlikely(is_balloon_page(page)))
+		if (unlikely(is_balloon_page(page))) {
+			count_vm_event(COMPACTBALLOONFAILED);
 			WARN_ON(!putback_balloon_page(page));
-		else
+		} else
 			putback_lru_page(page);
 	}
 }
@@ -878,6 +879,7 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
 				    page_is_file_cache(page));
 		put_page(page);
 		__free_page(page);
+		count_vm_event(COMPACTBALLOONFREED);
 		return rc;
 	}
 out:
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 1bbbbd9..3b7109f 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -767,6 +767,10 @@ const char * const vmstat_text[] = {
 	"compact_stall",
 	"compact_fail",
 	"compact_success",
+	"compact_balloon_migrated",
+	"compact_balloon_failed",
+	"compact_balloon_isolated",
+	"compact_balloon_freed",
 #endif
 
 #ifdef CONFIG_HUGETLB_PAGE
-- 
1.7.10.4

  parent reply	other threads:[~2012-07-17 16:50 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 16:50 [PATCH v4 0/3] make balloon pages movable by compaction Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini
2012-07-17 16:50 ` [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini
2012-07-17 16:50   ` Rafael Aquini
2012-07-18  5:48   ` Minchan Kim
2012-07-18  5:48   ` Minchan Kim
2012-07-18  5:48     ` Minchan Kim
2012-07-20 19:48     ` Rafael Aquini
2012-07-20 19:48       ` Rafael Aquini
2012-07-20 19:48       ` Rafael Aquini
2012-07-23  2:33       ` Minchan Kim
2012-07-23  2:33       ` Minchan Kim
2012-07-23  2:33         ` Minchan Kim
2012-07-23  2:35         ` Minchan Kim
2012-07-23  2:35         ` Minchan Kim
2012-07-23  2:35           ` Minchan Kim
2012-07-23 18:19         ` Rafael Aquini
2012-07-23 18:19           ` Rafael Aquini
2012-07-23 18:19           ` Rafael Aquini
2012-08-01 20:53           ` Rik van Riel
2012-08-01 20:53             ` Rik van Riel
2012-08-03 11:13             ` Rafael Aquini
2012-08-03 11:13               ` Rafael Aquini
2012-08-03 11:13               ` Rafael Aquini
2012-08-01 20:53           ` Rik van Riel
2012-08-01 20:51         ` Rik van Riel
2012-08-01 20:51         ` Rik van Riel
2012-08-01 20:51           ` Rik van Riel
2012-08-03 12:26         ` Rafael Aquini
2012-08-03 12:26           ` Rafael Aquini
2012-08-03 12:26         ` Rafael Aquini
2012-07-18 22:46   ` Andrew Morton
2012-07-18 22:46     ` Andrew Morton
2012-07-18 22:46     ` Andrew Morton
2012-07-18 23:07     ` Rafael Aquini
2012-07-18 23:07     ` Rafael Aquini
2012-07-18 23:07       ` Rafael Aquini
2012-07-18 23:12       ` Andrew Morton
2012-07-18 23:12         ` Andrew Morton
2012-07-18 23:12         ` Andrew Morton
2012-07-19  1:00         ` Rafael Aquini
2012-07-19  1:00         ` Rafael Aquini
2012-07-19  1:00           ` Rafael Aquini
2012-07-19  1:29           ` Andrew Morton
2012-07-19  1:29           ` Andrew Morton
2012-07-19  1:29             ` Andrew Morton
2012-07-19 12:32             ` Rafael Aquini
2012-07-19 12:32               ` Rafael Aquini
2012-07-19 12:32               ` Rafael Aquini
2012-07-17 16:50 ` [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-07-17 16:50   ` Rafael Aquini
2012-07-18 22:49   ` Andrew Morton
2012-07-18 22:49     ` Andrew Morton
2012-07-18 22:49     ` Andrew Morton
2012-07-18 23:16     ` Rafael Aquini
2012-07-18 23:16     ` Rafael Aquini
2012-07-18 23:16       ` Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini [this message]
2012-07-17 16:50 ` [PATCH v4 3/3] mm: add vm event counters for balloon pages compaction Rafael Aquini
2012-07-17 16:50   ` Rafael Aquini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='4af2f0d495db34075d6bf4f921f326c6eb71cf2d.1342485774.git.aquini__33936.7527085871$1342543918$gmane$org@redhat.com' \
    --to=aquini@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=aquini@linux.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=mst@redhat.com \
    --cc=riel@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.