All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rafael Aquini <aquini@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Minchan Kim <minchan@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Rafael Aquini <aquini@linux.com>
Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages
Date: Fri, 3 Aug 2012 08:13:09 -0300	[thread overview]
Message-ID: <20120803111309.GA1848@t510.redhat.com> (raw)
In-Reply-To: <5019975B.6010708@redhat.com>

On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote:
> On 07/23/2012 02:19 PM, Rafael Aquini wrote:
> 
> >In a glance, I believe this whole dance you're suggesting might just be too much
> >of an overcomplication, and the best approach would be simply teaching the
> >hotplug bits about the ballooned corner case just like it's being done to
> >compaction/migration. However, I'll look at it carefully before making any other
> >adjustments/propositions over here.
> 
> Compaction and hotplug do essentially the same thing
> here: "collect all the movable pages from a page block,
> and move them elsewhere".
> 
> Whether or not it is easier for them to share code, or
> to duplicate a few lines of code, is something that can
> be looked into later.

I'm 100% in agreement with your thoughts here.


WARNING: multiple messages have this Message-ID (diff)
From: Rafael Aquini <aquini@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Minchan Kim <minchan@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Rafael Aquini <aquini@linux.com>
Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages
Date: Fri, 3 Aug 2012 08:13:09 -0300	[thread overview]
Message-ID: <20120803111309.GA1848@t510.redhat.com> (raw)
In-Reply-To: <5019975B.6010708@redhat.com>

On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote:
> On 07/23/2012 02:19 PM, Rafael Aquini wrote:
> 
> >In a glance, I believe this whole dance you're suggesting might just be too much
> >of an overcomplication, and the best approach would be simply teaching the
> >hotplug bits about the ballooned corner case just like it's being done to
> >compaction/migration. However, I'll look at it carefully before making any other
> >adjustments/propositions over here.
> 
> Compaction and hotplug do essentially the same thing
> here: "collect all the movable pages from a page block,
> and move them elsewhere".
> 
> Whether or not it is easier for them to share code, or
> to duplicate a few lines of code, is something that can
> be looked into later.

I'm 100% in agreement with your thoughts here.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Rafael Aquini <aquini@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	Minchan Kim <minchan@kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rafael Aquini <aquini@linux.com>
Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages
Date: Fri, 3 Aug 2012 08:13:09 -0300	[thread overview]
Message-ID: <20120803111309.GA1848@t510.redhat.com> (raw)
In-Reply-To: <5019975B.6010708@redhat.com>

On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote:
> On 07/23/2012 02:19 PM, Rafael Aquini wrote:
> 
> >In a glance, I believe this whole dance you're suggesting might just be too much
> >of an overcomplication, and the best approach would be simply teaching the
> >hotplug bits about the ballooned corner case just like it's being done to
> >compaction/migration. However, I'll look at it carefully before making any other
> >adjustments/propositions over here.
> 
> Compaction and hotplug do essentially the same thing
> here: "collect all the movable pages from a page block,
> and move them elsewhere".
> 
> Whether or not it is easier for them to share code, or
> to duplicate a few lines of code, is something that can
> be looked into later.

I'm 100% in agreement with your thoughts here.

  reply	other threads:[~2012-08-03 11:13 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 16:50 [PATCH v4 0/3] make balloon pages movable by compaction Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini
2012-07-17 16:50 ` [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini
2012-07-17 16:50   ` Rafael Aquini
2012-07-18  5:48   ` Minchan Kim
2012-07-18  5:48   ` Minchan Kim
2012-07-18  5:48     ` Minchan Kim
2012-07-20 19:48     ` Rafael Aquini
2012-07-20 19:48       ` Rafael Aquini
2012-07-20 19:48       ` Rafael Aquini
2012-07-23  2:33       ` Minchan Kim
2012-07-23  2:33       ` Minchan Kim
2012-07-23  2:33         ` Minchan Kim
2012-07-23  2:35         ` Minchan Kim
2012-07-23  2:35         ` Minchan Kim
2012-07-23  2:35           ` Minchan Kim
2012-07-23 18:19         ` Rafael Aquini
2012-07-23 18:19           ` Rafael Aquini
2012-07-23 18:19           ` Rafael Aquini
2012-08-01 20:53           ` Rik van Riel
2012-08-01 20:53             ` Rik van Riel
2012-08-03 11:13             ` Rafael Aquini [this message]
2012-08-03 11:13               ` Rafael Aquini
2012-08-03 11:13               ` Rafael Aquini
2012-08-01 20:53           ` Rik van Riel
2012-08-01 20:51         ` Rik van Riel
2012-08-01 20:51         ` Rik van Riel
2012-08-01 20:51           ` Rik van Riel
2012-08-03 12:26         ` Rafael Aquini
2012-08-03 12:26           ` Rafael Aquini
2012-08-03 12:26         ` Rafael Aquini
2012-07-18 22:46   ` Andrew Morton
2012-07-18 22:46     ` Andrew Morton
2012-07-18 22:46     ` Andrew Morton
2012-07-18 23:07     ` Rafael Aquini
2012-07-18 23:07     ` Rafael Aquini
2012-07-18 23:07       ` Rafael Aquini
2012-07-18 23:12       ` Andrew Morton
2012-07-18 23:12         ` Andrew Morton
2012-07-18 23:12         ` Andrew Morton
2012-07-19  1:00         ` Rafael Aquini
2012-07-19  1:00         ` Rafael Aquini
2012-07-19  1:00           ` Rafael Aquini
2012-07-19  1:29           ` Andrew Morton
2012-07-19  1:29           ` Andrew Morton
2012-07-19  1:29             ` Andrew Morton
2012-07-19 12:32             ` Rafael Aquini
2012-07-19 12:32               ` Rafael Aquini
2012-07-19 12:32               ` Rafael Aquini
2012-07-17 16:50 ` [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-07-17 16:50   ` Rafael Aquini
2012-07-18 22:49   ` Andrew Morton
2012-07-18 22:49     ` Andrew Morton
2012-07-18 22:49     ` Andrew Morton
2012-07-18 23:16     ` Rafael Aquini
2012-07-18 23:16     ` Rafael Aquini
2012-07-18 23:16       ` Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini
2012-07-17 16:50 ` [PATCH v4 3/3] mm: add vm event counters for balloon pages compaction Rafael Aquini
2012-07-17 16:50 ` Rafael Aquini
2012-07-17 16:50   ` Rafael Aquini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120803111309.GA1848@t510.redhat.com \
    --to=aquini@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=aquini@linux.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan@kernel.org \
    --cc=mst@redhat.com \
    --cc=riel@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.