From: Rafael Aquini <aquini@redhat.com> To: Minchan Kim <minchan@kernel.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell <rusty@rustcorp.com.au>, "Michael S. Tsirkin" <mst@redhat.com>, Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>, Andi Kleen <andi@firstfloor.org>, Andrew Morton <akpm@linux-foundation.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Rafael Aquini <aquini@linux.com> Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Date: Fri, 3 Aug 2012 09:26:57 -0300 [thread overview] Message-ID: <20120803122656.GB1848@t510.redhat.com> (raw) In-Reply-To: <20120723023332.GA6832@bbox> On Mon, Jul 23, 2012 at 11:33:32AM +0900, Minchan Kim wrote: > Look at memory-hotplug, offline_page calls has_unmovable_pages, scan_lru_pages > and do_migrate_range which calls isolate_lru_page. They consider only LRU pages > to migratable ones. > As promised, I looked into those bits. Yes, they only isolate LRU pages, and as such, having this series merged or not doesn't change a bit for that code path. In fact, having this series merged and teaching hotplug's offline_pages()/do_migrate_rage() about ballooned pages might be extremely beneficial in the rare event offlining memory stumbles across a balloon page. As Rik said, I believe this is something we can look into in the near future. > IMHO, better approach is that after we can get complete free pageblocks > by compaction or reclaim, move balloon pages into that pageblocks and make > that blocks to unmovable. It can prevent fragmentation and it makes > current or future code don't need to consider balloon page. > I totally agree with Rik on this one, as well. This is the wrong approach here. All that said, I'll soon respin a v5 based on your comments on branch hinting and commentary improvements, as well as addressing AKPM's concerns. I'll also revert isolate_balloon_page() last changes back to make it a public symbol again, as (I believe) we'll shortly be using it for letting hotplug bits aware of how to isolate ballooned pages.
WARNING: multiple messages have this Message-ID (diff)
From: Rafael Aquini <aquini@redhat.com> To: Minchan Kim <minchan@kernel.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell <rusty@rustcorp.com.au>, "Michael S. Tsirkin" <mst@redhat.com>, Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>, Andi Kleen <andi@firstfloor.org>, Andrew Morton <akpm@linux-foundation.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Rafael Aquini <aquini@linux.com> Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Date: Fri, 3 Aug 2012 09:26:57 -0300 [thread overview] Message-ID: <20120803122656.GB1848@t510.redhat.com> (raw) In-Reply-To: <20120723023332.GA6832@bbox> On Mon, Jul 23, 2012 at 11:33:32AM +0900, Minchan Kim wrote: > Look at memory-hotplug, offline_page calls has_unmovable_pages, scan_lru_pages > and do_migrate_range which calls isolate_lru_page. They consider only LRU pages > to migratable ones. > As promised, I looked into those bits. Yes, they only isolate LRU pages, and as such, having this series merged or not doesn't change a bit for that code path. In fact, having this series merged and teaching hotplug's offline_pages()/do_migrate_rage() about ballooned pages might be extremely beneficial in the rare event offlining memory stumbles across a balloon page. As Rik said, I believe this is something we can look into in the near future. > IMHO, better approach is that after we can get complete free pageblocks > by compaction or reclaim, move balloon pages into that pageblocks and make > that blocks to unmovable. It can prevent fragmentation and it makes > current or future code don't need to consider balloon page. > I totally agree with Rik on this one, as well. This is the wrong approach here. All that said, I'll soon respin a v5 based on your comments on branch hinting and commentary improvements, as well as addressing AKPM's concerns. I'll also revert isolate_balloon_page() last changes back to make it a public symbol again, as (I believe) we'll shortly be using it for letting hotplug bits aware of how to isolate ballooned pages. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-03 12:27 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-17 16:50 [PATCH v4 0/3] make balloon pages movable by compaction Rafael Aquini 2012-07-17 16:50 ` Rafael Aquini 2012-07-17 16:50 ` [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini 2012-07-17 16:50 ` Rafael Aquini 2012-07-17 16:50 ` Rafael Aquini 2012-07-18 5:48 ` Minchan Kim 2012-07-18 5:48 ` Minchan Kim 2012-07-18 5:48 ` Minchan Kim 2012-07-20 19:48 ` Rafael Aquini 2012-07-20 19:48 ` Rafael Aquini 2012-07-20 19:48 ` Rafael Aquini 2012-07-23 2:33 ` Minchan Kim 2012-07-23 2:33 ` Minchan Kim 2012-07-23 2:33 ` Minchan Kim 2012-07-23 2:35 ` Minchan Kim 2012-07-23 2:35 ` Minchan Kim 2012-07-23 2:35 ` Minchan Kim 2012-07-23 18:19 ` Rafael Aquini 2012-07-23 18:19 ` Rafael Aquini 2012-07-23 18:19 ` Rafael Aquini 2012-08-01 20:53 ` Rik van Riel 2012-08-01 20:53 ` Rik van Riel 2012-08-03 11:13 ` Rafael Aquini 2012-08-03 11:13 ` Rafael Aquini 2012-08-03 11:13 ` Rafael Aquini 2012-08-01 20:53 ` Rik van Riel 2012-08-01 20:51 ` Rik van Riel 2012-08-01 20:51 ` Rik van Riel 2012-08-01 20:51 ` Rik van Riel 2012-08-03 12:26 ` Rafael Aquini [this message] 2012-08-03 12:26 ` Rafael Aquini 2012-08-03 12:26 ` Rafael Aquini 2012-07-18 22:46 ` Andrew Morton 2012-07-18 22:46 ` Andrew Morton 2012-07-18 22:46 ` Andrew Morton 2012-07-18 23:07 ` Rafael Aquini 2012-07-18 23:07 ` Rafael Aquini 2012-07-18 23:07 ` Rafael Aquini 2012-07-18 23:12 ` Andrew Morton 2012-07-18 23:12 ` Andrew Morton 2012-07-18 23:12 ` Andrew Morton 2012-07-19 1:00 ` Rafael Aquini 2012-07-19 1:00 ` Rafael Aquini 2012-07-19 1:00 ` Rafael Aquini 2012-07-19 1:29 ` Andrew Morton 2012-07-19 1:29 ` Andrew Morton 2012-07-19 1:29 ` Andrew Morton 2012-07-19 12:32 ` Rafael Aquini 2012-07-19 12:32 ` Rafael Aquini 2012-07-19 12:32 ` Rafael Aquini 2012-07-17 16:50 ` [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini 2012-07-17 16:50 ` Rafael Aquini 2012-07-18 22:49 ` Andrew Morton 2012-07-18 22:49 ` Andrew Morton 2012-07-18 22:49 ` Andrew Morton 2012-07-18 23:16 ` Rafael Aquini 2012-07-18 23:16 ` Rafael Aquini 2012-07-18 23:16 ` Rafael Aquini 2012-07-17 16:50 ` Rafael Aquini 2012-07-17 16:50 ` [PATCH v4 3/3] mm: add vm event counters for balloon pages compaction Rafael Aquini 2012-07-17 16:50 ` Rafael Aquini 2012-07-17 16:50 ` Rafael Aquini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120803122656.GB1848@t510.redhat.com \ --to=aquini@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=andi@firstfloor.org \ --cc=aquini@linux.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mel@csn.ul.ie \ --cc=minchan@kernel.org \ --cc=mst@redhat.com \ --cc=riel@redhat.com \ --cc=rusty@rustcorp.com.au \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.