* [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable
@ 2021-02-27 14:49 Richard Purdie
2021-02-27 15:45 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Richard Purdie @ 2021-02-27 14:49 UTC (permalink / raw)
To: igt-dev
Hardcoding a build source path into a binary when cross compiling isn't
appropriate and breaks build reproducibility. Allow the srcdir to be
specified by an optional configuration option to meson.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/meson.build | 6 +++++-
meson_options.txt | 4 ++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/meson.build b/lib/meson.build
index 114eadde..672b4206 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -125,7 +125,11 @@ if chamelium.found()
lib_sources += 'igt_chamelium_stream.c'
endif
-srcdir = join_paths(meson.source_root(), 'tests')
+if get_option('srcdir') != ''
+ srcdir = join_paths(get_option('srcdir'), 'tests')
+else
+ srcdir = join_paths(meson.source_root(), 'tests')
+endif
lib_version = vcs_tag(input : 'version.h.in', output : 'version.h',
fallback : 'NO-GIT',
diff --git a/meson_options.txt b/meson_options.txt
index ff3abf08..a0a1aaed 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -50,3 +50,7 @@ option('use_rpath',
type : 'boolean',
value : false,
description : 'Set runpath on installed executables for libigt.so')
+
+option('srcdir',
+ type : 'string',
+ description : 'Path to source code to be compiled into binaries (optional)')
--
2.27.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for meson: Allow source location to be configurable 2021-02-27 14:49 [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable Richard Purdie @ 2021-02-27 15:45 ` Patchwork 2021-02-27 17:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2021-02-28 10:06 ` [igt-dev] [PATCH i-g-t] " Martin Peres 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2021-02-27 15:45 UTC (permalink / raw) To: Richard Purdie; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 2781 bytes --] == Series Details == Series: meson: Allow source location to be configurable URL : https://patchwork.freedesktop.org/series/87456/ State : success == Summary == CI Bug Log - changes from CI_DRM_9815 -> IGTPW_5555 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/index.html Known issues ------------ Here are the changes found in IGTPW_5555 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@prime_self_import@basic-with_one_bo: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-y: [DMESG-WARN][3] ([i915#2411] / [i915#402]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html * igt@gem_tiled_blits@basic: - fi-kbl-8809g: [TIMEOUT][5] ([i915#2502]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/fi-kbl-8809g/igt@gem_tiled_blits@basic.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/fi-kbl-8809g/igt@gem_tiled_blits@basic.html * igt@prime_self_import@basic-with_one_bo_two_files: - fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (41 -> 36) ------------------------------ Missing (5): fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6015 -> IGTPW_5555 CI-20190529: 20190529 CI_DRM_9815: b80182b9bffb51460e4a2ad7d96737ecd49126dc @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5555: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/index.html IGT_6015: aa44cddf4ef689f8a3726fcbeedc03f08b12bd82 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/index.html [-- Attachment #1.2: Type: text/html, Size: 3590 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for meson: Allow source location to be configurable 2021-02-27 14:49 [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable Richard Purdie 2021-02-27 15:45 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-02-27 17:26 ` Patchwork 2021-02-28 10:06 ` [igt-dev] [PATCH i-g-t] " Martin Peres 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2021-02-27 17:26 UTC (permalink / raw) To: Richard Purdie; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 30265 bytes --] == Series Details == Series: meson: Allow source location to be configurable URL : https://patchwork.freedesktop.org/series/87456/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9815_full -> IGTPW_5555_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_5555_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_5555_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_5555_full: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live@blt: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-tglb7/igt@i915_selftest@live@blt.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb6/igt@i915_selftest@live@blt.html Known issues ------------ Here are the changes found in IGTPW_5555_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@psr2: - shard-iclb: NOTRUN -> [SKIP][3] ([i915#658]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb1/igt@feature_discovery@psr2.html * igt@gem_ctx_isolation@preservation-s3@vcs0: - shard-kbl: [PASS][4] -> [DMESG-WARN][5] ([i915#180]) +3 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html * igt@gem_ctx_param@set-priority-not-supported: - shard-tglb: NOTRUN -> [SKIP][6] ([fdo#109314]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb2/igt@gem_ctx_param@set-priority-not-supported.html - shard-iclb: NOTRUN -> [SKIP][7] ([fdo#109314]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb8/igt@gem_ctx_param@set-priority-not-supported.html * igt@gem_ctx_persistence@hostile: - shard-hsw: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099]) +1 similar issue [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw8/igt@gem_ctx_persistence@hostile.html * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099]) +5 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-snb6/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_eio@in-flight-suspend: - shard-apl: [PASS][10] -> [DMESG-WARN][11] ([i915#180]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-apl8/igt@gem_eio@in-flight-suspend.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl7/igt@gem_eio@in-flight-suspend.html * igt@gem_eio@unwedge-stress: - shard-iclb: [PASS][12] -> [TIMEOUT][13] ([i915#2481] / [i915#3070]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-iclb6/igt@gem_eio@unwedge-stress.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb1/igt@gem_eio@unwedge-stress.html * igt@gem_exec_balancer@hang: - shard-iclb: [PASS][14] -> [INCOMPLETE][15] ([i915#1895] / [i915#3031]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-iclb6/igt@gem_exec_balancer@hang.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb1/igt@gem_exec_balancer@hang.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [PASS][16] -> [FAIL][17] ([i915#2842]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none@vcs1: - shard-kbl: [PASS][18] -> [FAIL][19] ([i915#2842]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-kbl1/igt@gem_exec_fair@basic-none@vcs1.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl3/igt@gem_exec_fair@basic-none@vcs1.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][20] -> [FAIL][21] ([i915#2842]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][22] ([i915#2842]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html - shard-kbl: NOTRUN -> [FAIL][23] ([i915#2842]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][24] -> [FAIL][25] ([i915#2842]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_params@no-blt: - shard-tglb: NOTRUN -> [SKIP][26] ([fdo#109283]) +1 similar issue [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb2/igt@gem_exec_params@no-blt.html * igt@gem_exec_params@no-vebox: - shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109283]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb1/igt@gem_exec_params@no-vebox.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-snb: NOTRUN -> [FAIL][28] ([i915#2389]) +2 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-snb6/igt@gem_exec_reloc@basic-wide-active@rcs0.html * igt@gem_exec_reloc@basic-wide-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][29] ([i915#2389]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb4/igt@gem_exec_reloc@basic-wide-active@vcs1.html * igt@gem_exec_schedule@u-fairslice-all: - shard-glk: [PASS][30] -> [DMESG-WARN][31] ([i915#1610] / [i915#2803]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-glk3/igt@gem_exec_schedule@u-fairslice-all.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk7/igt@gem_exec_schedule@u-fairslice-all.html * igt@gem_exec_schedule@u-fairslice@rcs0: - shard-glk: [PASS][32] -> [DMESG-WARN][33] ([i915#2803]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-glk6/igt@gem_exec_schedule@u-fairslice@rcs0.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk9/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-glk: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#2190]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk4/igt@gem_huc_copy@huc-copy.html - shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#2190]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl4/igt@gem_huc_copy@huc-copy.html * igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled: - shard-iclb: NOTRUN -> [SKIP][36] ([i915#768]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb8/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled.html * igt@gem_userptr_blits@input-checking: - shard-apl: NOTRUN -> [DMESG-WARN][37] ([i915#3002]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl1/igt@gem_userptr_blits@input-checking.html - shard-snb: NOTRUN -> [DMESG-WARN][38] ([i915#3002]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-snb6/igt@gem_userptr_blits@input-checking.html * igt@gem_userptr_blits@process-exit-mmap-busy@uc: - shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#1699]) +3 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl4/igt@gem_userptr_blits@process-exit-mmap-busy@uc.html * igt@gem_userptr_blits@process-exit-mmap-busy@wc: - shard-glk: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#1699]) +3 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk3/igt@gem_userptr_blits@process-exit-mmap-busy@wc.html * igt@gem_userptr_blits@process-exit-mmap@wb: - shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#1699]) +7 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl6/igt@gem_userptr_blits@process-exit-mmap@wb.html * igt@gem_userptr_blits@vma-merge: - shard-kbl: NOTRUN -> [INCOMPLETE][42] ([i915#2502] / [i915#2667]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl2/igt@gem_userptr_blits@vma-merge.html * igt@gen3_render_tiledx_blits: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109289]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb7/igt@gen3_render_tiledx_blits.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [PASS][44] -> [DMESG-WARN][45] ([i915#1436] / [i915#716]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-glk1/igt@gen9_exec_parse@allowed-all.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk7/igt@gen9_exec_parse@allowed-all.html * igt@gen9_exec_parse@batch-invalid-length: - shard-snb: NOTRUN -> [SKIP][46] ([fdo#109271]) +340 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-snb7/igt@gen9_exec_parse@batch-invalid-length.html * igt@gen9_exec_parse@bb-start-param: - shard-tglb: NOTRUN -> [SKIP][47] ([fdo#112306]) +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb1/igt@gen9_exec_parse@bb-start-param.html * igt@gen9_exec_parse@shadow-peek: - shard-tglb: NOTRUN -> [SKIP][48] ([i915#2856]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb5/igt@gen9_exec_parse@shadow-peek.html * igt@gen9_exec_parse@valid-registers: - shard-iclb: NOTRUN -> [SKIP][49] ([fdo#112306]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb2/igt@gen9_exec_parse@valid-registers.html * igt@i915_pm_backlight@bad-brightness: - shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271]) +70 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk9/igt@i915_pm_backlight@bad-brightness.html * igt@i915_pm_backlight@fade_with_dpms: - shard-hsw: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#3012]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw1/igt@i915_pm_backlight@fade_with_dpms.html * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109293] / [fdo#109506]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb6/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait: - shard-tglb: NOTRUN -> [SKIP][53] ([fdo#111644] / [i915#1397] / [i915#2411]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html - shard-iclb: NOTRUN -> [SKIP][54] ([fdo#110892]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb8/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: NOTRUN -> [DMESG-WARN][55] ([i915#180]) +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy: - shard-hsw: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#109289]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-iclb: NOTRUN -> [SKIP][57] ([i915#1769]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb2/igt@kms_atomic_transition@plane-all-modeset-transition.html - shard-tglb: NOTRUN -> [SKIP][58] ([i915#1769]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb6/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_big_fb@linear-64bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][59] ([fdo#110725] / [fdo#111614]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb4/igt@kms_big_fb@linear-64bpp-rotate-90.html - shard-tglb: NOTRUN -> [SKIP][60] ([fdo#111614]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb6/igt@kms_big_fb@linear-64bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][61] ([fdo#111615]) +3 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb1/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html * igt@kms_ccs@pipe-d-ccs-on-another-bo: - shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109278]) +13 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb6/igt@kms_ccs@pipe-d-ccs-on-another-bo.html * igt@kms_chamelium@hdmi-crc-nonplanar-formats: - shard-hsw: NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +8 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw1/igt@kms_chamelium@hdmi-crc-nonplanar-formats.html * igt@kms_chamelium@vga-hpd-with-enabled-mode: - shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109284] / [fdo#111827]) +4 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb6/igt@kms_chamelium@vga-hpd-with-enabled-mode.html * igt@kms_color@pipe-d-legacy-gamma: - shard-hsw: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#533]) +6 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw1/igt@kms_color@pipe-d-legacy-gamma.html * igt@kms_color_chamelium@pipe-a-ctm-0-75: - shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +23 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl6/igt@kms_color_chamelium@pipe-a-ctm-0-75.html * igt@kms_color_chamelium@pipe-a-ctm-limited-range: - shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [fdo#111827]) +18 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl3/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html * igt@kms_color_chamelium@pipe-a-ctm-negative: - shard-snb: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +16 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-snb5/igt@kms_color_chamelium@pipe-a-ctm-negative.html * igt@kms_color_chamelium@pipe-b-ctm-0-75: - shard-tglb: NOTRUN -> [SKIP][69] ([fdo#109284] / [fdo#111827]) +6 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb2/igt@kms_color_chamelium@pipe-b-ctm-0-75.html * igt@kms_color_chamelium@pipe-b-ctm-limited-range: - shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [fdo#111827]) +8 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk3/igt@kms_color_chamelium@pipe-b-ctm-limited-range.html * igt@kms_color_chamelium@pipe-d-ctm-blue-to-red: - shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109278] / [fdo#109284] / [fdo#111827]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb6/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html * igt@kms_content_protection@dp-mst-type-1: - shard-iclb: NOTRUN -> [SKIP][72] ([i915#3116]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb8/igt@kms_content_protection@dp-mst-type-1.html - shard-tglb: NOTRUN -> [SKIP][73] ([i915#3116]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb3/igt@kms_content_protection@dp-mst-type-1.html * igt@kms_content_protection@type1: - shard-tglb: NOTRUN -> [SKIP][74] ([fdo#111828]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb6/igt@kms_content_protection@type1.html * igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen: - shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109278] / [fdo#109279]) +3 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb4/igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen.html * igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding: - shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109279]) +2 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding.html * igt@kms_cursor_crc@pipe-d-cursor-suspend: - shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271]) +176 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl6/igt@kms_cursor_crc@pipe-d-cursor-suspend.html * igt@kms_cursor_legacy@cursora-vs-flipb-varying-size: - shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109274] / [fdo#109278]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb5/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-tglb: NOTRUN -> [FAIL][79] ([i915#2346]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible: - shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109274]) +2 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb3/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-tglb: [PASS][81] -> [FAIL][82] ([i915#2598]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-kbl: NOTRUN -> [DMESG-WARN][83] ([i915#180]) +4 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile: - shard-tglb: NOTRUN -> [SKIP][84] ([i915#2587]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb1/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html - shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2642]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html - shard-glk: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2642]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk9/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html - shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2642]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile: - shard-apl: NOTRUN -> [FAIL][88] ([i915#2641]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html * igt@kms_force_connector_basic@force-load-detect: - shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109285]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb4/igt@kms_force_connector_basic@force-load-detect.html - shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109285]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb6/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt: - shard-glk: NOTRUN -> [FAIL][91] ([i915#49]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-render: - shard-tglb: NOTRUN -> [SKIP][92] ([fdo#111825]) +18 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109280]) +17 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d: - shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#533]) +1 similar issue [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl2/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence: - shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#533]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl4/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-apl: NOTRUN -> [FAIL][96] ([fdo#108145] / [i915#265]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html - shard-glk: NOTRUN -> [FAIL][97] ([fdo#108145] / [i915#265]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk9/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-b-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][98] ([fdo#108145] / [i915#265]) +2 similar issues [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][99] ([i915#265]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_plane_lowres@pipe-b-tiling-yf: - shard-hsw: NOTRUN -> [SKIP][100] ([fdo#109271]) +93 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw8/igt@kms_plane_lowres@pipe-b-tiling-yf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-glk: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_su@page_flip: - shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#658]) +3 similar issues [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl3/igt@kms_psr2_su@page_flip.html - shard-kbl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#658]) +1 similar issue [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl6/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109441]) +1 similar issue [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][105] -> [SKIP][106] ([fdo#109441]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-iclb2/igt@kms_psr@psr2_suspend.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb1/igt@kms_psr@psr2_suspend.html * igt@kms_psr@sprite_blt: - shard-hsw: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#1072]) +6 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw1/igt@kms_psr@sprite_blt.html * igt@kms_setmode@basic: - shard-snb: NOTRUN -> [FAIL][108] ([i915#31]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-snb2/igt@kms_setmode@basic.html * igt@kms_sysfs_edid_timing: - shard-kbl: NOTRUN -> [FAIL][109] ([IGT#2]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl4/igt@kms_sysfs_edid_timing.html * igt@kms_vrr@flip-dpms: - shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109502]) +1 similar issue [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb2/igt@kms_vrr@flip-dpms.html - shard-tglb: NOTRUN -> [SKIP][111] ([fdo#109502]) +1 similar issue [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb3/igt@kms_vrr@flip-dpms.html * igt@kms_writeback@writeback-pixel-formats: - shard-glk: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2437]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk4/igt@kms_writeback@writeback-pixel-formats.html - shard-iclb: NOTRUN -> [SKIP][113] ([i915#2437]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb4/igt@kms_writeback@writeback-pixel-formats.html - shard-apl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2437]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl8/igt@kms_writeback@writeback-pixel-formats.html - shard-tglb: NOTRUN -> [SKIP][115] ([i915#2437]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb6/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame: - shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271]) +177 similar issues [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-apl7/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html - shard-tglb: NOTRUN -> [SKIP][117] ([i915#2530]) +1 similar issue [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb1/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html * igt@nouveau_crc@pipe-b-source-outp-complete: - shard-iclb: NOTRUN -> [SKIP][118] ([i915#2530]) +1 similar issue [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb1/igt@nouveau_crc@pipe-b-source-outp-complete.html * igt@prime_nv_pcopy@test3_4: - shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109291]) +1 similar issue [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb1/igt@prime_nv_pcopy@test3_4.html - shard-tglb: NOTRUN -> [SKIP][120] ([fdo#109291]) +1 similar issue [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb5/igt@prime_nv_pcopy@test3_4.html * igt@prime_vgem@fence-read-hang: - shard-tglb: NOTRUN -> [SKIP][121] ([fdo#109295]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb7/igt@prime_vgem@fence-read-hang.html * igt@sysfs_clients@busy@vcs0: - shard-kbl: [PASS][122] -> [FAIL][123] ([i915#3019]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-kbl4/igt@sysfs_clients@busy@vcs0.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl4/igt@sysfs_clients@busy@vcs0.html * igt@sysfs_clients@recycle: - shard-hsw: [PASS][124] -> [FAIL][125] ([i915#3028]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-hsw1/igt@sysfs_clients@recycle.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw8/igt@sysfs_clients@recycle.html - shard-kbl: NOTRUN -> [FAIL][126] ([i915#3028]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl2/igt@sysfs_clients@recycle.html #### Possible fixes #### * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [FAIL][127] ([i915#2842]) -> [PASS][128] [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-glk: [FAIL][129] ([i915#2842]) -> [PASS][130] +1 similar issue [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-glk5/igt@gem_exec_fair@basic-pace@vecs0.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-glk4/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gem_exec_schedule@u-fairslice@rcs0: - shard-iclb: [DMESG-WARN][131] ([i915#2803]) -> [PASS][132] [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-iclb6/igt@gem_exec_schedule@u-fairslice@rcs0.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-iclb5/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@gem_exec_suspend@basic-s3: - shard-kbl: [DMESG-WARN][133] ([i915#180]) -> [PASS][134] +2 similar issues [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-kbl1/igt@gem_exec_suspend@basic-s3.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-kbl2/igt@gem_exec_suspend@basic-s3.html * igt@i915_module_load@reload-with-fault-injection: - shard-hsw: [INCOMPLETE][135] ([i915#2880]) -> [PASS][136] [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9815/shard-hsw8/igt@i915_module_load@reload-with-fault-injection.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/shard-hsw8/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_rc6_residency@rc6-idle: == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5555/index.html [-- Attachment #1.2: Type: text/html, Size: 33933 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable 2021-02-27 14:49 [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable Richard Purdie 2021-02-27 15:45 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2021-02-27 17:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork @ 2021-02-28 10:06 ` Martin Peres 2021-02-28 12:29 ` Richard Purdie 2 siblings, 1 reply; 7+ messages in thread From: Martin Peres @ 2021-02-28 10:06 UTC (permalink / raw) To: Richard Purdie, igt-dev On 27/02/2021 16:49, Richard Purdie wrote: > Hardcoding a build source path into a binary when cross compiling isn't > appropriate and breaks build reproducibility. Allow the srcdir to be > specified by an optional configuration option to meson. > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > lib/meson.build | 6 +++++- > meson_options.txt | 4 ++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/lib/meson.build b/lib/meson.build > index 114eadde..672b4206 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -125,7 +125,11 @@ if chamelium.found() > lib_sources += 'igt_chamelium_stream.c' > endif > > -srcdir = join_paths(meson.source_root(), 'tests') > +if get_option('srcdir') != '' > + srcdir = join_paths(get_option('srcdir'), 'tests') > +else > + srcdir = join_paths(meson.source_root(), 'tests') > +endif > > lib_version = vcs_tag(input : 'version.h.in', output : 'version.h', > fallback : 'NO-GIT', > diff --git a/meson_options.txt b/meson_options.txt > index ff3abf08..a0a1aaed 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -50,3 +50,7 @@ option('use_rpath', > type : 'boolean', > value : false, > description : 'Set runpath on installed executables for libigt.so') > + > +option('srcdir', > + type : 'string', > + description : 'Path to source code to be compiled into binaries (optional)') Shouldn't this read: "Path to THE source code to be compiled (optional)"? Compiling into binaries is a little redundant, so I would drop it. Other than this, the rationale seems sane, but I am not knowledgeable-enough about IGT's build system to comment more on it: Acked-by: Martin Peres <martin.peres@mupuf.org> > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable 2021-02-28 10:06 ` [igt-dev] [PATCH i-g-t] " Martin Peres @ 2021-02-28 12:29 ` Richard Purdie 2021-03-01 6:43 ` Martin Peres 0 siblings, 1 reply; 7+ messages in thread From: Richard Purdie @ 2021-02-28 12:29 UTC (permalink / raw) To: Martin Peres, igt-dev On Sun, 2021-02-28 at 12:06 +0200, Martin Peres wrote: > On 27/02/2021 16:49, Richard Purdie wrote: > > > > lib_version = vcs_tag(input : 'version.h.in', output : 'version.h', > > fallback : 'NO-GIT', > > diff --git a/meson_options.txt b/meson_options.txt > > index ff3abf08..a0a1aaed 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -50,3 +50,7 @@ option('use_rpath', > > type : 'boolean', > > value : false, > > description : 'Set runpath on installed executables for libigt.so') > > + > > +option('srcdir', > > + type : 'string', > > + description : 'Path to source code to be compiled into binaries (optional)') > > Shouldn't this read: "Path to THE source code to be compiled > (optional)"? Compiling into binaries is a little redundant, so I would > drop it. I'm not sure that does quite mean the same thing. The option is talking about a path which gets compiled inside the binary rather than a path to code which is compiled. Regardless, it clearly needs to be more clear! :) How about "Source code path in the target environment for use within target binaries (optional)"? Cheers, Richard > Other than this, the rationale seems sane, but I am not > knowledgeable-enough about IGT's build system to comment more on it: > > Acked-by: Martin Peres <martin.peres@mupuf.org> > > > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable 2021-02-28 12:29 ` Richard Purdie @ 2021-03-01 6:43 ` Martin Peres 2021-03-01 7:30 ` Petri Latvala 0 siblings, 1 reply; 7+ messages in thread From: Martin Peres @ 2021-03-01 6:43 UTC (permalink / raw) To: Richard Purdie, igt-dev Hi Richard, On 28/02/2021 14:29, Richard Purdie wrote: > On Sun, 2021-02-28 at 12:06 +0200, Martin Peres wrote: >> On 27/02/2021 16:49, Richard Purdie wrote: >>> >>> lib_version = vcs_tag(input : 'version.h.in', output : 'version.h', >>> fallback : 'NO-GIT', >>> diff --git a/meson_options.txt b/meson_options.txt >>> index ff3abf08..a0a1aaed 100644 >>> --- a/meson_options.txt >>> +++ b/meson_options.txt >>> @@ -50,3 +50,7 @@ option('use_rpath', >>> type : 'boolean', >>> value : false, >>> description : 'Set runpath on installed executables for libigt.so') >>> + >>> +option('srcdir', >>> + type : 'string', >>> + description : 'Path to source code to be compiled into binaries (optional)') >> >> Shouldn't this read: "Path to THE source code to be compiled >> (optional)"? Compiling into binaries is a little redundant, so I would >> drop it. > > I'm not sure that does quite mean the same thing. The option is talking > about a path which gets compiled inside the binary rather than a path to code > which is compiled. > > Regardless, it clearly needs to be more clear! :) > > How about "Source code path in the target environment for use within target > binaries (optional)"? Ah ah! Yeah, that was not how I understood it, and your new help text is definitely making sense :) Please send a v2 with this done, after you get an actual review :) Cheers, Martin > > Cheers, > > Richard > >> Other than this, the rationale seems sane, but I am not >> knowledgeable-enough about IGT's build system to comment more on it: >> >> Acked-by: Martin Peres <martin.peres@mupuf.org> >> >>> >> > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable 2021-03-01 6:43 ` Martin Peres @ 2021-03-01 7:30 ` Petri Latvala 0 siblings, 0 replies; 7+ messages in thread From: Petri Latvala @ 2021-03-01 7:30 UTC (permalink / raw) To: Martin Peres; +Cc: igt-dev On Mon, Mar 01, 2021 at 08:43:12AM +0200, Martin Peres wrote: > Hi Richard, > > On 28/02/2021 14:29, Richard Purdie wrote: > > On Sun, 2021-02-28 at 12:06 +0200, Martin Peres wrote: > > > On 27/02/2021 16:49, Richard Purdie wrote: > > > > > > > > lib_version = vcs_tag(input : 'version.h.in', output : 'version.h', > > > > fallback : 'NO-GIT', > > > > diff --git a/meson_options.txt b/meson_options.txt > > > > index ff3abf08..a0a1aaed 100644 > > > > --- a/meson_options.txt > > > > +++ b/meson_options.txt > > > > @@ -50,3 +50,7 @@ option('use_rpath', > > > > type : 'boolean', > > > > value : false, > > > > description : 'Set runpath on installed executables for libigt.so') > > > > + > > > > +option('srcdir', > > > > + type : 'string', > > > > + description : 'Path to source code to be compiled into binaries (optional)') > > > > > > Shouldn't this read: "Path to THE source code to be compiled > > > (optional)"? Compiling into binaries is a little redundant, so I would > > > drop it. > > > > I'm not sure that does quite mean the same thing. The option is talking > > about a path which gets compiled inside the binary rather than a path to code > > which is compiled. > > > > Regardless, it clearly needs to be more clear! :) > > > > How about "Source code path in the target environment for use within target > > binaries (optional)"? > > Ah ah! Yeah, that was not how I understood it, and your new help text is > definitely making sense :) > > Please send a v2 with this done, after you get an actual review :) Somehow slip in the word "override" in the description, or add some kind of other mention that by default it's automatic. Otherwise LGTM and the reasoning makes sense. For the record, the embedded path is used by igt_fopen_data(), only used by one (!) test currently to open an image file... Reviewed-by: Petri Latvala <petri.latvala@intel.com> > > Cheers, > Martin > > > > > Cheers, > > > > Richard > > > > > Other than this, the rationale seems sane, but I am not > > > knowledgeable-enough about IGT's build system to comment more on it: > > > > > > Acked-by: Martin Peres <martin.peres@mupuf.org> > > > > > > > > > > > > > > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-01 7:29 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-27 14:49 [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable Richard Purdie 2021-02-27 15:45 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2021-02-27 17:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2021-02-28 10:06 ` [igt-dev] [PATCH i-g-t] " Martin Peres 2021-02-28 12:29 ` Richard Purdie 2021-03-01 6:43 ` Martin Peres 2021-03-01 7:30 ` Petri Latvala
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.