From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] drm/msm/a5xx: Enable optional icc voting from OPP tables Date: Thu, 23 Feb 2023 00:12:53 +0200 [thread overview] Message-ID: <4b9145e0-0526-dd08-2d92-05a49e50e3bc@linaro.org> (raw) In-Reply-To: <20230222-konrad-longbois-next-v1-5-01021425781b@linaro.org> On 22/02/2023 23:47, Konrad Dybcio wrote: > Add the dev_pm_opp_of_find_icc_paths() call to let the OPP framework > handle bus voting as part of power level setting. This can probably go to the generic code path rather than sticking it into a5xx only. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > index d09221f97f71..a33af0cc27b6 100644 > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > @@ -1775,5 +1775,9 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev) > /* Set up the preemption specific bits and pieces for each ringbuffer */ > a5xx_preempt_init(gpu); > > + ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL); > + if (ret) > + return ERR_PTR(ret); > + > return gpu; > } > -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 5/5] drm/msm/a5xx: Enable optional icc voting from OPP tables Date: Thu, 23 Feb 2023 00:12:53 +0200 [thread overview] Message-ID: <4b9145e0-0526-dd08-2d92-05a49e50e3bc@linaro.org> (raw) In-Reply-To: <20230222-konrad-longbois-next-v1-5-01021425781b@linaro.org> On 22/02/2023 23:47, Konrad Dybcio wrote: > Add the dev_pm_opp_of_find_icc_paths() call to let the OPP framework > handle bus voting as part of power level setting. This can probably go to the generic code path rather than sticking it into a5xx only. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > index d09221f97f71..a33af0cc27b6 100644 > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > @@ -1775,5 +1775,9 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev) > /* Set up the preemption specific bits and pieces for each ringbuffer */ > a5xx_preempt_init(gpu); > > + ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL); > + if (ret) > + return ERR_PTR(ret); > + > return gpu; > } > -- With best wishes Dmitry
next prev parent reply other threads:[~2023-02-22 22:13 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-22 21:47 [PATCH 0/5] OPP and devfreq for all Adrenos Konrad Dybcio 2023-02-22 21:47 ` Konrad Dybcio 2023-02-22 21:47 ` [PATCH 1/5] drm/msm/adreno: Use OPP for every GPU generation Konrad Dybcio 2023-02-22 21:47 ` Konrad Dybcio 2023-02-22 22:38 ` Dmitry Baryshkov 2023-02-22 22:38 ` Dmitry Baryshkov 2023-02-22 22:40 ` Konrad Dybcio 2023-02-22 22:40 ` Konrad Dybcio 2023-02-22 23:16 ` Dmitry Baryshkov 2023-02-22 23:16 ` Dmitry Baryshkov 2023-02-23 1:02 ` Konrad Dybcio 2023-02-23 1:02 ` Konrad Dybcio 2023-02-22 21:47 ` [PATCH 2/5] drm/msm/a2xx: Implement .gpu_busy Konrad Dybcio 2023-02-22 21:47 ` Konrad Dybcio 2023-02-22 22:24 ` Dmitry Baryshkov 2023-02-22 22:24 ` Dmitry Baryshkov 2023-02-22 21:47 ` [PATCH 3/5] drm/msm/a3xx: " Konrad Dybcio 2023-02-22 21:47 ` Konrad Dybcio 2023-02-22 22:10 ` Dmitry Baryshkov 2023-02-22 22:10 ` Dmitry Baryshkov 2023-02-22 21:47 ` [PATCH 4/5] drm/msm/a4xx: " Konrad Dybcio 2023-02-22 21:47 ` Konrad Dybcio 2023-02-22 22:22 ` Dmitry Baryshkov 2023-02-22 22:22 ` Dmitry Baryshkov 2023-02-22 21:47 ` [PATCH 5/5] drm/msm/a5xx: Enable optional icc voting from OPP tables Konrad Dybcio 2023-02-22 21:47 ` Konrad Dybcio 2023-02-22 22:12 ` Dmitry Baryshkov [this message] 2023-02-22 22:12 ` Dmitry Baryshkov 2023-02-22 22:14 ` Konrad Dybcio 2023-02-22 22:14 ` Konrad Dybcio 2023-02-22 22:22 ` Dmitry Baryshkov 2023-02-22 22:22 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4b9145e0-0526-dd08-2d92-05a49e50e3bc@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@gmail.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.