* [thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load
@ 2019-09-03 20:20 Denys Dmytriyenko
2019-09-03 21:22 ` [EXTERNAL] " Jacob Stiffler
0 siblings, 1 reply; 3+ messages in thread
From: Denys Dmytriyenko @ 2019-09-03 20:20 UTC (permalink / raw)
To: meta-arago
Since Arago still has a mix of SysVinit iniscripts and systemd unit files, it
enables both of the DISTRO_FEATURES, resulting in some duplication. It appears
that rngd currently has a problem handling signals when forked in daemon mode.
Hence, drop SysVinit initscript in favor of systemd service, as the latter one
starts rngd in foreground. Also, add udev dependency rule on omap_rng module.
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
.../recipes-support/rng-tools/rng-tools/rngd.rules | 1 +
.../recipes-support/rng-tools/rng-tools_%.bbappend | 13 +++++++++++++
2 files changed, 14 insertions(+)
create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
new file mode 100644
index 0000000..a21c99b
--- /dev/null
+++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
@@ -0,0 +1 @@
+ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
new file mode 100644
index 0000000..df84536
--- /dev/null
+++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
@@ -0,0 +1,13 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+PR_append = ".arago0"
+
+SRC_URI += "file://rngd.rules"
+
+do_install_append() {
+ # remove duplicate initscript
+ rm -f ${D}${sysconfdir}/init.d/rng-tools
+
+ install -d ${D}${sysconfdir}/udev/rules.d/
+ install -m0644 ${WORKDIR}/rngd.rules ${D}${sysconfdir}/udev/rules.d/
+}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [EXTERNAL] [thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load
2019-09-03 20:20 [thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load Denys Dmytriyenko
@ 2019-09-03 21:22 ` Jacob Stiffler
2019-09-04 12:57 ` Jacob Stiffler
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Stiffler @ 2019-09-03 21:22 UTC (permalink / raw)
To: Denys Dmytriyenko, meta-arago
I manually made these changes to an existing filesystem, rebooted a few
times, and observed the service status. The service was up every time
and there was no delay in the service terminating when rebooting.
Tested-by: Jacob Stiffler <j-stiffler@ti.com>
On 9/3/2019 4:20 PM, Denys Dmytriyenko wrote:
> Since Arago still has a mix of SysVinit iniscripts and systemd unit files, it
> enables both of the DISTRO_FEATURES, resulting in some duplication. It appears
> that rngd currently has a problem handling signals when forked in daemon mode.
> Hence, drop SysVinit initscript in favor of systemd service, as the latter one
> starts rngd in foreground. Also, add udev dependency rule on omap_rng module.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> .../recipes-support/rng-tools/rng-tools/rngd.rules | 1 +
> .../recipes-support/rng-tools/rng-tools_%.bbappend | 13 +++++++++++++
> 2 files changed, 14 insertions(+)
> create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> new file mode 100644
> index 0000000..a21c99b
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> @@ -0,0 +1 @@
> +ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> new file mode 100644
> index 0000000..df84536
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> @@ -0,0 +1,13 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +PR_append = ".arago0"
> +
> +SRC_URI += "file://rngd.rules"
> +
> +do_install_append() {
> + # remove duplicate initscript
> + rm -f ${D}${sysconfdir}/init.d/rng-tools
> +
> + install -d ${D}${sysconfdir}/udev/rules.d/
> + install -m0644 ${WORKDIR}/rngd.rules ${D}${sysconfdir}/udev/rules.d/
> +}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [EXTERNAL] [thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load
2019-09-03 21:22 ` [EXTERNAL] " Jacob Stiffler
@ 2019-09-04 12:57 ` Jacob Stiffler
0 siblings, 0 replies; 3+ messages in thread
From: Jacob Stiffler @ 2019-09-04 12:57 UTC (permalink / raw)
To: Denys Dmytriyenko, meta-arago
I now tested this in a build. It fails when creating the rootfs. The
update-rc.d pre/post inst is still defined in the package, so package
configuration fails because the initscript is not found.
This can be resolved by setting INHIBIT_UPDATERCD_BBCLASS in the
rng-tools bbappend.
- Jake
On 9/3/2019 5:22 PM, Jacob Stiffler wrote:
> I manually made these changes to an existing filesystem, rebooted a
> few times, and observed the service status. The service was up every
> time and there was no delay in the service terminating when rebooting.
>
> Tested-by: Jacob Stiffler <j-stiffler@ti.com>
>
> On 9/3/2019 4:20 PM, Denys Dmytriyenko wrote:
>> Since Arago still has a mix of SysVinit iniscripts and systemd unit
>> files, it
>> enables both of the DISTRO_FEATURES, resulting in some duplication.
>> It appears
>> that rngd currently has a problem handling signals when forked in
>> daemon mode.
>> Hence, drop SysVinit initscript in favor of systemd service, as the
>> latter one
>> starts rngd in foreground. Also, add udev dependency rule on omap_rng
>> module.
>>
>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> ---
>> .../recipes-support/rng-tools/rng-tools/rngd.rules | 1 +
>> .../recipes-support/rng-tools/rng-tools_%.bbappend | 13
>> +++++++++++++
>> 2 files changed, 14 insertions(+)
>> create mode 100644
>> meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>> create mode 100644
>> meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>>
>> diff --git
>> a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>> b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>> new file mode 100644
>> index 0000000..a21c99b
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>> @@ -0,0 +1 @@
>> +ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng",
>> TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
>> diff --git
>> a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>> b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>> new file mode 100644
>> index 0000000..df84536
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>> @@ -0,0 +1,13 @@
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +
>> +PR_append = ".arago0"
>> +
>> +SRC_URI += "file://rngd.rules"
>> +
>> +do_install_append() {
>> + # remove duplicate initscript
>> + rm -f ${D}${sysconfdir}/init.d/rng-tools
>> +
>> + install -d ${D}${sysconfdir}/udev/rules.d/
>> + install -m0644 ${WORKDIR}/rngd.rules
>> ${D}${sysconfdir}/udev/rules.d/
>> +}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-04 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 20:20 [thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load Denys Dmytriyenko
2019-09-03 21:22 ` [EXTERNAL] " Jacob Stiffler
2019-09-04 12:57 ` Jacob Stiffler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.