[thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load

[thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load

[Denys Dmytriyenko]

Since Arago still has a mix of SysVinit iniscripts and systemd unit files, it
enables both of the DISTRO_FEATURES, resulting in some duplication. It appears
that rngd currently has a problem handling signals when forked in daemon mode.
Hence, drop SysVinit initscript in favor of systemd service, as the latter one
starts rngd in foreground. Also, add udev dependency rule on omap_rng module.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 .../recipes-support/rng-tools/rng-tools/rngd.rules          |  1 +
 .../recipes-support/rng-tools/rng-tools_%.bbappend          | 13 +++++++++++++
 2 files changed, 14 insertions(+)
 create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
 create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend

diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
new file mode 100644
index 0000000..a21c99b
--- /dev/null
+++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
@@ -0,0 +1 @@
+ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
new file mode 100644
index 0000000..df84536
--- /dev/null
+++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
@@ -0,0 +1,13 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+PR_append = ".arago0"
+
+SRC_URI += "file://rngd.rules"
+
+do_install_append() {
+	# remove duplicate initscript
+	rm -f ${D}${sysconfdir}/init.d/rng-tools
+
+	install -d ${D}${sysconfdir}/udev/rules.d/
+	install -m0644 ${WORKDIR}/rngd.rules ${D}${sysconfdir}/udev/rules.d/
+}
-- 
2.7.4

Re: [EXTERNAL] [thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load

[Jacob Stiffler]

I manually made these changes to an existing filesystem, rebooted a few 
times, and observed the service status. The service was up every time 
and there was no delay in the service terminating when rebooting.

Tested-by: Jacob Stiffler <j-stiffler@ti.com>

On 9/3/2019 4:20 PM, Denys Dmytriyenko wrote:
> Since Arago still has a mix of SysVinit iniscripts and systemd unit files, it
> enables both of the DISTRO_FEATURES, resulting in some duplication. It appears
> that rngd currently has a problem handling signals when forked in daemon mode.
> Hence, drop SysVinit initscript in favor of systemd service, as the latter one
> starts rngd in foreground. Also, add udev dependency rule on omap_rng module.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>   .../recipes-support/rng-tools/rng-tools/rngd.rules          |  1 +
>   .../recipes-support/rng-tools/rng-tools_%.bbappend          | 13 +++++++++++++
>   2 files changed, 14 insertions(+)
>   create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>   create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> new file mode 100644
> index 0000000..a21c99b
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> @@ -0,0 +1 @@
> +ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> new file mode 100644
> index 0000000..df84536
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> @@ -0,0 +1,13 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +PR_append = ".arago0"
> +
> +SRC_URI += "file://rngd.rules"
> +
> +do_install_append() {
> +	# remove duplicate initscript
> +	rm -f ${D}${sysconfdir}/init.d/rng-tools
> +
> +	install -d ${D}${sysconfdir}/udev/rules.d/
> +	install -m0644 ${WORKDIR}/rngd.rules ${D}${sysconfdir}/udev/rules.d/
> +}

Re: [EXTERNAL] [thud/master][PATCH] rng-tools: remove duplicate initscript and wait for module load

[Jacob Stiffler]

I now tested this in a build. It fails when creating the rootfs. The 
update-rc.d pre/post inst is still defined in the package, so package 
configuration fails because the initscript is not found.

This can be resolved by setting INHIBIT_UPDATERCD_BBCLASS in the 
rng-tools bbappend.


- Jake

On 9/3/2019 5:22 PM, Jacob Stiffler wrote:
> I manually made these changes to an existing filesystem, rebooted a 
> few times, and observed the service status. The service was up every 
> time and there was no delay in the service terminating when rebooting.
>
> Tested-by: Jacob Stiffler <j-stiffler@ti.com>
>
> On 9/3/2019 4:20 PM, Denys Dmytriyenko wrote:
>> Since Arago still has a mix of SysVinit iniscripts and systemd unit 
>> files, it
>> enables both of the DISTRO_FEATURES, resulting in some duplication. 
>> It appears
>> that rngd currently has a problem handling signals when forked in 
>> daemon mode.
>> Hence, drop SysVinit initscript in favor of systemd service, as the 
>> latter one
>> starts rngd in foreground. Also, add udev dependency rule on omap_rng 
>> module.
>>
>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> ---
>>   .../recipes-support/rng-tools/rng-tools/rngd.rules          | 1 +
>>   .../recipes-support/rng-tools/rng-tools_%.bbappend          | 13 
>> +++++++++++++
>>   2 files changed, 14 insertions(+)
>>   create mode 100644 
>> meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>>   create mode 100644 
>> meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>>
>> diff --git 
>> a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules 
>> b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>> new file mode 100644
>> index 0000000..a21c99b
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>> @@ -0,0 +1 @@
>> +ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", 
>> TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
>> diff --git 
>> a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend 
>> b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>> new file mode 100644
>> index 0000000..df84536
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>> @@ -0,0 +1,13 @@
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +
>> +PR_append = ".arago0"
>> +
>> +SRC_URI += "file://rngd.rules"
>> +
>> +do_install_append() {
>> +    # remove duplicate initscript
>> +    rm -f ${D}${sysconfdir}/init.d/rng-tools
>> +
>> +    install -d ${D}${sysconfdir}/udev/rules.d/
>> +    install -m0644 ${WORKDIR}/rngd.rules 
>> ${D}${sysconfdir}/udev/rules.d/
>> +}