All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>
Cc: <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d4_xplained: Mark optional AT25DF321A as disabled
Date: Tue, 22 Jun 2021 15:53:37 +0200	[thread overview]
Message-ID: <4d631b4c-7d0c-3a04-5ab6-00d09c792438@microchip.com> (raw)
In-Reply-To: <20210622134222.107806-1-tudor.ambarus@microchip.com>

Hi Tudor,

On 22/06/2021 at 15:42, Tudor Ambarus wrote:
> sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
> which does not come populated on board by default. Mark it as disabled
> to avoid the following probe error:
> spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 0b3ad1b580b8..f397e2a68e5c 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -40,7 +40,7 @@ uart0: serial@f8004000 {
>   
>   			spi0: spi@f8010000 {
>   				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
> -				status = "okay";
> +				status = "disabled";
>   				m25p80@0 {
>   					compatible = "atmel,at25df321a";
>   					spi-max-frequency = <50000000>;

What about keeping SPI enabled and just having the status of m25p80 as 
disabled: honestly, I don't know if it works and if it's desirable, but 
might be closer to reality.

Tell me what you think.

Regards,
   Nicolas


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>
Cc: <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d4_xplained: Mark optional AT25DF321A as disabled
Date: Tue, 22 Jun 2021 15:53:37 +0200	[thread overview]
Message-ID: <4d631b4c-7d0c-3a04-5ab6-00d09c792438@microchip.com> (raw)
In-Reply-To: <20210622134222.107806-1-tudor.ambarus@microchip.com>

Hi Tudor,

On 22/06/2021 at 15:42, Tudor Ambarus wrote:
> sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
> which does not come populated on board by default. Mark it as disabled
> to avoid the following probe error:
> spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 0b3ad1b580b8..f397e2a68e5c 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -40,7 +40,7 @@ uart0: serial@f8004000 {
>   
>   			spi0: spi@f8010000 {
>   				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
> -				status = "okay";
> +				status = "disabled";
>   				m25p80@0 {
>   					compatible = "atmel,at25df321a";
>   					spi-max-frequency = <50000000>;

What about keeping SPI enabled and just having the status of m25p80 as 
disabled: honestly, I don't know if it works and if it's desirable, but 
might be closer to reality.

Tell me what you think.

Regards,
   Nicolas


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-22 13:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 13:42 [PATCH] ARM: dts: at91: sama5d4_xplained: Mark optional AT25DF321A as disabled Tudor Ambarus
2021-06-22 13:42 ` Tudor Ambarus
2021-06-22 13:53 ` Nicolas Ferre [this message]
2021-06-22 13:53   ` Nicolas Ferre
2021-06-24 15:22   ` Tudor.Ambarus
2021-06-24 15:22     ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d631b4c-7d0c-3a04-5ab6-00d09c792438@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.