From: Esaki Tomohito <etom@igel.co.jp>
To: Daniel Stone <daniel@fooishbar.org>
Cc: dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Michel Dänzer" <mdaenzer@redhat.com>,
"Simon Ser" <contact@emersion.fr>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Bas Nieuwenhuizen" <bas@basnieuwenhuizen.nl>,
"Mark Yacoub" <markyacoub@chromium.org>,
"Sean Paul" <seanpaul@chromium.org>,
"Evan Quan" <evan.quan@amd.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Petr Mladek" <pmladek@suse.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Abhinav Kumar" <abhinavk@codeaurora.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Rob Clark" <robdclark@chromium.org>,
amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nouveau@lists.freedesktop.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Damian Hobson-Garcia" <dhobsong@igel.co.jp>,
"Takanari Hayama" <taki@igel.co.jp>
Subject: Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout
Date: Fri, 14 Jan 2022 10:46:31 +0900 [thread overview]
Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> (raw)
In-Reply-To: <CAPj87rPk3_8LdnwWJ3BhtJnRuR+_WHg2hfdgK2R4SMacPGCrUQ@mail.gmail.com>
Hi Daniel-san,
Thank you for your comments.
On 2022/01/13 22:44, Daniel Stone wrote:
> Hi Esaki-san,
>
> On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki <etom@igel.co.jp> wrote:
>> Some drivers whose planes only support linear layout fb do not support format
>> modifiers.
>> These drivers should support modifiers, however the DRM core should handle this
>> rather than open-coding in every driver.
>>
>> In this patch series, these drivers expose format modifiers based on the
>> following suggestion[1].
>
> Thanks for the series, it looks like the right thing to do.
>
> Can you please change the patch ordering though? At the moment there
> will be a bisection break at patch #1, because the legacy drivers will
> suddenly start gaining modifier support, before it is removed in patch
> #2.
>
> I think a better order would be:
> 1: add fb_modifiers_not_supported flag to core and drivers
> 2: add default modifiers (and set allow_fb_modifiers) if
> fb_modifiers_not_supported flag is not set
> 3: remove allow_fb_modifiers flag
>
I agree to your proposal.
I will fix these patches.
--
--------------------------
株式会社イーゲル
江崎 朋人
etom@igel.co.jp
WARNING: multiple messages have this Message-ID (diff)
From: Esaki Tomohito <etom@igel.co.jp>
To: Daniel Stone <daniel@fooishbar.org>
Cc: "David Airlie" <airlied@linux.ie>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Michel Dänzer" <mdaenzer@redhat.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Clark" <robdclark@chromium.org>,
"Evan Quan" <evan.quan@amd.com>,
amd-gfx@lists.freedesktop.org, "Ben Skeggs" <bskeggs@redhat.com>,
"Petr Mladek" <pmladek@suse.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Abhinav Kumar" <abhinavk@codeaurora.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Takanari Hayama" <taki@igel.co.jp>,
"Sean Paul" <seanpaul@chromium.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Mark Yacoub" <markyacoub@chromium.org>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Damian Hobson-Garcia" <dhobsong@igel.co.jp>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout
Date: Fri, 14 Jan 2022 10:46:31 +0900 [thread overview]
Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> (raw)
In-Reply-To: <CAPj87rPk3_8LdnwWJ3BhtJnRuR+_WHg2hfdgK2R4SMacPGCrUQ@mail.gmail.com>
Hi Daniel-san,
Thank you for your comments.
On 2022/01/13 22:44, Daniel Stone wrote:
> Hi Esaki-san,
>
> On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki <etom@igel.co.jp> wrote:
>> Some drivers whose planes only support linear layout fb do not support format
>> modifiers.
>> These drivers should support modifiers, however the DRM core should handle this
>> rather than open-coding in every driver.
>>
>> In this patch series, these drivers expose format modifiers based on the
>> following suggestion[1].
>
> Thanks for the series, it looks like the right thing to do.
>
> Can you please change the patch ordering though? At the moment there
> will be a bisection break at patch #1, because the legacy drivers will
> suddenly start gaining modifier support, before it is removed in patch
> #2.
>
> I think a better order would be:
> 1: add fb_modifiers_not_supported flag to core and drivers
> 2: add default modifiers (and set allow_fb_modifiers) if
> fb_modifiers_not_supported flag is not set
> 3: remove allow_fb_modifiers flag
>
I agree to your proposal.
I will fix these patches.
--
--------------------------
株式会社イーゲル
江崎 朋人
etom@igel.co.jp
WARNING: multiple messages have this Message-ID (diff)
From: Esaki Tomohito <etom@igel.co.jp>
To: Daniel Stone <daniel@fooishbar.org>
Cc: "David Airlie" <airlied@linux.ie>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Michel Dänzer" <mdaenzer@redhat.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Clark" <robdclark@chromium.org>,
"Evan Quan" <evan.quan@amd.com>,
amd-gfx@lists.freedesktop.org, "Ben Skeggs" <bskeggs@redhat.com>,
"Petr Mladek" <pmladek@suse.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Bas Nieuwenhuizen" <bas@basnieuwenhuizen.nl>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Abhinav Kumar" <abhinavk@codeaurora.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Takanari Hayama" <taki@igel.co.jp>,
"Sean Paul" <seanpaul@chromium.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Mark Yacoub" <markyacoub@chromium.org>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Simon Ser" <contact@emersion.fr>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Damian Hobson-Garcia" <dhobsong@igel.co.jp>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout
Date: Fri, 14 Jan 2022 10:46:31 +0900 [thread overview]
Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> (raw)
In-Reply-To: <CAPj87rPk3_8LdnwWJ3BhtJnRuR+_WHg2hfdgK2R4SMacPGCrUQ@mail.gmail.com>
Hi Daniel-san,
Thank you for your comments.
On 2022/01/13 22:44, Daniel Stone wrote:
> Hi Esaki-san,
>
> On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki <etom@igel.co.jp> wrote:
>> Some drivers whose planes only support linear layout fb do not support format
>> modifiers.
>> These drivers should support modifiers, however the DRM core should handle this
>> rather than open-coding in every driver.
>>
>> In this patch series, these drivers expose format modifiers based on the
>> following suggestion[1].
>
> Thanks for the series, it looks like the right thing to do.
>
> Can you please change the patch ordering though? At the moment there
> will be a bisection break at patch #1, because the legacy drivers will
> suddenly start gaining modifier support, before it is removed in patch
> #2.
>
> I think a better order would be:
> 1: add fb_modifiers_not_supported flag to core and drivers
> 2: add default modifiers (and set allow_fb_modifiers) if
> fb_modifiers_not_supported flag is not set
> 3: remove allow_fb_modifiers flag
>
I agree to your proposal.
I will fix these patches.
--
--------------------------
株式会社イーゲル
江崎 朋人
etom@igel.co.jp
WARNING: multiple messages have this Message-ID (diff)
From: Esaki Tomohito <etom@igel.co.jp>
To: Daniel Stone <daniel@fooishbar.org>
Cc: "David Airlie" <airlied@linux.ie>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Michel Dänzer" <mdaenzer@redhat.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Clark" <robdclark@chromium.org>,
"Evan Quan" <evan.quan@amd.com>,
amd-gfx@lists.freedesktop.org, "Ben Skeggs" <bskeggs@redhat.com>,
"Petr Mladek" <pmladek@suse.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Bas Nieuwenhuizen" <bas@basnieuwenhuizen.nl>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Abhinav Kumar" <abhinavk@codeaurora.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Takanari Hayama" <taki@igel.co.jp>,
"Sean Paul" <seanpaul@chromium.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Mark Yacoub" <markyacoub@chromium.org>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, "Simon Ser" <contact@emersion.fr>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Damian Hobson-Garcia" <dhobsong@igel.co.jp>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [Nouveau] [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout
Date: Fri, 14 Jan 2022 10:46:31 +0900 [thread overview]
Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> (raw)
In-Reply-To: <CAPj87rPk3_8LdnwWJ3BhtJnRuR+_WHg2hfdgK2R4SMacPGCrUQ@mail.gmail.com>
Hi Daniel-san,
Thank you for your comments.
On 2022/01/13 22:44, Daniel Stone wrote:
> Hi Esaki-san,
>
> On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki <etom@igel.co.jp> wrote:
>> Some drivers whose planes only support linear layout fb do not support format
>> modifiers.
>> These drivers should support modifiers, however the DRM core should handle this
>> rather than open-coding in every driver.
>>
>> In this patch series, these drivers expose format modifiers based on the
>> following suggestion[1].
>
> Thanks for the series, it looks like the right thing to do.
>
> Can you please change the patch ordering though? At the moment there
> will be a bisection break at patch #1, because the legacy drivers will
> suddenly start gaining modifier support, before it is removed in patch
> #2.
>
> I think a better order would be:
> 1: add fb_modifiers_not_supported flag to core and drivers
> 2: add default modifiers (and set allow_fb_modifiers) if
> fb_modifiers_not_supported flag is not set
> 3: remove allow_fb_modifiers flag
>
I agree to your proposal.
I will fix these patches.
--
--------------------------
株式会社イーゲル
江崎 朋人
etom@igel.co.jp
next prev parent reply other threads:[~2022-01-14 1:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 9:44 [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout Tomohito Esaki
2022-01-13 9:44 ` [Nouveau] " Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 9:44 ` [RFC PATCH v2 1/3] drm: add " Tomohito Esaki
2022-01-13 9:44 ` [Nouveau] " Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 9:44 ` [RFC PATCH v2 2/3] drm: set fb_modifiers_not_supported flag in legacy drivers Tomohito Esaki
2022-01-13 9:44 ` [Nouveau] " Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 17:56 ` Bas Nieuwenhuizen
2022-01-13 17:56 ` [Nouveau] " Bas Nieuwenhuizen
2022-01-13 17:56 ` Bas Nieuwenhuizen
2022-01-13 17:56 ` Bas Nieuwenhuizen
2022-01-14 2:06 ` Esaki Tomohito
2022-01-14 2:06 ` [Nouveau] " Esaki Tomohito
2022-01-14 2:06 ` Esaki Tomohito
2022-01-14 2:06 ` Esaki Tomohito
2022-01-13 9:44 ` [RFC PATCH v2 3/3] drm: replace allow_fb_modifiers with fb_modifiers_not_supported Tomohito Esaki
2022-01-13 9:44 ` [Nouveau] " Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 9:44 ` Tomohito Esaki
2022-01-13 13:44 ` [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout Daniel Stone
2022-01-13 13:44 ` Daniel Stone
2022-01-13 13:44 ` Daniel Stone
2022-01-13 13:44 ` [Nouveau] " Daniel Stone
2022-01-14 1:46 ` Esaki Tomohito [this message]
2022-01-14 1:46 ` Esaki Tomohito
2022-01-14 1:46 ` Esaki Tomohito
2022-01-14 1:46 ` Esaki Tomohito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp \
--to=etom@igel.co.jp \
--cc=Xinhui.Pan@amd.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bas@basnieuwenhuizen.nl \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=daniel@fooishbar.org \
--cc=dhobsong@igel.co.jp \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyacoub@chromium.org \
--cc=mdaenzer@redhat.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=pmladek@suse.com \
--cc=qingqing.zhuo@amd.com \
--cc=robdclark@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=seanpaul@chromium.org \
--cc=taki@igel.co.jp \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.