All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: arm: fsl: Decrease the line length
@ 2022-06-14 17:32 ` Fabio Estevam
  0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2022-06-14 17:32 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, marcel.ziswiler, francesco.dolcini, linux-arm-kernel,
	devicetree, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Decrease the line length of the toradex,colibri-imx6ull-emmc boards
to fix the following build warning:

./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
line too long (111 > 110 characters) (line-length)

Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 7e5cd4fe5809..1d757af4d05c 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -680,11 +680,11 @@ properties:
       - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL 1GB (eMMC) Module
         items:
           - enum:
-              - toradex,colibri-imx6ull-emmc-aster     # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
-              - toradex,colibri-imx6ull-emmc-eval      # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
-              - toradex,colibri-imx6ull-emmc-iris      # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
-              - toradex,colibri-imx6ull-emmc-iris-v2   # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
-          - const: toradex,colibri-imx6ull-emmc        # Colibri iMX6ULL 1GB (eMMC) Module
+              - toradex,colibri-imx6ull-emmc-aster    # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
+              - toradex,colibri-imx6ull-emmc-eval     # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
+              - toradex,colibri-imx6ull-emmc-iris     # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
+              - toradex,colibri-imx6ull-emmc-iris-v2  # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
+          - const: toradex,colibri-imx6ull-emmc       # Colibri iMX6ULL 1GB (eMMC) Module
           - const: fsl,imx6ull
 
       - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Wi-Fi / BT Modules
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] dt-bindings: arm: fsl: Decrease the line length
@ 2022-06-14 17:32 ` Fabio Estevam
  0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2022-06-14 17:32 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, marcel.ziswiler, francesco.dolcini, linux-arm-kernel,
	devicetree, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Decrease the line length of the toradex,colibri-imx6ull-emmc boards
to fix the following build warning:

./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
line too long (111 > 110 characters) (line-length)

Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 7e5cd4fe5809..1d757af4d05c 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -680,11 +680,11 @@ properties:
       - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL 1GB (eMMC) Module
         items:
           - enum:
-              - toradex,colibri-imx6ull-emmc-aster     # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
-              - toradex,colibri-imx6ull-emmc-eval      # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
-              - toradex,colibri-imx6ull-emmc-iris      # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
-              - toradex,colibri-imx6ull-emmc-iris-v2   # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
-          - const: toradex,colibri-imx6ull-emmc        # Colibri iMX6ULL 1GB (eMMC) Module
+              - toradex,colibri-imx6ull-emmc-aster    # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
+              - toradex,colibri-imx6ull-emmc-eval     # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
+              - toradex,colibri-imx6ull-emmc-iris     # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
+              - toradex,colibri-imx6ull-emmc-iris-v2  # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
+          - const: toradex,colibri-imx6ull-emmc       # Colibri iMX6ULL 1GB (eMMC) Module
           - const: fsl,imx6ull
 
       - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Wi-Fi / BT Modules
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
  2022-06-14 17:32 ` Fabio Estevam
@ 2022-06-14 18:06   ` Francesco Dolcini
  -1 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-06-14 18:06 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh+dt, marcel.ziswiler, francesco.dolcini,
	linux-arm-kernel, devicetree, Fabio Estevam

Thanks Fabio!

On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> to fix the following build warning:
> 
> ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> line too long (111 > 110 characters) (line-length)
> 
> Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
@ 2022-06-14 18:06   ` Francesco Dolcini
  0 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-06-14 18:06 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh+dt, marcel.ziswiler, francesco.dolcini,
	linux-arm-kernel, devicetree, Fabio Estevam

Thanks Fabio!

On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> to fix the following build warning:
> 
> ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> line too long (111 > 110 characters) (line-length)
> 
> Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
  2022-06-14 18:06   ` Francesco Dolcini
@ 2022-06-14 18:13     ` Marcel Ziswiler
  -1 siblings, 0 replies; 8+ messages in thread
From: Marcel Ziswiler @ 2022-06-14 18:13 UTC (permalink / raw)
  To: festevam, Francesco Dolcini
  Cc: linux-arm-kernel, festevam, devicetree, shawnguo, robh+dt

On Tue, 2022-06-14 at 20:06 +0200, Francesco Dolcini wrote:
> Thanks Fabio!

Yeah, sorry about having missed that one. I was just about to send a fix but yours looks fine as well. Thanks!

> On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> > 
> > Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> > to fix the following build warning:
> > 
> > ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> > line too long (111 > 110 characters) (line-length)
> > 
> > Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> > Reported-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
> 
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
@ 2022-06-14 18:13     ` Marcel Ziswiler
  0 siblings, 0 replies; 8+ messages in thread
From: Marcel Ziswiler @ 2022-06-14 18:13 UTC (permalink / raw)
  To: festevam, Francesco Dolcini
  Cc: linux-arm-kernel, festevam, devicetree, shawnguo, robh+dt

On Tue, 2022-06-14 at 20:06 +0200, Francesco Dolcini wrote:
> Thanks Fabio!

Yeah, sorry about having missed that one. I was just about to send a fix but yours looks fine as well. Thanks!

> On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> > 
> > Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> > to fix the following build warning:
> > 
> > ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> > line too long (111 > 110 characters) (line-length)
> > 
> > Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> > Reported-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
> 
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
  2022-06-14 17:32 ` Fabio Estevam
@ 2022-06-16 14:51   ` Rob Herring
  -1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-06-16 14:51 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, marcel.ziswiler, francesco.dolcini, linux-arm-kernel,
	devicetree, Fabio Estevam

On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> to fix the following build warning:
> 
> ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> line too long (111 > 110 characters) (line-length)

110 is not really the goal, but 80 with some 100 exceptions. Same as 
kernel. It's set to 110 because there were more than I cared to fixed.

> 
> Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 7e5cd4fe5809..1d757af4d05c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -680,11 +680,11 @@ properties:
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL 1GB (eMMC) Module
>          items:
>            - enum:
> -              - toradex,colibri-imx6ull-emmc-aster     # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> -              - toradex,colibri-imx6ull-emmc-eval      # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> -              - toradex,colibri-imx6ull-emmc-iris      # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> -              - toradex,colibri-imx6ull-emmc-iris-v2   # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> -          - const: toradex,colibri-imx6ull-emmc        # Colibri iMX6ULL 1GB (eMMC) Module
> +              - toradex,colibri-imx6ull-emmc-aster    # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> +              - toradex,colibri-imx6ull-emmc-eval     # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> +              - toradex,colibri-imx6ull-emmc-iris     # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> +              - toradex,colibri-imx6ull-emmc-iris-v2  # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> +          - const: toradex,colibri-imx6ull-emmc       # Colibri iMX6ULL 1GB (eMMC) Module

The description already says 'Colibri iMX6ULL 1GB (eMMC)'. Why repeat 
that everywhere?

>            - const: fsl,imx6ull
>  
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Wi-Fi / BT Modules
> -- 
> 2.25.1
> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
@ 2022-06-16 14:51   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-06-16 14:51 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, marcel.ziswiler, francesco.dolcini, linux-arm-kernel,
	devicetree, Fabio Estevam

On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> to fix the following build warning:
> 
> ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> line too long (111 > 110 characters) (line-length)

110 is not really the goal, but 80 with some 100 exceptions. Same as 
kernel. It's set to 110 because there were more than I cared to fixed.

> 
> Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 7e5cd4fe5809..1d757af4d05c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -680,11 +680,11 @@ properties:
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL 1GB (eMMC) Module
>          items:
>            - enum:
> -              - toradex,colibri-imx6ull-emmc-aster     # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> -              - toradex,colibri-imx6ull-emmc-eval      # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> -              - toradex,colibri-imx6ull-emmc-iris      # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> -              - toradex,colibri-imx6ull-emmc-iris-v2   # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> -          - const: toradex,colibri-imx6ull-emmc        # Colibri iMX6ULL 1GB (eMMC) Module
> +              - toradex,colibri-imx6ull-emmc-aster    # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> +              - toradex,colibri-imx6ull-emmc-eval     # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> +              - toradex,colibri-imx6ull-emmc-iris     # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> +              - toradex,colibri-imx6ull-emmc-iris-v2  # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> +          - const: toradex,colibri-imx6ull-emmc       # Colibri iMX6ULL 1GB (eMMC) Module

The description already says 'Colibri iMX6ULL 1GB (eMMC)'. Why repeat 
that everywhere?

>            - const: fsl,imx6ull
>  
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Wi-Fi / BT Modules
> -- 
> 2.25.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-06-16 14:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 17:32 [PATCH] dt-bindings: arm: fsl: Decrease the line length Fabio Estevam
2022-06-14 17:32 ` Fabio Estevam
2022-06-14 18:06 ` Francesco Dolcini
2022-06-14 18:06   ` Francesco Dolcini
2022-06-14 18:13   ` Marcel Ziswiler
2022-06-14 18:13     ` Marcel Ziswiler
2022-06-16 14:51 ` Rob Herring
2022-06-16 14:51   ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.