* v5.13-rc3 --> v5.13-rc4 DWC3 breakage
@ 2021-05-31 14:33 Andy Shevchenko
2021-05-31 14:49 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-05-31 14:33 UTC (permalink / raw)
To: Thinh Nguyen
Cc: Felipe Balbi, USB, Ferry Toth, Wesley Cheng, Greg Kroah-Hartman
Hi!
The only patch that made v5.13-rc4 effectively broke USB on Intel Merrifield.
My reproducer:
1. Boot with switch in gadget mode
2. Enable USB ethernet
3. Switch to host
4. wait a bit for device enumeration, etc
5. Switch back
6. No gadget mode, kernel RCU stall detected (USB become unusable, so
does the system)
[ 115.792620] rcu: INFO: rcu_sched self-detected stall on CPU
[ 115.798410] rcu: 0-....: (24089 ticks this GP)
idle=886/1/0x4000000000000000 softirq=3796/3797 fqs=5240
[ 115.808333] (t=21000 jiffies g=6505 q=12158)
[ 115.812847] NMI backtrace for cpu 0
[ 115.816472] CPU: 0 PID: 23 Comm: kworker/0:1 Not tainted 5.13.0-rc4+ #213
...
[ 115.977913] add_dma_entry+0xd4/0x1d0
[ 115.981760] dma_map_page_attrs+0xd8/0x220
[ 115.986063] usb_hcd_map_urb_for_dma+0x3b6/0x4f0
[ 115.990895] usb_hcd_submit_urb+0x98/0xbf0
[ 115.995263] dln2_rx+0x1ae/0x280 [dln2]
...
100% Reproducibility, revert of the 25dda9fc56bd ("usb: dwc3: gadget:
Properly track pending and queued SG") fixes the issue.
Please, fix it properly or revert. Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: v5.13-rc3 --> v5.13-rc4 DWC3 breakage 2021-05-31 14:33 v5.13-rc3 --> v5.13-rc4 DWC3 breakage Andy Shevchenko @ 2021-05-31 14:49 ` Greg Kroah-Hartman 2021-05-31 15:45 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2021-05-31 14:49 UTC (permalink / raw) To: Andy Shevchenko; +Cc: Thinh Nguyen, Felipe Balbi, USB, Ferry Toth, Wesley Cheng On Mon, May 31, 2021 at 05:33:02PM +0300, Andy Shevchenko wrote: > Hi! > > The only patch that made v5.13-rc4 effectively broke USB on Intel Merrifield. > > My reproducer: > 1. Boot with switch in gadget mode > 2. Enable USB ethernet > 3. Switch to host > 4. wait a bit for device enumeration, etc > 5. Switch back > 6. No gadget mode, kernel RCU stall detected (USB become unusable, so > does the system) > > [ 115.792620] rcu: INFO: rcu_sched self-detected stall on CPU > [ 115.798410] rcu: 0-....: (24089 ticks this GP) > idle=886/1/0x4000000000000000 softirq=3796/3797 fqs=5240 > [ 115.808333] (t=21000 jiffies g=6505 q=12158) > [ 115.812847] NMI backtrace for cpu 0 > [ 115.816472] CPU: 0 PID: 23 Comm: kworker/0:1 Not tainted 5.13.0-rc4+ #213 > ... > > [ 115.977913] add_dma_entry+0xd4/0x1d0 > [ 115.981760] dma_map_page_attrs+0xd8/0x220 > [ 115.986063] usb_hcd_map_urb_for_dma+0x3b6/0x4f0 > [ 115.990895] usb_hcd_submit_urb+0x98/0xbf0 > [ 115.995263] dln2_rx+0x1ae/0x280 [dln2] > ... > > 100% Reproducibility, revert of the 25dda9fc56bd ("usb: dwc3: gadget: > Properly track pending and queued SG") fixes the issue. > > Please, fix it properly or revert. Thanks! Care to send the revert? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: v5.13-rc3 --> v5.13-rc4 DWC3 breakage 2021-05-31 14:49 ` Greg Kroah-Hartman @ 2021-05-31 15:45 ` Andy Shevchenko 2021-05-31 20:22 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2021-05-31 15:45 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Thinh Nguyen, Felipe Balbi, USB, Ferry Toth, Wesley Cheng On Mon, May 31, 2021 at 5:49 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, May 31, 2021 at 05:33:02PM +0300, Andy Shevchenko wrote: > > Hi! > > > > The only patch that made v5.13-rc4 effectively broke USB on Intel Merrifield. > > > > My reproducer: > > 1. Boot with switch in gadget mode > > 2. Enable USB ethernet > > 3. Switch to host > > 4. wait a bit for device enumeration, etc > > 5. Switch back > > 6. No gadget mode, kernel RCU stall detected (USB become unusable, so > > does the system) > > > > [ 115.792620] rcu: INFO: rcu_sched self-detected stall on CPU > > [ 115.798410] rcu: 0-....: (24089 ticks this GP) > > idle=886/1/0x4000000000000000 softirq=3796/3797 fqs=5240 > > [ 115.808333] (t=21000 jiffies g=6505 q=12158) > > [ 115.812847] NMI backtrace for cpu 0 > > [ 115.816472] CPU: 0 PID: 23 Comm: kworker/0:1 Not tainted 5.13.0-rc4+ #213 > > ... > > > > [ 115.977913] add_dma_entry+0xd4/0x1d0 > > [ 115.981760] dma_map_page_attrs+0xd8/0x220 > > [ 115.986063] usb_hcd_map_urb_for_dma+0x3b6/0x4f0 > > [ 115.990895] usb_hcd_submit_urb+0x98/0xbf0 > > [ 115.995263] dln2_rx+0x1ae/0x280 [dln2] > > ... > > > > 100% Reproducibility, revert of the 25dda9fc56bd ("usb: dwc3: gadget: > > Properly track pending and queued SG") fixes the issue. > > > > Please, fix it properly or revert. Thanks! > > Care to send the revert? Sure, But I want to give Thinh a chance to react to this, maybe it would be a better idea. Let's say if nothing happens I will send it on Wednesday. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: v5.13-rc3 --> v5.13-rc4 DWC3 breakage 2021-05-31 15:45 ` Andy Shevchenko @ 2021-05-31 20:22 ` Andy Shevchenko 2021-06-01 17:31 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2021-05-31 20:22 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Thinh Nguyen, Felipe Balbi, USB, Ferry Toth, Wesley Cheng On Mon, May 31, 2021 at 6:45 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Mon, May 31, 2021 at 5:49 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Mon, May 31, 2021 at 05:33:02PM +0300, Andy Shevchenko wrote: > > > Hi! > > > > > > The only patch that made v5.13-rc4 effectively broke USB on Intel Merrifield. > > > > > > My reproducer: > > > 1. Boot with switch in gadget mode > > > 2. Enable USB ethernet > > > 3. Switch to host > > > 4. wait a bit for device enumeration, etc > > > 5. Switch back > > > 6. No gadget mode, kernel RCU stall detected (USB become unusable, so > > > does the system) > > > > > > [ 115.792620] rcu: INFO: rcu_sched self-detected stall on CPU > > > [ 115.798410] rcu: 0-....: (24089 ticks this GP) > > > idle=886/1/0x4000000000000000 softirq=3796/3797 fqs=5240 > > > [ 115.808333] (t=21000 jiffies g=6505 q=12158) > > > [ 115.812847] NMI backtrace for cpu 0 > > > [ 115.816472] CPU: 0 PID: 23 Comm: kworker/0:1 Not tainted 5.13.0-rc4+ #213 > > > ... > > > > > > [ 115.977913] add_dma_entry+0xd4/0x1d0 > > > [ 115.981760] dma_map_page_attrs+0xd8/0x220 > > > [ 115.986063] usb_hcd_map_urb_for_dma+0x3b6/0x4f0 > > > [ 115.990895] usb_hcd_submit_urb+0x98/0xbf0 > > > [ 115.995263] dln2_rx+0x1ae/0x280 [dln2] > > > ... > > > > > > 100% Reproducibility, revert of the 25dda9fc56bd ("usb: dwc3: gadget: > > > Properly track pending and queued SG") fixes the issue. > > > > > > Please, fix it properly or revert. Thanks! > > > > Care to send the revert? > > Sure, But I want to give Thinh a chance to react to this, maybe it > would be a better idea. > Let's say if nothing happens I will send it on Wednesday. Please, hold on, I have to perform additional testing (something odd is going on on my side). -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: v5.13-rc3 --> v5.13-rc4 DWC3 breakage 2021-05-31 20:22 ` Andy Shevchenko @ 2021-06-01 17:31 ` Andy Shevchenko 2021-06-01 20:00 ` Ferry Toth 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2021-06-01 17:31 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Thinh Nguyen, Felipe Balbi, USB, Ferry Toth, Wesley Cheng On Mon, May 31, 2021 at 11:22 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Mon, May 31, 2021 at 6:45 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > On Mon, May 31, 2021 at 5:49 PM Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > > > > > > On Mon, May 31, 2021 at 05:33:02PM +0300, Andy Shevchenko wrote: > > > > Hi! > > > > > > > > The only patch that made v5.13-rc4 effectively broke USB on Intel Merrifield. > > > > > > > > My reproducer: > > > > 1. Boot with switch in gadget mode > > > > 2. Enable USB ethernet > > > > 3. Switch to host > > > > 4. wait a bit for device enumeration, etc > > > > 5. Switch back > > > > 6. No gadget mode, kernel RCU stall detected (USB become unusable, so > > > > does the system) > > > > > > > > [ 115.792620] rcu: INFO: rcu_sched self-detected stall on CPU > > > > [ 115.798410] rcu: 0-....: (24089 ticks this GP) > > > > idle=886/1/0x4000000000000000 softirq=3796/3797 fqs=5240 > > > > [ 115.808333] (t=21000 jiffies g=6505 q=12158) > > > > [ 115.812847] NMI backtrace for cpu 0 > > > > [ 115.816472] CPU: 0 PID: 23 Comm: kworker/0:1 Not tainted 5.13.0-rc4+ #213 > > > > ... > > > > > > > > [ 115.977913] add_dma_entry+0xd4/0x1d0 > > > > [ 115.981760] dma_map_page_attrs+0xd8/0x220 > > > > [ 115.986063] usb_hcd_map_urb_for_dma+0x3b6/0x4f0 > > > > [ 115.990895] usb_hcd_submit_urb+0x98/0xbf0 > > > > [ 115.995263] dln2_rx+0x1ae/0x280 [dln2] > > > > ... > > > > > > > > 100% Reproducibility, revert of the 25dda9fc56bd ("usb: dwc3: gadget: > > > > Properly track pending and queued SG") fixes the issue. > > > > > > > > Please, fix it properly or revert. Thanks! > > > > > > Care to send the revert? > > > > Sure, But I want to give Thinh a chance to react to this, maybe it > > would be a better idea. > > Let's say if nothing happens I will send it on Wednesday. > > Please, hold on, I have to perform additional testing (something odd > is going on on my side). It appears that the reported patch has nothing to do with the issue. It "luckily" helped, but under more tests I managed to dive as deep as v5.11 and got the same issue. I will continue investigating and will inform / send patch / etc when I find more robust reproducer. Anyway it's not the reported patch for sure, sorry for the noise. (It seems I'm looking in a wrong corner< I have some ideas, but it requires time to check) -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: v5.13-rc3 --> v5.13-rc4 DWC3 breakage 2021-06-01 17:31 ` Andy Shevchenko @ 2021-06-01 20:00 ` Ferry Toth 0 siblings, 0 replies; 6+ messages in thread From: Ferry Toth @ 2021-06-01 20:00 UTC (permalink / raw) To: Andy Shevchenko, Greg Kroah-Hartman Cc: Thinh Nguyen, Felipe Balbi, USB, Wesley Cheng Hi Op 01-06-2021 om 19:31 schreef Andy Shevchenko: > On Mon, May 31, 2021 at 11:22 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> On Mon, May 31, 2021 at 6:45 PM Andy Shevchenko >> <andy.shevchenko@gmail.com> wrote: >>> On Mon, May 31, 2021 at 5:49 PM Greg Kroah-Hartman >>> <gregkh@linuxfoundation.org> wrote: >>>> On Mon, May 31, 2021 at 05:33:02PM +0300, Andy Shevchenko wrote: >>>>> Hi! >>>>> >>>>> The only patch that made v5.13-rc4 effectively broke USB on Intel Merrifield. >>>>> >>>>> My reproducer: >>>>> 1. Boot with switch in gadget mode >>>>> 2. Enable USB ethernet >>>>> 3. Switch to host >>>>> 4. wait a bit for device enumeration, etc >>>>> 5. Switch back >>>>> 6. No gadget mode, kernel RCU stall detected (USB become unusable, so >>>>> does the system) >>>>> >>>>> [ 115.792620] rcu: INFO: rcu_sched self-detected stall on CPU >>>>> [ 115.798410] rcu: 0-....: (24089 ticks this GP) >>>>> idle=886/1/0x4000000000000000 softirq=3796/3797 fqs=5240 >>>>> [ 115.808333] (t=21000 jiffies g=6505 q=12158) >>>>> [ 115.812847] NMI backtrace for cpu 0 >>>>> [ 115.816472] CPU: 0 PID: 23 Comm: kworker/0:1 Not tainted 5.13.0-rc4+ #213 >>>>> ... >>>>> >>>>> [ 115.977913] add_dma_entry+0xd4/0x1d0 >>>>> [ 115.981760] dma_map_page_attrs+0xd8/0x220 >>>>> [ 115.986063] usb_hcd_map_urb_for_dma+0x3b6/0x4f0 >>>>> [ 115.990895] usb_hcd_submit_urb+0x98/0xbf0 >>>>> [ 115.995263] dln2_rx+0x1ae/0x280 [dln2] >>>>> ... >>>>> >>>>> 100% Reproducibility, revert of the 25dda9fc56bd ("usb: dwc3: gadget: >>>>> Properly track pending and queued SG") fixes the issue. >>>>> >>>>> Please, fix it properly or revert. Thanks! >>>> Care to send the revert? >>> Sure, But I want to give Thinh a chance to react to this, maybe it >>> would be a better idea. >>> Let's say if nothing happens I will send it on Wednesday. >> Please, hold on, I have to perform additional testing (something odd >> is going on on my side). Hi Andy I tested my 5.13-rc4 which has only 2 dwc3 related patches on top: the good old "REVERTME: usb: dwc3: gadget: skip endpoints ep[18]{in,out}" and "extcon: intel-mrfld: Sync hardware and software state on init" (will hopefully go in 5.14). I did not reproduce stalls or oopses. Dwc3 host/gadget seems to be working nicely now and switching back and forth without issues in my case (after considerable help from Thinh earlier). > It appears that the reported patch has nothing to do with the issue. > It "luckily" helped, but under more tests I managed to dive as deep as > v5.11 and got the same issue. I will continue investigating and will > inform / send patch / etc when I find more robust reproducer. Anyway > it's not the reported patch for sure, sorry for the noise. > > (It seems I'm looking in a wrong corner< I have some ideas, but it > requires time to check) > I'd be happy to apply additional patches to see if those trigger the issue if you have suggestions. In the meanwhile I'll be testing 5.13-rc's just in case. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-01 20:00 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-31 14:33 v5.13-rc3 --> v5.13-rc4 DWC3 breakage Andy Shevchenko 2021-05-31 14:49 ` Greg Kroah-Hartman 2021-05-31 15:45 ` Andy Shevchenko 2021-05-31 20:22 ` Andy Shevchenko 2021-06-01 17:31 ` Andy Shevchenko 2021-06-01 20:00 ` Ferry Toth
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.