All of lore.kernel.org
 help / color / mirror / Atom feed
From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: Max Gurtovoy <maxg@mellanox.com>,
	keith.busch@intel.com, axboe@fb.com, hch@lst.de,
	sagi@grimberg.me, james.smart@broadcom.com
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure
Date: Fri, 19 Jan 2018 17:49:31 +0800	[thread overview]
Message-ID: <4fc5bb3c-9947-35eb-42b5-7d9f5190ee9a@oracle.com> (raw)
In-Reply-To: <4be66899-0246-9d03-eb03-76488e7e629e@mellanox.com>

Hi Max

Thanks for your kindly comment and response.

On 01/18/2018 06:17 PM, Max Gurtovoy wrote:
> 
> On 1/18/2018 12:10 PM, Jianchao Wang wrote:
>> After Sagi's commit (nvme-rdma: fix concurrent reset and reconnect),
>> both nvme-fc/rdma have following pattern:
>> RESETTING    - quiesce blk-mq queues, teardown and delete queues/
>>                 connections, clear out outstanding IO requests...
>> RECONNECTING - establish new queues/connections and some other
>>                 initializing things.
> 
> I guess we can call it NVME_CTRL_CONNECTING in later patch (more suitable name for this state now).

I think we can change the name in another patchset in which just talk about the more suitable names of the states.
:)
Thanks
Jianchao

WARNING: multiple messages have this Message-ID (diff)
From: jianchao.w.wang@oracle.com (jianchao.wang)
Subject: [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure
Date: Fri, 19 Jan 2018 17:49:31 +0800	[thread overview]
Message-ID: <4fc5bb3c-9947-35eb-42b5-7d9f5190ee9a@oracle.com> (raw)
In-Reply-To: <4be66899-0246-9d03-eb03-76488e7e629e@mellanox.com>

Hi Max

Thanks for your kindly comment and response.

On 01/18/2018 06:17 PM, Max Gurtovoy wrote:
> 
> On 1/18/2018 12:10 PM, Jianchao Wang wrote:
>> After Sagi's commit (nvme-rdma: fix concurrent reset and reconnect),
>> both nvme-fc/rdma have following pattern:
>> RESETTING??? - quiesce blk-mq queues, teardown and delete queues/
>> ??????????????? connections, clear out outstanding IO requests...
>> RECONNECTING - establish new queues/connections and some other
>> ??????????????? initializing things.
> 
> I guess we can call it NVME_CTRL_CONNECTING in later patch (more suitable name for this state now).

I think we can change the name in another patchset in which just talk about the more suitable names of the states.
:)
Thanks
Jianchao

  reply	other threads:[~2018-01-19  9:50 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18 10:10 [PATCH V5 0/2] nvme-pci: fix the timeout case when reset is ongoing Jianchao Wang
2018-01-18 10:10 ` Jianchao Wang
2018-01-18 10:10 ` [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure Jianchao Wang
2018-01-18 10:10   ` Jianchao Wang
2018-01-18 10:17   ` Max Gurtovoy
2018-01-18 10:17     ` Max Gurtovoy
2018-01-19  9:49     ` jianchao.wang [this message]
2018-01-19  9:49       ` jianchao.wang
2018-01-18 15:23   ` James Smart
2018-01-18 15:23     ` James Smart
2018-01-18 10:10 ` [PATCH V5 2/2] nvme-pci: fixup the timeout case when reset is ongoing Jianchao Wang
2018-01-18 10:10   ` Jianchao Wang
2018-01-19  4:59   ` Keith Busch
2018-01-19  4:59     ` Keith Busch
2018-01-19  5:55     ` jianchao.wang
2018-01-19  5:55       ` jianchao.wang
2018-01-19  6:05       ` Keith Busch
2018-01-19  6:05         ` Keith Busch
2018-01-19  6:53         ` jianchao.wang
2018-01-19  6:53           ` jianchao.wang
2018-01-18 15:34 ` [PATCH V5 0/2] nvme-pci: fix " James Smart
2018-01-18 15:34   ` James Smart
2018-01-19  8:01 ` Keith Busch
2018-01-19  8:01   ` Keith Busch
2018-01-19  8:14   ` jianchao.wang
2018-01-19  8:14     ` jianchao.wang
2018-01-19  8:42     ` Keith Busch
2018-01-19  8:42       ` Keith Busch
2018-01-19  9:02       ` jianchao.wang
2018-01-19  9:02         ` jianchao.wang
2018-01-19 11:52         ` Keith Busch
2018-01-19 11:52           ` Keith Busch
2018-01-19 13:56           ` jianchao.wang
2018-01-19 13:56             ` jianchao.wang
2018-01-20  2:11             ` Keith Busch
2018-01-20  2:11               ` Keith Busch
2018-01-20 14:07               ` jianchao.wang
2018-01-20 14:07                 ` jianchao.wang
2018-01-20 14:14                 ` jianchao.wang
2018-01-20 14:14                   ` jianchao.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fc5bb3c-9947-35eb-42b5-7d9f5190ee9a@oracle.com \
    --to=jianchao.w.wang@oracle.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.