* [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
@ 2012-07-31 13:37 ` AnilKumar, Chimata
0 siblings, 0 replies; 18+ messages in thread
From: AnilKumar, Chimata @ 2012-07-31 13:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Peter,
On Fri, Jul 27, 2012 at 14:40:52, Ujfalusi, Peter wrote:
> Hi,
>
> On 07/24/2012 06:45 PM, AnilKumar Ch wrote:
> > Adds basic pinctrl support for AM33XX family of devices. This patch
> > is based on the pinctrl-simple driver submitted by Tony Lindgren's
> > here: http://lwn.net/Articles/496075/
> >
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > ---
> > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index 59509c4..9b974dc 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -40,6 +40,15 @@
> > };
> > };
> >
> > + am3358_pinmux: pinmux at 44E10800 {
> > + compatible = "pinctrl-single";
> > + reg = <0x44E10800 0x0338>;
>
> I'm just curious about the size here: how it ended up as 0x0338?
> While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
> 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
> documented at least.
No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
or pinmux utility (we cannot find the exact offsets but pins we can find after
0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
Regards
AnilKumar
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
2012-07-31 13:37 ` AnilKumar, Chimata
@ 2012-08-07 7:43 ` Tony Lindgren
-1 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2012-08-07 7:43 UTC (permalink / raw)
To: AnilKumar, Chimata
Cc: Ujfalusi, Peter, linux-omap, Cousson, Benoit, linux-arm-kernel,
devicetree-discuss, grant.likely
* AnilKumar, Chimata <anilkumar@ti.com> [120731 06:37]:
> Hi Peter,
>
> On Fri, Jul 27, 2012 at 14:40:52, Ujfalusi, Peter wrote:
> > Hi,
> >
> > On 07/24/2012 06:45 PM, AnilKumar Ch wrote:
> > > Adds basic pinctrl support for AM33XX family of devices. This patch
> > > is based on the pinctrl-simple driver submitted by Tony Lindgren's
> > > here: http://lwn.net/Articles/496075/
> > >
> > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > > ---
> > > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > > index 59509c4..9b974dc 100644
> > > --- a/arch/arm/boot/dts/am33xx.dtsi
> > > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > > @@ -40,6 +40,15 @@
> > > };
> > > };
> > >
> > > + am3358_pinmux: pinmux@44E10800 {
> > > + compatible = "pinctrl-single";
> > > + reg = <0x44E10800 0x0338>;
> >
> > I'm just curious about the size here: how it ended up as 0x0338?
> > While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
> > 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
> > documented at least.
>
> No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> or pinmux utility (we cannot find the exact offsets but pins we can find after
> 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
If you have a hole inbetween the registers it sounds like you also have core and
wkup domains? In that case those should be set up as separate controllers as other
SCM registers may be inbetween those domains.
Tony
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
@ 2012-08-07 7:43 ` Tony Lindgren
0 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2012-08-07 7:43 UTC (permalink / raw)
To: linux-arm-kernel
* AnilKumar, Chimata <anilkumar@ti.com> [120731 06:37]:
> Hi Peter,
>
> On Fri, Jul 27, 2012 at 14:40:52, Ujfalusi, Peter wrote:
> > Hi,
> >
> > On 07/24/2012 06:45 PM, AnilKumar Ch wrote:
> > > Adds basic pinctrl support for AM33XX family of devices. This patch
> > > is based on the pinctrl-simple driver submitted by Tony Lindgren's
> > > here: http://lwn.net/Articles/496075/
> > >
> > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > > ---
> > > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > > index 59509c4..9b974dc 100644
> > > --- a/arch/arm/boot/dts/am33xx.dtsi
> > > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > > @@ -40,6 +40,15 @@
> > > };
> > > };
> > >
> > > + am3358_pinmux: pinmux at 44E10800 {
> > > + compatible = "pinctrl-single";
> > > + reg = <0x44E10800 0x0338>;
> >
> > I'm just curious about the size here: how it ended up as 0x0338?
> > While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
> > 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
> > documented at least.
>
> No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> or pinmux utility (we cannot find the exact offsets but pins we can find after
> 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
If you have a hole inbetween the registers it sounds like you also have core and
wkup domains? In that case those should be set up as separate controllers as other
SCM registers may be inbetween those domains.
Tony
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
2012-08-07 7:43 ` Tony Lindgren
@ 2012-08-07 8:50 ` AnilKumar, Chimata
-1 siblings, 0 replies; 18+ messages in thread
From: AnilKumar, Chimata @ 2012-08-07 8:50 UTC (permalink / raw)
To: Tony Lindgren
Cc: Ujfalusi, Peter, linux-omap, Cousson, Benoit, linux-arm-kernel,
devicetree-discuss, grant.likely
Hi Tony,
On Tue, Aug 07, 2012 at 13:13:48, Tony Lindgren wrote:
> * AnilKumar, Chimata <anilkumar@ti.com> [120731 06:37]:
> > Hi Peter,
> >
> > On Fri, Jul 27, 2012 at 14:40:52, Ujfalusi, Peter wrote:
> > > Hi,
> > >
> > > On 07/24/2012 06:45 PM, AnilKumar Ch wrote:
> > > > Adds basic pinctrl support for AM33XX family of devices. This patch
> > > > is based on the pinctrl-simple driver submitted by Tony Lindgren's
> > > > here: http://lwn.net/Articles/496075/
> > > >
> > > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > > > ---
> > > > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++
> > > > 1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > > > index 59509c4..9b974dc 100644
> > > > --- a/arch/arm/boot/dts/am33xx.dtsi
> > > > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > > > @@ -40,6 +40,15 @@
> > > > };
> > > > };
> > > >
> > > > + am3358_pinmux: pinmux@44E10800 {
> > > > + compatible = "pinctrl-single";
> > > > + reg = <0x44E10800 0x0338>;
> > >
> > > I'm just curious about the size here: how it ended up as 0x0338?
> > > While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
> > > 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
> > > documented at least.
> >
> > No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> > or pinmux utility (we cannot find the exact offsets but pins we can find after
> > 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
>
> If you have a hole inbetween the registers it sounds like you also have core and
> wkup domains? In that case those should be set up as separate controllers as other
> SCM registers may be inbetween those domains.
>
In case of AM33XX we have only one padconf domain and it do not have any holes
in between.
Regards
AnilKumar
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
@ 2012-08-07 8:50 ` AnilKumar, Chimata
0 siblings, 0 replies; 18+ messages in thread
From: AnilKumar, Chimata @ 2012-08-07 8:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tony,
On Tue, Aug 07, 2012 at 13:13:48, Tony Lindgren wrote:
> * AnilKumar, Chimata <anilkumar@ti.com> [120731 06:37]:
> > Hi Peter,
> >
> > On Fri, Jul 27, 2012 at 14:40:52, Ujfalusi, Peter wrote:
> > > Hi,
> > >
> > > On 07/24/2012 06:45 PM, AnilKumar Ch wrote:
> > > > Adds basic pinctrl support for AM33XX family of devices. This patch
> > > > is based on the pinctrl-simple driver submitted by Tony Lindgren's
> > > > here: http://lwn.net/Articles/496075/
> > > >
> > > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > > > ---
> > > > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++
> > > > 1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > > > index 59509c4..9b974dc 100644
> > > > --- a/arch/arm/boot/dts/am33xx.dtsi
> > > > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > > > @@ -40,6 +40,15 @@
> > > > };
> > > > };
> > > >
> > > > + am3358_pinmux: pinmux at 44E10800 {
> > > > + compatible = "pinctrl-single";
> > > > + reg = <0x44E10800 0x0338>;
> > >
> > > I'm just curious about the size here: how it ended up as 0x0338?
> > > While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
> > > 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
> > > documented at least.
> >
> > No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> > or pinmux utility (we cannot find the exact offsets but pins we can find after
> > 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
>
> If you have a hole inbetween the registers it sounds like you also have core and
> wkup domains? In that case those should be set up as separate controllers as other
> SCM registers may be inbetween those domains.
>
In case of AM33XX we have only one padconf domain and it do not have any holes
in between.
Regards
AnilKumar
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
2012-07-31 13:37 ` AnilKumar, Chimata
@ 2012-08-08 12:05 ` Peter Ujfalusi
-1 siblings, 0 replies; 18+ messages in thread
From: Peter Ujfalusi @ 2012-08-08 12:05 UTC (permalink / raw)
To: AnilKumar, Chimata
Cc: linux-omap, tony, Cousson, Benoit, linux-arm-kernel,
devicetree-discuss, grant.likely
On 07/31/2012 04:37 PM, AnilKumar, Chimata wrote:
>> I'm just curious about the size here: how it ended up as 0x0338?
>> While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
>> 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
>> documented at least.
>
> No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> or pinmux utility (we cannot find the exact offsets but pins we can find after
> 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
I have looked at the latest TRM (Rev F, SPRUH73F - public TRM) and there is
not mention of registers between 0x0a34 and 0x0e00.
I can not even find any reference of conf_ddr_resetn register either in the TRM.
I can not check with the pinmuxtool since it is crashing with wine under Linux.
There could be registers after 0x0a34, but they are not publicly documented...
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
@ 2012-08-08 12:05 ` Peter Ujfalusi
0 siblings, 0 replies; 18+ messages in thread
From: Peter Ujfalusi @ 2012-08-08 12:05 UTC (permalink / raw)
To: linux-arm-kernel
On 07/31/2012 04:37 PM, AnilKumar, Chimata wrote:
>> I'm just curious about the size here: how it ended up as 0x0338?
>> While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
>> 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
>> documented at least.
>
> No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> or pinmux utility (we cannot find the exact offsets but pins we can find after
> 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
I have looked at the latest TRM (Rev F, SPRUH73F - public TRM) and there is
not mention of registers between 0x0a34 and 0x0e00.
I can not even find any reference of conf_ddr_resetn register either in the TRM.
I can not check with the pinmuxtool since it is crashing with wine under Linux.
There could be registers after 0x0a34, but they are not publicly documented...
--
P?ter
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
2012-08-08 12:05 ` Peter Ujfalusi
@ 2012-08-13 4:33 ` AnilKumar, Chimata
-1 siblings, 0 replies; 18+ messages in thread
From: AnilKumar, Chimata @ 2012-08-13 4:33 UTC (permalink / raw)
To: Ujfalusi, Peter
Cc: linux-omap, tony, Cousson, Benoit, linux-arm-kernel,
devicetree-discuss, grant.likely
Peter,
On Wed, Aug 08, 2012 at 17:35:44, Ujfalusi, Peter wrote:
> On 07/31/2012 04:37 PM, AnilKumar, Chimata wrote:
> >> I'm just curious about the size here: how it ended up as 0x0338?
> >> While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
> >> 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
> >> documented at least.
> >
> > No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> > or pinmux utility (we cannot find the exact offsets but pins we can find after
> > 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
>
> I have looked at the latest TRM (Rev F, SPRUH73F - public TRM) and there is
> not mention of registers between 0x0a34 and 0x0e00.
> I can not even find any reference of conf_ddr_resetn register either in the TRM.
> I can not check with the pinmuxtool since it is crashing with wine under Linux.
> There could be registers after 0x0a34, but they are not publicly documented...
>
Thanks for pointing this, I was referring older version (Rev C) of TRM which have
the details which is not present in latest TRM. These pins are dedicated ones so
pinmuxing is not required. I will submit new version.
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH RESEND v2 1/2] arm/dts: Add AM33XX basic pinctrl support
@ 2012-08-13 4:33 ` AnilKumar, Chimata
0 siblings, 0 replies; 18+ messages in thread
From: AnilKumar, Chimata @ 2012-08-13 4:33 UTC (permalink / raw)
To: linux-arm-kernel
Peter,
On Wed, Aug 08, 2012 at 17:35:44, Ujfalusi, Peter wrote:
> On 07/31/2012 04:37 PM, AnilKumar, Chimata wrote:
> >> I'm just curious about the size here: how it ended up as 0x0338?
> >> While looking at the TRM of AM335x I can come up with 0x0238 (0x44e10800 -
> >> 0x44e10a38), but I don't see any sings of the remaining 0x0100 to be
> >> documented at least.
> >
> > No, pinmux registers are available till 0x44E10B38, look at AM335x latest TRM
> > or pinmux utility (we cannot find the exact offsets but pins we can find after
> > 0x0A38, conf_ddr_resetn) at http://www.ti.com/tool/pinmuxtool
>
> I have looked at the latest TRM (Rev F, SPRUH73F - public TRM) and there is
> not mention of registers between 0x0a34 and 0x0e00.
> I can not even find any reference of conf_ddr_resetn register either in the TRM.
> I can not check with the pinmuxtool since it is crashing with wine under Linux.
> There could be registers after 0x0a34, but they are not publicly documented...
>
Thanks for pointing this, I was referring older version (Rev C) of TRM which have
the details which is not present in latest TRM. These pins are dedicated ones so
pinmuxing is not required. I will submit new version.
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 18+ messages in thread