All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Bharat Bhushan <r65777@freescale.com>, <kvm-ppc@vger.kernel.org>,
	<kvm@vger.kernel.org>,
	Bharat Bhushan <Bharat.Bhushan@freescale.com>
Subject: Re: [PATCH 3/3] KVM: PPC: booke: Added debug handler
Date: Tue, 7 Aug 2012 15:44:30 -0500	[thread overview]
Message-ID: <50217E2E.6060607@freescale.com> (raw)
In-Reply-To: <D65633A8-635A-4992-8F13-3E4FE72151DB@suse.de>

On 08/07/2012 05:47 AM, Alexander Graf wrote:
>> diff --git a/arch/powerpc/kvm/booke_interrupts.S b/arch/powerpc/kvm/booke_interrupts.S
>> index 3539805..890673c 100644
>> --- a/arch/powerpc/kvm/booke_interrupts.S
>> +++ b/arch/powerpc/kvm/booke_interrupts.S
>> @@ -73,6 +73,51 @@ _GLOBAL(kvmppc_handler_\ivor_nr)
>> 	bctr
>> .endm
>>
>> +.macro KVM_DBG_HANDLER ivor_nr scratch srr0
> 
> This is a lot of asm code. Any chance to share a good share of it with the generic handler?

That entire file could use an update to lok more like
bookehv_interrupts.S and its use of asm macros.

-Scott



WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Bharat Bhushan <r65777@freescale.com>,
	kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	Bharat Bhushan <Bharat.Bhushan@freescale.com>
Subject: Re: [PATCH 3/3] KVM: PPC: booke: Added debug handler
Date: Tue, 07 Aug 2012 20:44:30 +0000	[thread overview]
Message-ID: <50217E2E.6060607@freescale.com> (raw)
In-Reply-To: <D65633A8-635A-4992-8F13-3E4FE72151DB@suse.de>

On 08/07/2012 05:47 AM, Alexander Graf wrote:
>> diff --git a/arch/powerpc/kvm/booke_interrupts.S b/arch/powerpc/kvm/booke_interrupts.S
>> index 3539805..890673c 100644
>> --- a/arch/powerpc/kvm/booke_interrupts.S
>> +++ b/arch/powerpc/kvm/booke_interrupts.S
>> @@ -73,6 +73,51 @@ _GLOBAL(kvmppc_handler_\ivor_nr)
>> 	bctr
>> .endm
>>
>> +.macro KVM_DBG_HANDLER ivor_nr scratch srr0
> 
> This is a lot of asm code. Any chance to share a good share of it with the generic handler?

That entire file could use an update to lok more like
bookehv_interrupts.S and its use of asm macros.

-Scott



  parent reply	other threads:[~2012-08-07 20:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03  7:08 [PATCH 1/3] booke: Added ONE_REG interface for IAC/DAC debug registers Bharat Bhushan
2012-08-03  7:20 ` Bharat Bhushan
2012-08-03  7:08 ` [PATCH 2/3] KVM: PPC: booke: Allow multiple exception types Bharat Bhushan
2012-08-03  7:20   ` Bharat Bhushan
2012-08-07 10:46   ` Alexander Graf
2012-08-07 10:46     ` Alexander Graf
2012-08-10  6:38     ` Bhushan Bharat-R65777
2012-08-10  9:19       ` Alexander Graf
2012-08-10  9:19         ` Alexander Graf
2012-08-10 10:41         ` Bhushan Bharat-R65777
2012-08-10 10:57           ` Alexander Graf
2012-08-10 10:57             ` Alexander Graf
2012-08-10 10:59             ` Bhushan Bharat-R65777
2012-08-10 10:59               ` Bhushan Bharat-R65777
2012-08-03  7:08 ` [PATCH 3/3] KVM: PPC: booke: Added debug handler Bharat Bhushan
2012-08-03  7:20   ` Bharat Bhushan
2012-08-07 10:47   ` Alexander Graf
2012-08-07 10:47     ` Alexander Graf
2012-08-07 16:02     ` Bhushan Bharat-R65777
2012-08-07 16:02       ` Bhushan Bharat-R65777
2012-08-07 20:44     ` Scott Wood [this message]
2012-08-07 20:44       ` Scott Wood
2012-08-08  1:02       ` Bhushan Bharat-R65777
2012-08-08  1:02         ` Bhushan Bharat-R65777
2012-08-08 11:10         ` Alexander Graf
2012-08-08 11:10           ` Alexander Graf
2012-08-10  6:55           ` Bhushan Bharat-R65777
2012-08-10  9:21             ` Alexander Graf
2012-08-10  9:21               ` Alexander Graf
2012-08-07 10:30 ` [PATCH 1/3] booke: Added ONE_REG interface for IAC/DAC debug registers Alexander Graf
2012-08-07 10:30   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50217E2E.6060607@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Bharat.Bhushan@freescale.com \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=r65777@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.