All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
Date: Thu, 09 Aug 2012 23:46:05 -0700	[thread overview]
Message-ID: <5024AE2D.5050506@codeaurora.org> (raw)
In-Reply-To: <1343956994-27513-1-git-send-email-sboyd@codeaurora.org>

On 8/2/2012 6:23 PM, Stephen Boyd wrote:
> During the p2v changes, the PHYS_OFFSET #define moved into a
> !__ASSEMBLY__ section. This causes a XIP build to fail with
>
>  arch/arm/kernel/head.o: In function 'stext':
>  arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
>
> Momentarily leave the #ifndef __ASSEMBLY__ section so we can
> define PHYS_OFFSET for all compilation units.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> I don't know if it's worth stable, seems that nobody has compiled XIP for
> a year (back to 2.6.39 days?).

Is this approach acceptable? Shall I put this in the patch tracker?

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
Date: Thu, 09 Aug 2012 23:46:05 -0700	[thread overview]
Message-ID: <5024AE2D.5050506@codeaurora.org> (raw)
In-Reply-To: <1343956994-27513-1-git-send-email-sboyd@codeaurora.org>

On 8/2/2012 6:23 PM, Stephen Boyd wrote:
> During the p2v changes, the PHYS_OFFSET #define moved into a
> !__ASSEMBLY__ section. This causes a XIP build to fail with
>
>  arch/arm/kernel/head.o: In function 'stext':
>  arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
>
> Momentarily leave the #ifndef __ASSEMBLY__ section so we can
> define PHYS_OFFSET for all compilation units.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> I don't know if it's worth stable, seems that nobody has compiled XIP for
> a year (back to 2.6.39 days?).

Is this approach acceptable? Shall I put this in the patch tracker?

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2012-08-10  6:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03  1:23 [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving Stephen Boyd
2012-08-03  1:23 ` Stephen Boyd
2012-08-10  6:46 ` Stephen Boyd [this message]
2012-08-10  6:46   ` Stephen Boyd
2012-08-22 19:10   ` Stephen Boyd
2012-08-22 19:10     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5024AE2D.5050506@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.