* [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
@ 2012-08-03 1:23 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2012-08-03 1:23 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel
During the p2v changes, the PHYS_OFFSET #define moved into a
!__ASSEMBLY__ section. This causes a XIP build to fail with
arch/arm/kernel/head.o: In function 'stext':
arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
Momentarily leave the #ifndef __ASSEMBLY__ section so we can
define PHYS_OFFSET for all compilation units.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
I don't know if it's worth stable, seems that nobody has compiled XIP for
a year (back to 2.6.39 days?).
arch/arm/include/asm/memory.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
index fcb5757..3299b2d 100644
--- a/arch/arm/include/asm/memory.h
+++ b/arch/arm/include/asm/memory.h
@@ -187,6 +187,7 @@ static inline unsigned long __phys_to_virt(unsigned long x)
#define __phys_to_virt(x) ((x) - PHYS_OFFSET + PAGE_OFFSET)
#endif
#endif
+#endif /* __ASSEMBLY__ */
#ifndef PHYS_OFFSET
#ifdef PLAT_PHYS_OFFSET
@@ -196,6 +197,8 @@ static inline unsigned long __phys_to_virt(unsigned long x)
#endif
#endif
+#ifndef __ASSEMBLY__
+
/*
* PFNs are used to describe any physical page; this means
* PFN 0 == physical address 0.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
@ 2012-08-03 1:23 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2012-08-03 1:23 UTC (permalink / raw)
To: linux-arm-kernel
During the p2v changes, the PHYS_OFFSET #define moved into a
!__ASSEMBLY__ section. This causes a XIP build to fail with
arch/arm/kernel/head.o: In function 'stext':
arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
Momentarily leave the #ifndef __ASSEMBLY__ section so we can
define PHYS_OFFSET for all compilation units.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
I don't know if it's worth stable, seems that nobody has compiled XIP for
a year (back to 2.6.39 days?).
arch/arm/include/asm/memory.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
index fcb5757..3299b2d 100644
--- a/arch/arm/include/asm/memory.h
+++ b/arch/arm/include/asm/memory.h
@@ -187,6 +187,7 @@ static inline unsigned long __phys_to_virt(unsigned long x)
#define __phys_to_virt(x) ((x) - PHYS_OFFSET + PAGE_OFFSET)
#endif
#endif
+#endif /* __ASSEMBLY__ */
#ifndef PHYS_OFFSET
#ifdef PLAT_PHYS_OFFSET
@@ -196,6 +197,8 @@ static inline unsigned long __phys_to_virt(unsigned long x)
#endif
#endif
+#ifndef __ASSEMBLY__
+
/*
* PFNs are used to describe any physical page; this means
* PFN 0 == physical address 0.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
2012-08-03 1:23 ` Stephen Boyd
@ 2012-08-10 6:46 ` Stephen Boyd
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2012-08-10 6:46 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel
On 8/2/2012 6:23 PM, Stephen Boyd wrote:
> During the p2v changes, the PHYS_OFFSET #define moved into a
> !__ASSEMBLY__ section. This causes a XIP build to fail with
>
> arch/arm/kernel/head.o: In function 'stext':
> arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
>
> Momentarily leave the #ifndef __ASSEMBLY__ section so we can
> define PHYS_OFFSET for all compilation units.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> I don't know if it's worth stable, seems that nobody has compiled XIP for
> a year (back to 2.6.39 days?).
Is this approach acceptable? Shall I put this in the patch tracker?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
@ 2012-08-10 6:46 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2012-08-10 6:46 UTC (permalink / raw)
To: linux-arm-kernel
On 8/2/2012 6:23 PM, Stephen Boyd wrote:
> During the p2v changes, the PHYS_OFFSET #define moved into a
> !__ASSEMBLY__ section. This causes a XIP build to fail with
>
> arch/arm/kernel/head.o: In function 'stext':
> arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
>
> Momentarily leave the #ifndef __ASSEMBLY__ section so we can
> define PHYS_OFFSET for all compilation units.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> I don't know if it's worth stable, seems that nobody has compiled XIP for
> a year (back to 2.6.39 days?).
Is this approach acceptable? Shall I put this in the patch tracker?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
2012-08-10 6:46 ` Stephen Boyd
@ 2012-08-22 19:10 ` Stephen Boyd
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2012-08-22 19:10 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel
On 08/09/12 23:46, Stephen Boyd wrote:
> On 8/2/2012 6:23 PM, Stephen Boyd wrote:
>> During the p2v changes, the PHYS_OFFSET #define moved into a
>> !__ASSEMBLY__ section. This causes a XIP build to fail with
>>
>> arch/arm/kernel/head.o: In function 'stext':
>> arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
>>
>> Momentarily leave the #ifndef __ASSEMBLY__ section so we can
>> define PHYS_OFFSET for all compilation units.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>>
>> I don't know if it's worth stable, seems that nobody has compiled XIP for
>> a year (back to 2.6.39 days?).
> Is this approach acceptable? Shall I put this in the patch tracker?
>
I'll take silence to mean "yes", so I'll put this in the patch tracker
unless someone objects.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving
@ 2012-08-22 19:10 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2012-08-22 19:10 UTC (permalink / raw)
To: linux-arm-kernel
On 08/09/12 23:46, Stephen Boyd wrote:
> On 8/2/2012 6:23 PM, Stephen Boyd wrote:
>> During the p2v changes, the PHYS_OFFSET #define moved into a
>> !__ASSEMBLY__ section. This causes a XIP build to fail with
>>
>> arch/arm/kernel/head.o: In function 'stext':
>> arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
>>
>> Momentarily leave the #ifndef __ASSEMBLY__ section so we can
>> define PHYS_OFFSET for all compilation units.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>>
>> I don't know if it's worth stable, seems that nobody has compiled XIP for
>> a year (back to 2.6.39 days?).
> Is this approach acceptable? Shall I put this in the patch tracker?
>
I'll take silence to mean "yes", so I'll put this in the patch tracker
unless someone objects.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-22 19:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-03 1:23 [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving Stephen Boyd
2012-08-03 1:23 ` Stephen Boyd
2012-08-10 6:46 ` Stephen Boyd
2012-08-10 6:46 ` Stephen Boyd
2012-08-22 19:10 ` Stephen Boyd
2012-08-22 19:10 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.