* AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
@ 2012-08-09 12:46 Schmitt, Sven (EVM/8)
2012-08-09 12:56 ` Yegor Yefremov
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Schmitt, Sven (EVM/8) @ 2012-08-09 12:46 UTC (permalink / raw)
Cc: yegor_sub1, linux-can
Second try:
Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
--- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
+++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
@@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
priv = netdev_priv(dev);
dev->irq = res_irq->start;
- priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
IRQF_SHARED);
+ priv->irq_flags &= IRQF_TRIGGER_MASK;
+ if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
+ priv->irq_flags |= IRQF_SHARED;
priv->reg_base = addr;
/* The CAN clock frequency is half the oscillator clock
frequency */
priv->can.clock.freq = pdata->osc_freq / 2;
note: patch is compile tested only.
Sven
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
2012-08-09 12:46 AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing Schmitt, Sven (EVM/8)
@ 2012-08-09 12:56 ` Yegor Yefremov
2012-08-09 13:01 ` Marc Kleine-Budde
2012-08-09 13:05 ` AW: " Marc Kleine-Budde
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Yegor Yefremov @ 2012-08-09 12:56 UTC (permalink / raw)
To: Schmitt, Sven (EVM/8); +Cc: linux-can
Am 09.08.2012 14:46, schrieb Schmitt, Sven (EVM/8):
> Second try:
>
> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
>
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
> priv = netdev_priv(dev);
>
> dev->irq = res_irq->start;
> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);
> + priv->irq_flags &= IRQF_TRIGGER_MASK;
> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> + priv->irq_flags |= IRQF_SHARED;
> priv->reg_base = addr;
> /* The CAN clock frequency is half the oscillator clock
> frequency */
> priv->can.clock.freq = pdata->osc_freq / 2;
>
>
> note: patch is compile tested only.
>
> Sven
O.K. Nice catch. I just picked the wrong header file include/linux/interrupt.h, it should be include/linux/ioport.h. Now I'll have to change my board file as well.
You can add my
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
See how I manage patches with git: https://libbits.wordpress.com/2011/12/27/managing-patch-series-with-git/
Yegor
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
2012-08-09 12:56 ` Yegor Yefremov
@ 2012-08-09 13:01 ` Marc Kleine-Budde
2012-08-09 13:13 ` Yegor Yefremov
0 siblings, 1 reply; 9+ messages in thread
From: Marc Kleine-Budde @ 2012-08-09 13:01 UTC (permalink / raw)
To: yegor_sub1; +Cc: Schmitt, Sven (EVM/8), linux-can
[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]
On 08/09/2012 02:56 PM, Yegor Yefremov wrote:
> Am 09.08.2012 14:46, schrieb Schmitt, Sven (EVM/8):
>> Second try:
>>
>> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
>>
>> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
>> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
>> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
>> priv = netdev_priv(dev);
>>
>> dev->irq = res_irq->start;
>> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
>> IRQF_SHARED);
>> + priv->irq_flags &= IRQF_TRIGGER_MASK;
>> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
>> + priv->irq_flags |= IRQF_SHARED;
>> priv->reg_base = addr;
>> /* The CAN clock frequency is half the oscillator clock
>> frequency */
>> priv->can.clock.freq = pdata->osc_freq / 2;
>>
>>
>> note: patch is compile tested only.
>>
>> Sven
>
> O.K. Nice catch. I just picked the wrong header file
> include/linux/interrupt.h, it should be include/linux/ioport.h. Now
> I'll have to change my board file as well.
A quick serach showed no mainline board using shared irq, have I missed one?
> You can add my
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
You mean Acked-by?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
2012-08-09 13:01 ` Marc Kleine-Budde
@ 2012-08-09 13:13 ` Yegor Yefremov
2012-08-09 14:00 ` Marc Kleine-Budde
0 siblings, 1 reply; 9+ messages in thread
From: Yegor Yefremov @ 2012-08-09 13:13 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: Schmitt, Sven (EVM/8), linux-can
Am 09.08.2012 15:01, schrieb Marc Kleine-Budde:
> On 08/09/2012 02:56 PM, Yegor Yefremov wrote:
>> Am 09.08.2012 14:46, schrieb Schmitt, Sven (EVM/8):
>>> Second try:
>>>
>>> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
>>>
>>> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
>>> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
>>> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
>>> priv = netdev_priv(dev);
>>>
>>> dev->irq = res_irq->start;
>>> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
>>> IRQF_SHARED);
>>> + priv->irq_flags &= IRQF_TRIGGER_MASK;
>>> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
>>> + priv->irq_flags |= IRQF_SHARED;
>>> priv->reg_base = addr;
>>> /* The CAN clock frequency is half the oscillator clock
>>> frequency */
>>> priv->can.clock.freq = pdata->osc_freq / 2;
>>>
>>>
>>> note: patch is compile tested only.
>>>
>>> Sven
>> O.K. Nice catch. I just picked the wrong header file
>> include/linux/interrupt.h, it should be include/linux/ioport.h. Now
>> I'll have to change my board file as well.
> A quick serach showed no mainline board using shared irq, have I missed one?
You've missed one board in our own repos. We had to much of a custom code to try to mainline this board file.
>> You can add my
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> You mean Acked-by?
Yes.
Acked-by: Yegor Yefremov <yegorslists@googlemail.com>
Yegor
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
2012-08-09 13:13 ` Yegor Yefremov
@ 2012-08-09 14:00 ` Marc Kleine-Budde
0 siblings, 0 replies; 9+ messages in thread
From: Marc Kleine-Budde @ 2012-08-09 14:00 UTC (permalink / raw)
To: yegor_sub1; +Cc: Schmitt, Sven (EVM/8), linux-can
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
On 08/09/2012 03:13 PM, Yegor Yefremov wrote:
[...]
>>> O.K. Nice catch. I just picked the wrong header file
>>> include/linux/interrupt.h, it should be include/linux/ioport.h. Now
>>> I'll have to change my board file as well.
>> A quick serach showed no mainline board using shared irq, have I missed one?
>
> You've missed one board in our own repos. We had to much of a custom
> code to try to mainline this board file.
No mainline no breakage :)
>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> You mean Acked-by?
>
> Yes.
>
> Acked-by: Yegor Yefremov <yegorslists@googlemail.com>
Thanks, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
2012-08-09 12:46 AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing Schmitt, Sven (EVM/8)
2012-08-09 12:56 ` Yegor Yefremov
@ 2012-08-09 13:05 ` Marc Kleine-Budde
[not found] ` <1236253306.453.1344517522410.JavaMail.trustmail@VW2BWOSEVG02>
2012-08-10 8:21 ` Marc Kleine-Budde
3 siblings, 0 replies; 9+ messages in thread
From: Marc Kleine-Budde @ 2012-08-09 13:05 UTC (permalink / raw)
To: Schmitt, Sven (EVM/8); +Cc: yegor_sub1, linux-can
[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]
On 08/09/2012 02:46 PM, Schmitt, Sven (EVM/8) wrote:
> Second try:
Here should go the patch description. I'll compose a nice one from the
information form your first patch.
> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
Given that you're behind VW's firewall, I'll take care of applying the
patch by hand, as some mail clients tend to mess with line breaks.
Marc
>
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
> priv = netdev_priv(dev);
>
> dev->irq = res_irq->start;
> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);
> + priv->irq_flags &= IRQF_TRIGGER_MASK;
> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> + priv->irq_flags |= IRQF_SHARED;
> priv->reg_base = addr;
> /* The CAN clock frequency is half the oscillator clock
> frequency */
> priv->can.clock.freq = pdata->osc_freq / 2;
>
>
> note: patch is compile tested only.
>
> Sven
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread[parent not found: <1236253306.453.1344517522410.JavaMail.trustmail@VW2BWOSEVG02>]
* AW: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
[not found] ` <1236253306.453.1344517522410.JavaMail.trustmail@VW2BWOSEVG02>
@ 2012-08-09 13:23 ` Schmitt, Sven (EVM/8)
0 siblings, 0 replies; 9+ messages in thread
From: Schmitt, Sven (EVM/8) @ 2012-08-09 13:23 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: linux-can
Great. Thanks.
Sven
-----Ursprüngliche Nachricht-----
Von: linux-can-owner@vger.kernel.org [mailto:linux-can-owner@vger.kernel.org] Im Auftrag von Marc Kleine-Budde
Gesendet: Donnerstag, 9. August 2012 15:05
An: Schmitt, Sven (EVM/8)
Cc: unlisted-recipients; yegor_sub1@visionsystems.de; linux-can@vger.kernel.org
Betreff: Re: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
On 08/09/2012 02:46 PM, Schmitt, Sven (EVM/8) wrote:
> Second try:
Here should go the patch description. I'll compose a nice one from the
information form your first patch.
> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
Given that you're behind VW's firewall, I'll take care of applying the
patch by hand, as some mail clients tend to mess with line breaks.
Marc
>
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
> priv = netdev_priv(dev);
>
> dev->irq = res_irq->start;
> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);
> + priv->irq_flags &= IRQF_TRIGGER_MASK;
> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> + priv->irq_flags |= IRQF_SHARED;
> priv->reg_base = addr;
> /* The CAN clock frequency is half the oscillator clock
> frequency */
> priv->can.clock.freq = pdata->osc_freq / 2;
>
>
> note: patch is compile tested only.
>
> Sven
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
2012-08-09 12:46 AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing Schmitt, Sven (EVM/8)
` (2 preceding siblings ...)
[not found] ` <1236253306.453.1344517522410.JavaMail.trustmail@VW2BWOSEVG02>
@ 2012-08-10 8:21 ` Marc Kleine-Budde
2012-08-10 8:23 ` AW: " Schmitt, Sven (EVM/8)
3 siblings, 1 reply; 9+ messages in thread
From: Marc Kleine-Budde @ 2012-08-10 8:21 UTC (permalink / raw)
To: Schmitt, Sven (EVM/8); +Cc: yegor_sub1, linux-can
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On 08/09/2012 02:46 PM, Schmitt, Sven (EVM/8) wrote:
> Second try:
>
> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
>
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
> priv = netdev_priv(dev);
>
> dev->irq = res_irq->start;
> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);
> + priv->irq_flags &= IRQF_TRIGGER_MASK;
Should be:
priv->irq_flags = res_irq->flags & IRQF_TRIGGER_MASK;
I'm fixing this,
Marc
> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> + priv->irq_flags |= IRQF_SHARED;
> priv->reg_base = addr;
> /* The CAN clock frequency is half the oscillator clock
> frequency */
> priv->can.clock.freq = pdata->osc_freq / 2;
>
>
> note: patch is compile tested only.
>
> Sven
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* AW: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
2012-08-10 8:21 ` Marc Kleine-Budde
@ 2012-08-10 8:23 ` Schmitt, Sven (EVM/8)
0 siblings, 0 replies; 9+ messages in thread
From: Schmitt, Sven (EVM/8) @ 2012-08-10 8:23 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: yegor_sub1, linux-can
Right.
Thanks.
Sven
-----Ursprüngliche Nachricht-----
Von: Marc Kleine-Budde [mailto:mkl@pengutronix.de]
Gesendet: Freitag, 10. August 2012 10:21
An: Schmitt, Sven (EVM/8)
Cc: unlisted-recipients; yegor_sub1@visionsystems.de; linux-can@vger.kernel.org
Betreff: Re: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
On 08/09/2012 02:46 PM, Schmitt, Sven (EVM/8) wrote:
> Second try:
>
> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
>
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
> priv = netdev_priv(dev);
>
> dev->irq = res_irq->start;
> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);
> + priv->irq_flags &= IRQF_TRIGGER_MASK;
Should be:
priv->irq_flags = res_irq->flags & IRQF_TRIGGER_MASK;
I'm fixing this,
Marc
> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> + priv->irq_flags |= IRQF_SHARED;
> priv->reg_base = addr;
> /* The CAN clock frequency is half the oscillator clock
> frequency */
> priv->can.clock.freq = pdata->osc_freq / 2;
>
>
> note: patch is compile tested only.
>
> Sven
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-08-10 8:23 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-09 12:46 AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing Schmitt, Sven (EVM/8)
2012-08-09 12:56 ` Yegor Yefremov
2012-08-09 13:01 ` Marc Kleine-Budde
2012-08-09 13:13 ` Yegor Yefremov
2012-08-09 14:00 ` Marc Kleine-Budde
2012-08-09 13:05 ` AW: " Marc Kleine-Budde
[not found] ` <1236253306.453.1344517522410.JavaMail.trustmail@VW2BWOSEVG02>
2012-08-09 13:23 ` AW: " Schmitt, Sven (EVM/8)
2012-08-10 8:21 ` Marc Kleine-Budde
2012-08-10 8:23 ` AW: " Schmitt, Sven (EVM/8)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.