All of lore.kernel.org
 help / color / mirror / Atom feed
From: Asias He <asias@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Kent Overstreet <koverstreet@google.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-blk: Fix kconfig option
Date: Wed, 05 Sep 2012 13:54:07 +0800	[thread overview]
Message-ID: <5046E8FF.9020504@redhat.com> (raw)
In-Reply-To: <20120905054830.GB7517@redhat.com>

On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote:
> On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote:
>> On 09/04/2012 02:23 PM, Rusty Russell wrote:
>>> Kent Overstreet <koverstreet@google.com> writes:
>>>
>>>> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it
>>>> instead.
>>>
>>> This is a slight mis-understanding.  It's supposed to be selected by
>>> the particular driver, probably virtio_pci in your case.
>>
>> virtio_mmio selects virtio as well.
>>
>> drivers/virtio/Kconfig
>> config VIRTIO_MMIO
>>        select VIRTIO
>> config VIRTIO_PCI
>>        select VIRTIO
>>
>> How about this:
>> config VIRTIO_BLK
>>        depends on EXPERIMENTAL && (VIRTIO_PCI || VIRTIO_MMIO)
> 
> Isn't this exactly what depends on VIRTIO achieves?

Yes. But this gives the information that virtio_blk depends on one of
the virtio transport: virito_pci or virtio_mmio.

-- 
Asias

WARNING: multiple messages have this Message-ID (diff)
From: Asias He <asias@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kent Overstreet <koverstreet@google.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-blk: Fix kconfig option
Date: Wed, 05 Sep 2012 13:54:07 +0800	[thread overview]
Message-ID: <5046E8FF.9020504@redhat.com> (raw)
In-Reply-To: <20120905054830.GB7517@redhat.com>

On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote:
> On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote:
>> On 09/04/2012 02:23 PM, Rusty Russell wrote:
>>> Kent Overstreet <koverstreet@google.com> writes:
>>>
>>>> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it
>>>> instead.
>>>
>>> This is a slight mis-understanding.  It's supposed to be selected by
>>> the particular driver, probably virtio_pci in your case.
>>
>> virtio_mmio selects virtio as well.
>>
>> drivers/virtio/Kconfig
>> config VIRTIO_MMIO
>>        select VIRTIO
>> config VIRTIO_PCI
>>        select VIRTIO
>>
>> How about this:
>> config VIRTIO_BLK
>>        depends on EXPERIMENTAL && (VIRTIO_PCI || VIRTIO_MMIO)
> 
> Isn't this exactly what depends on VIRTIO achieves?

Yes. But this gives the information that virtio_blk depends on one of
the virtio transport: virito_pci or virtio_mmio.

-- 
Asias

  reply	other threads:[~2012-09-05  5:54 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03  4:41 [PATCH] virtio-blk: Fix kconfig option Kent Overstreet
2012-09-03  4:46 ` Kent Overstreet
2012-09-03  4:46 ` Kent Overstreet
2012-09-04  6:23 ` Rusty Russell
2012-09-04  6:23   ` Rusty Russell
2012-09-04 23:12   ` Kent Overstreet
2012-09-04 23:12     ` Kent Overstreet
2012-09-05  4:22   ` Asias He
2012-09-05  4:22     ` Asias He
2012-09-05  5:48     ` Michael S. Tsirkin
2012-09-05  5:48       ` Michael S. Tsirkin
2012-09-05  5:54       ` Asias He [this message]
2012-09-05  5:54         ` Asias He
2012-09-05  6:04         ` Michael S. Tsirkin
2012-09-05  6:04           ` Michael S. Tsirkin
2012-09-05  6:12   ` Michael S. Tsirkin
2012-09-05  6:12     ` Michael S. Tsirkin
2012-09-06  1:46     ` Rusty Russell
2012-09-06  1:46       ` Rusty Russell
2012-09-06  7:41   ` Kent Overstreet
2012-09-06  7:41     ` Kent Overstreet
2012-09-06  8:44     ` Michael S. Tsirkin
2012-09-06  8:44       ` Michael S. Tsirkin
2012-09-06  9:25       ` Kent Overstreet
2012-09-06  9:25         ` Kent Overstreet
2012-09-06  9:49         ` Michael S. Tsirkin
2012-09-06  9:49           ` Michael S. Tsirkin
2012-09-06 10:02           ` Kent Overstreet
2012-09-06 10:02             ` Kent Overstreet
2012-09-06 10:18             ` Michael S. Tsirkin
2012-09-06 10:18               ` Michael S. Tsirkin
2012-09-06 10:31               ` Kent Overstreet
2012-09-06 10:31                 ` Kent Overstreet
2012-09-06 11:09                 ` Michael S. Tsirkin
2012-09-06 11:09                   ` Michael S. Tsirkin
2012-09-06 23:40             ` Rusty Russell
2012-09-06 23:40               ` Rusty Russell
2012-09-07  0:25               ` Kent Overstreet
2012-09-07  0:25                 ` Kent Overstreet
2012-09-07  2:57                 ` Rusty Russell
2012-09-07  2:57                   ` Rusty Russell
2012-09-03  4:41 Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5046E8FF.9020504@redhat.com \
    --to=asias@redhat.com \
    --cc=koverstreet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.