From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Cc: Pavan Kunapuli
<pkunapuli-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: dt: tegra: Add sdhci regulators
Date: Tue, 23 Oct 2012 12:42:11 -0600 [thread overview]
Message-ID: <5086E503.8090604@wwwdotorg.org> (raw)
In-Reply-To: <4346406.Jy2o1pWcOR@ax5200p>
On 10/23/2012 12:07 PM, Marc Dietrich wrote:
> Pavan,
>
> On Tuesday 23 October 2012 12:48:59 Pavan Kunapuli wrote:
>> Adding vmmc and vmmcq supplies for sdhci nodes
>> in tegra dt files.
>
> <...>
>
>> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
>> b/arch/arm/boot/dts/tegra20-paz00.dts index 6a93d14..e161b65 100644
>> --- a/arch/arm/boot/dts/tegra20-paz00.dts
>> +++ b/arch/arm/boot/dts/tegra20-paz00.dts
>> @@ -422,13 +422,17 @@
>> status = "okay";
>> cd-gpios = <&gpio 173 0>; /* gpio PV5 */
>> wp-gpios = <&gpio 57 0>; /* gpio PH1 */
>> - power-gpios = <&gpio 169 0>; /* gpio PV1 */
>> bus-width = <4>;
>> + vmmc-supply = <&vddio_sd_reg>;
>> + vqmmc-supply = <&vddio_sd_reg>;
>> };
>>
>> sdhci@c8000600 {
>> status = "okay";
>> bus-width = <8>;
>> + vmmc-supply = <&vddio_sdmmc_reg>;
>> + vqmmc-supply = <&vddio_sdmmc_reg>;
>
> to make it better, this should be:
>
> vmmc-supply = <&vcore_mmc_reg>; and
> vqmmc-supply = <&vddio_nand_reg>;
>
> with vcore_mmc_reg is ldo5 and vddio_nand_reg is the fixed regulator below.
I think for the eMMC (not SD card), the core supply is actually +3vs_s3,
and hence fixed; it looks like LDO5 used to be used, but they changed
it. See the note for the VCC connections on the eMMC chip.
> By doing so, I get "sdhci-tegra sdhci-tegra.3: could not set regulator OCR
> (-1)". MMC subsys wants to set ldo5 to 3.3V but it is fixed. I guess that's
> harmless for now.
What I mention above might end up fixing that?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Marc Dietrich <marvin24@gmx.de>
Cc: Pavan Kunapuli <pkunapuli@nvidia.com>,
linux@arm.linux.org.uk, cjb@laptop.org,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dt: tegra: Add sdhci regulators
Date: Tue, 23 Oct 2012 12:42:11 -0600 [thread overview]
Message-ID: <5086E503.8090604@wwwdotorg.org> (raw)
In-Reply-To: <4346406.Jy2o1pWcOR@ax5200p>
On 10/23/2012 12:07 PM, Marc Dietrich wrote:
> Pavan,
>
> On Tuesday 23 October 2012 12:48:59 Pavan Kunapuli wrote:
>> Adding vmmc and vmmcq supplies for sdhci nodes
>> in tegra dt files.
>
> <...>
>
>> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
>> b/arch/arm/boot/dts/tegra20-paz00.dts index 6a93d14..e161b65 100644
>> --- a/arch/arm/boot/dts/tegra20-paz00.dts
>> +++ b/arch/arm/boot/dts/tegra20-paz00.dts
>> @@ -422,13 +422,17 @@
>> status = "okay";
>> cd-gpios = <&gpio 173 0>; /* gpio PV5 */
>> wp-gpios = <&gpio 57 0>; /* gpio PH1 */
>> - power-gpios = <&gpio 169 0>; /* gpio PV1 */
>> bus-width = <4>;
>> + vmmc-supply = <&vddio_sd_reg>;
>> + vqmmc-supply = <&vddio_sd_reg>;
>> };
>>
>> sdhci@c8000600 {
>> status = "okay";
>> bus-width = <8>;
>> + vmmc-supply = <&vddio_sdmmc_reg>;
>> + vqmmc-supply = <&vddio_sdmmc_reg>;
>
> to make it better, this should be:
>
> vmmc-supply = <&vcore_mmc_reg>; and
> vqmmc-supply = <&vddio_nand_reg>;
>
> with vcore_mmc_reg is ldo5 and vddio_nand_reg is the fixed regulator below.
I think for the eMMC (not SD card), the core supply is actually +3vs_s3,
and hence fixed; it looks like LDO5 used to be used, but they changed
it. See the note for the VCC connections on the eMMC chip.
> By doing so, I get "sdhci-tegra sdhci-tegra.3: could not set regulator OCR
> (-1)". MMC subsys wants to set ldo5 to 3.3V but it is fixed. I guess that's
> harmless for now.
What I mention above might end up fixing that?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dt: tegra: Add sdhci regulators
Date: Tue, 23 Oct 2012 12:42:11 -0600 [thread overview]
Message-ID: <5086E503.8090604@wwwdotorg.org> (raw)
In-Reply-To: <4346406.Jy2o1pWcOR@ax5200p>
On 10/23/2012 12:07 PM, Marc Dietrich wrote:
> Pavan,
>
> On Tuesday 23 October 2012 12:48:59 Pavan Kunapuli wrote:
>> Adding vmmc and vmmcq supplies for sdhci nodes
>> in tegra dt files.
>
> <...>
>
>> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
>> b/arch/arm/boot/dts/tegra20-paz00.dts index 6a93d14..e161b65 100644
>> --- a/arch/arm/boot/dts/tegra20-paz00.dts
>> +++ b/arch/arm/boot/dts/tegra20-paz00.dts
>> @@ -422,13 +422,17 @@
>> status = "okay";
>> cd-gpios = <&gpio 173 0>; /* gpio PV5 */
>> wp-gpios = <&gpio 57 0>; /* gpio PH1 */
>> - power-gpios = <&gpio 169 0>; /* gpio PV1 */
>> bus-width = <4>;
>> + vmmc-supply = <&vddio_sd_reg>;
>> + vqmmc-supply = <&vddio_sd_reg>;
>> };
>>
>> sdhci at c8000600 {
>> status = "okay";
>> bus-width = <8>;
>> + vmmc-supply = <&vddio_sdmmc_reg>;
>> + vqmmc-supply = <&vddio_sdmmc_reg>;
>
> to make it better, this should be:
>
> vmmc-supply = <&vcore_mmc_reg>; and
> vqmmc-supply = <&vddio_nand_reg>;
>
> with vcore_mmc_reg is ldo5 and vddio_nand_reg is the fixed regulator below.
I think for the eMMC (not SD card), the core supply is actually +3vs_s3,
and hence fixed; it looks like LDO5 used to be used, but they changed
it. See the note for the VCC connections on the eMMC chip.
> By doing so, I get "sdhci-tegra sdhci-tegra.3: could not set regulator OCR
> (-1)". MMC subsys wants to set ldo5 to 3.3V but it is fixed. I guess that's
> harmless for now.
What I mention above might end up fixing that?
next prev parent reply other threads:[~2012-10-23 18:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 7:18 [PATCH 0/2] mmc: sdhci: Defer probe if regulators are not registered Pavan Kunapuli
2012-10-23 7:18 ` Pavan Kunapuli
2012-10-23 7:18 ` Pavan Kunapuli
2012-10-23 7:18 ` [PATCH 1/2] ARM: dt: tegra: Add sdhci regulators Pavan Kunapuli
2012-10-23 7:18 ` Pavan Kunapuli
2012-10-23 7:18 ` Pavan Kunapuli
[not found] ` <1350976740-19284-2-git-send-email-pkunapuli-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-23 18:07 ` Marc Dietrich
2012-10-23 18:07 ` Marc Dietrich
2012-10-23 18:07 ` Marc Dietrich
2012-10-23 18:42 ` Stephen Warren [this message]
2012-10-23 18:42 ` Stephen Warren
2012-10-23 18:42 ` Stephen Warren
[not found] ` <5086E503.8090604-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-23 19:41 ` Marc Dietrich
2012-10-23 19:41 ` Marc Dietrich
2012-10-23 19:41 ` Marc Dietrich
2012-10-23 7:19 ` [PATCH 2/2] mmc: sdhci: Defer probe if regulator_get fails Pavan Kunapuli
2012-10-23 7:19 ` Pavan Kunapuli
2012-10-23 7:19 ` Pavan Kunapuli
2012-10-23 7:57 ` Lucas Stach
2012-10-23 7:57 ` Lucas Stach
2012-10-23 7:57 ` Lucas Stach
2012-10-23 8:16 ` Pavan Kunapuli
2012-10-23 8:16 ` Pavan Kunapuli
2012-10-23 8:16 ` Pavan Kunapuli
2012-10-23 16:29 ` Stephen Warren
2012-10-23 16:29 ` Stephen Warren
2012-10-23 16:29 ` Stephen Warren
2012-10-23 17:07 ` Mark Brown
2012-10-23 17:07 ` Mark Brown
[not found] ` <1350976740-19284-3-git-send-email-pkunapuli-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-23 13:21 ` Philip Rakity
2012-10-23 13:21 ` Philip Rakity
2012-10-23 13:21 ` Philip Rakity
[not found] ` <4F1DF342-A2C4-434A-B878-A11374089E6E-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-23 13:36 ` Russell King - ARM Linux
2012-10-23 13:36 ` Russell King - ARM Linux
2012-10-23 13:36 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2012-10-23 7:18 [PATCH 0/2] mmc: sdhci: Defer probe if regulators are not registered Pavan Kunapuli
2012-10-23 7:18 ` [PATCH 1/2] ARM: dt: tegra: Add sdhci regulators Pavan Kunapuli
2012-10-23 7:18 ` Pavan Kunapuli
2012-10-23 16:21 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086E503.8090604@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=pkunapuli-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.