From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Liu Ping Fan <pingfank@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
liu ping fan <qemulist@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [patch v4 12/16] e1000: apply fine lock on e1000
Date: Thu, 25 Oct 2012 19:03:39 +0200 [thread overview]
Message-ID: <508970EB.7080901@redhat.com> (raw)
In-Reply-To: <50896BA0.9000400@siemens.com>
On 10/25/2012 06:41 PM, Jan Kiszka wrote:
> On 2012-10-25 18:23, Avi Kivity wrote:
>> On 10/25/2012 03:34 PM, Jan Kiszka wrote:
>>
>>>>> Second, it clearly shows that we need to address lock-less IRQ delivery.
>>>>> Almost nothing is won if we have to take the global lock again to push
>>>>> an IRQ event to the guest. I'm repeating myself, but the problem to be
>>>>> solved here is almost identical to fast IRQ delivery for assigned
>>>>> devices (which we only address pretty ad-hoc for PCI so far).
>>>>>
>>>> Interesting, could you show me more detail about it, so I can google...
>>>
>>> No need to look that far, just grep for pci_device_route_intx_to_irq,
>>> pci_device_set_intx_routing_notifier and related functions in the code.
>>
>> We can address it in the same way the memory core supports concurrency,
>> by copying dispatch information into rcu or lock protected data structures.
>>
>> But I really hope we can avoid doing it now.
>
> I doubt so as the alternative is taking the BQL while (still) holding
> the device lock.
Sorry, doesn't parse.
> But that creates ABBA risks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-10-25 17:04 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 9:23 [Qemu-devel] [patch v4 00/16] push mmio dispatch out of big lock Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 01/16] atomic: introduce atomic operations Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 02/16] qom: apply atomic on object's refcount Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 03/16] hotplug: introduce qdev_unplug_complete() to remove device from views Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 04/16] pci: remove pci device from mem view when unplug Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps Liu Ping Fan
2012-10-22 9:38 ` Avi Kivity
2012-10-23 11:51 ` Paolo Bonzini
2012-10-23 11:55 ` Avi Kivity
2012-10-23 11:57 ` Paolo Bonzini
2012-10-23 12:02 ` Avi Kivity
2012-10-23 12:06 ` Paolo Bonzini
2012-10-23 12:15 ` Avi Kivity
2012-10-23 12:32 ` Paolo Bonzini
2012-10-23 14:49 ` Avi Kivity
2012-10-23 15:26 ` Paolo Bonzini
2012-10-23 16:09 ` Avi Kivity
2012-10-24 7:29 ` Paolo Bonzini
2012-10-25 16:28 ` Avi Kivity
2012-10-26 15:05 ` Paolo Bonzini
2012-10-23 12:04 ` Jan Kiszka
2012-10-23 12:12 ` Paolo Bonzini
2012-10-23 12:16 ` Jan Kiszka
2012-10-23 12:28 ` Avi Kivity
2012-10-23 12:40 ` Jan Kiszka
2012-10-23 14:37 ` Avi Kivity
2012-10-22 9:23 ` [Qemu-devel] [patch v4 06/16] memory: document ref, unref interface Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 07/16] memory: make mmio dispatch able to be out of biglock Liu Ping Fan
2012-10-23 12:12 ` Jan Kiszka
2012-10-23 12:36 ` Avi Kivity
2012-10-24 6:31 ` liu ping fan
2012-10-24 6:56 ` liu ping fan
2012-10-25 8:57 ` Avi Kivity
2012-10-22 9:23 ` [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info Liu Ping Fan
2012-10-22 9:30 ` Jan Kiszka
2012-10-22 17:13 ` Peter Maydell
2012-10-23 5:58 ` liu ping fan
2012-10-23 11:48 ` Paolo Bonzini
2012-10-23 11:50 ` Peter Maydell
2012-10-23 11:51 ` Jan Kiszka
2012-10-23 12:00 ` Paolo Bonzini
2012-10-23 12:27 ` Peter Maydell
2012-11-18 10:02 ` Brad Smith
2012-11-18 16:14 ` Paolo Bonzini
2012-11-18 16:15 ` Paolo Bonzini
2012-10-22 9:23 ` [Qemu-devel] [patch v4 09/16] memory: introduce mmio request pending to anti nested DMA Liu Ping Fan
2012-10-22 10:28 ` Avi Kivity
2012-10-23 12:38 ` Gleb Natapov
2012-10-24 6:31 ` liu ping fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 10/16] memory: introduce lock ops for MemoryRegionOps Liu Ping Fan
2012-10-22 10:30 ` Avi Kivity
2012-10-23 5:53 ` liu ping fan
2012-10-23 8:53 ` Jan Kiszka
2012-10-22 9:23 ` [Qemu-devel] [patch v4 11/16] vcpu: push mmio dispatcher out of big lock Liu Ping Fan
2012-10-22 10:31 ` Avi Kivity
2012-10-22 10:36 ` Jan Kiszka
2012-10-22 9:23 ` [Qemu-devel] [patch v4 12/16] e1000: apply fine lock on e1000 Liu Ping Fan
2012-10-22 10:37 ` Avi Kivity
2012-10-23 9:04 ` Jan Kiszka
2012-10-24 6:31 ` liu ping fan
2012-10-24 7:17 ` Jan Kiszka
2012-10-25 9:01 ` Avi Kivity
2012-10-25 9:31 ` Jan Kiszka
2012-10-25 16:21 ` Avi Kivity
2012-10-25 16:39 ` Jan Kiszka
2012-10-25 17:02 ` Avi Kivity
2012-10-25 18:48 ` Jan Kiszka
2012-10-29 5:24 ` liu ping fan
2012-10-24 7:29 ` liu ping fan
2012-10-25 13:34 ` Jan Kiszka
2012-10-25 16:23 ` Avi Kivity
2012-10-25 16:41 ` Jan Kiszka
2012-10-25 17:03 ` Avi Kivity [this message]
2012-10-29 5:24 ` liu ping fan
2012-10-31 7:03 ` Jan Kiszka
2012-10-22 9:23 ` [Qemu-devel] [patch v4 13/16] e1000: add busy flag to anti broken device state Liu Ping Fan
2012-10-22 10:40 ` Avi Kivity
2012-10-23 5:52 ` liu ping fan
2012-10-23 9:06 ` Avi Kivity
2012-10-23 9:07 ` Jan Kiszka
2012-10-23 9:32 ` liu ping fan
2012-10-23 9:37 ` Avi Kivity
2012-10-24 6:36 ` liu ping fan
2012-10-25 8:55 ` Avi Kivity
2012-10-25 9:00 ` Peter Maydell
2012-10-25 9:04 ` Avi Kivity
2012-10-26 3:05 ` liu ping fan
2012-10-26 3:08 ` liu ping fan
2012-10-26 10:25 ` Jan Kiszka
2012-10-29 5:24 ` liu ping fan
2012-10-29 7:50 ` Peter Maydell
2012-10-22 9:23 ` [Qemu-devel] [patch v4 14/16] qdev: introduce stopping state Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 15/16] e1000: introduce unmap() to fix unplug issue Liu Ping Fan
2012-10-22 9:23 ` [Qemu-devel] [patch v4 16/16] e1000: implement MemoryRegionOps's ref&lock interface Liu Ping Fan
2012-10-25 14:04 ` [Qemu-devel] [patch v4 00/16] push mmio dispatch out of big lock Peter Maydell
2012-10-25 16:44 ` Jan Kiszka
2012-10-25 17:07 ` Avi Kivity
2012-10-25 17:13 ` Peter Maydell
2012-10-25 18:13 ` Marcelo Tosatti
2012-10-25 19:00 ` Jan Kiszka
2012-10-25 19:06 ` Peter Maydell
2012-10-29 15:24 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508970EB.7080901@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.