* [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn
@ 2020-01-02 13:56 Andrew Cooper
2020-01-02 16:46 ` Wei Liu
2020-01-03 17:14 ` Julien Grall
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Cooper @ 2020-01-02 13:56 UTC (permalink / raw)
To: Xen-devel
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Andrew Cooper,
Jan Beulich, Volodymyr Babchuk, Roger Pau Monné
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
---
xen/arch/arm/efi/efi-boot.h | 2 +-
xen/arch/x86/efi/efi-boot.h | 2 +-
xen/common/efi/boot.c | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index ca655ff003..d7bf934077 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -367,7 +367,7 @@ static void __init efi_arch_pre_exit_boot(void)
{
}
-static void __init efi_arch_post_exit_boot(void)
+static void __init noreturn efi_arch_post_exit_boot(void)
{
efi_xen_start(fdt, fdt_totalsize(fdt));
}
diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
index 232972eedf..676d616ff8 100644
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -268,7 +268,7 @@ static void __init noreturn efi_arch_post_exit_boot(void)
[stkoff] "i" (STACK_SIZE - sizeof(struct cpu_info)),
"D" (&mbi)
: "memory" );
- for( ; ; ); /* not reached */
+ unreachable();
}
static void __init efi_arch_cfg_file_early(EFI_FILE_HANDLE dir_handle, char *section)
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 3f1c330afe..1b7dc16056 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1402,7 +1402,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
efi_exit_boot(ImageHandle, SystemTable);
efi_arch_post_exit_boot();
- for( ; ; ); /* not reached */
}
#ifndef CONFIG_ARM /* TODO - runtime service support */
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn
2020-01-02 13:56 [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn Andrew Cooper
@ 2020-01-02 16:46 ` Wei Liu
2020-01-03 13:24 ` Jan Beulich
2020-01-03 17:14 ` Julien Grall
1 sibling, 1 reply; 4+ messages in thread
From: Wei Liu @ 2020-01-02 16:46 UTC (permalink / raw)
To: Andrew Cooper
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Jan Beulich,
Xen-devel, Volodymyr Babchuk, Roger Pau Monné
On Thu, Jan 02, 2020 at 01:56:24PM +0000, Andrew Cooper wrote:
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wl@xen.org>
Preferably with one additional adjustment below.
>
> static void __init efi_arch_cfg_file_early(EFI_FILE_HANDLE dir_handle, char *section)
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index 3f1c330afe..1b7dc16056 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -1402,7 +1402,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
> efi_exit_boot(ImageHandle, SystemTable);
>
efi_arch_post_exit_boot(); /* never returns */
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn
2020-01-02 16:46 ` Wei Liu
@ 2020-01-03 13:24 ` Jan Beulich
0 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2020-01-03 13:24 UTC (permalink / raw)
To: Andrew Cooper
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Xen-devel,
Volodymyr Babchuk, Roger Pau Monné
On 02.01.2020 17:46, Wei Liu wrote:
> On Thu, Jan 02, 2020 at 01:56:24PM +0000, Andrew Cooper wrote:
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Reviewed-by: Wei Liu <wl@xen.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn
2020-01-02 13:56 [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn Andrew Cooper
2020-01-02 16:46 ` Wei Liu
@ 2020-01-03 17:14 ` Julien Grall
1 sibling, 0 replies; 4+ messages in thread
From: Julien Grall @ 2020-01-03 17:14 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel
Cc: Stefano Stabellini, Volodymyr Babchuk, Wei Liu, Jan Beulich,
Roger Pau Monné
Hi Andrew,
On 02/01/2020 13:56, Andrew Cooper wrote:
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Julien Grall <julien@xen.org>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-03 17:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-02 13:56 [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn Andrew Cooper
2020-01-02 16:46 ` Wei Liu
2020-01-03 13:24 ` Jan Beulich
2020-01-03 17:14 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.