All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Ike Pan <ike.pan-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	John Stultz <johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	David Marlin <dmarlin-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Yehuda Yitschak <yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Jani Monoses
	<jani.monoses-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Dan Frazier
	<dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	Eran Ben-Avi <benavi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Leif Lindholm <leif.lindholm-5wv7dgnIgG8@public.gmane.org>,
	Sebastian Hesselbarth
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Chris Van Hoof <vanhoof-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	Jon Masters <jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Maen Suleiman <maen-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Shadi Ammouri <shadi@marvell>
Subject: Re: [PATCH 1/6] arm: mvebu: Add support for local interrupt
Date: Mon, 21 Jan 2013 23:07:10 +0100	[thread overview]
Message-ID: <50FDBC0E.1030706@free-electrons.com> (raw)
In-Reply-To: <20130121191744.0a04b941@skate>

On 01/21/2013 07:17 PM, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> Just some minor nitpicks below.

OK I will take them into account for the V2.

Thanks

> 
> On Mon, 21 Jan 2013 18:53:57 +0100, Gregory CLEMENT wrote:
> 
>> +	if (hw < ARMADA_370_XP_MAX_PER_CPU_IRQS) {
>> +
> 
> Unneeded empty line.
> 
>> +		irq_set_percpu_devid(virq);
>> +		irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>> +					handle_percpu_devid_irq);
>> +
>> +	} else {
>> +		irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>> +					handle_level_irq);
>> +	}
> 
> Braces useless since there is only one statement in the else.
> 
>> +		set_irq_flags(virq, IRQF_VALID | IRQF_PROBE);
> 
> Incorrect indentation for this line.
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] arm: mvebu: Add support for local interrupt
Date: Mon, 21 Jan 2013 23:07:10 +0100	[thread overview]
Message-ID: <50FDBC0E.1030706@free-electrons.com> (raw)
In-Reply-To: <20130121191744.0a04b941@skate>

On 01/21/2013 07:17 PM, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> Just some minor nitpicks below.

OK I will take them into account for the V2.

Thanks

> 
> On Mon, 21 Jan 2013 18:53:57 +0100, Gregory CLEMENT wrote:
> 
>> +	if (hw < ARMADA_370_XP_MAX_PER_CPU_IRQS) {
>> +
> 
> Unneeded empty line.
> 
>> +		irq_set_percpu_devid(virq);
>> +		irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>> +					handle_percpu_devid_irq);
>> +
>> +	} else {
>> +		irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>> +					handle_level_irq);
>> +	}
> 
> Braces useless since there is only one statement in the else.
> 
>> +		set_irq_flags(virq, IRQF_VALID | IRQF_PROBE);
> 
> Incorrect indentation for this line.
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-01-21 22:07 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 17:53 [PATCH 0/6] arm: mvebu: add support for local timer for Armada 370/XP Gregory CLEMENT
2013-01-21 17:53 ` Gregory CLEMENT
2013-01-21 17:53 ` [PATCH 1/6] arm: mvebu: Add support for local interrupt Gregory CLEMENT
2013-01-21 17:53   ` Gregory CLEMENT
2013-01-21 17:53   ` Gregory CLEMENT
     [not found]   ` <1358790842-2986-2-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-01-21 18:17     ` Thomas Petazzoni
2013-01-21 18:17       ` Thomas Petazzoni
2013-01-21 22:07       ` Gregory CLEMENT [this message]
2013-01-21 22:07         ` Gregory CLEMENT
     [not found]         ` <50FDBC0E.1030706-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-01-21 23:26           ` Ezequiel Garcia
2013-01-21 23:26             ` Ezequiel Garcia
2013-01-22  9:09             ` Gregory CLEMENT
2013-01-22  9:09               ` Gregory CLEMENT
     [not found]               ` <50FE572F.4090402-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-01-22 16:55                 ` Thomas Petazzoni
2013-01-22 16:55                   ` Thomas Petazzoni
2013-01-21 17:53 ` [PATCH 2/6] clocksource: time-armada-370-xp: add local timer support Gregory CLEMENT
2013-01-21 17:53   ` Gregory CLEMENT
2013-01-21 17:53   ` Gregory CLEMENT
     [not found]   ` <1358790842-2986-3-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-01-21 17:59     ` Russell King - ARM Linux
2013-01-21 17:59       ` Russell King - ARM Linux
     [not found]       ` <20130121175927.GV23505-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2013-01-21 18:04         ` Gregory CLEMENT
2013-01-21 18:04           ` Gregory CLEMENT
2013-01-23 13:11     ` Gregory CLEMENT
2013-01-23 13:11       ` Gregory CLEMENT
2013-01-21 17:53 ` [PATCH 3/6] arm: kconfig: don't select TWD with local timer for Armada 370/XP Gregory CLEMENT
2013-01-21 17:53   ` Gregory CLEMENT
2013-01-21 18:31   ` Arnd Bergmann
2013-01-21 18:31     ` Arnd Bergmann
     [not found]     ` <201301211831.45947.arnd-r2nGTMty4D4@public.gmane.org>
2013-01-21 19:29       ` Matt Sealey
2013-01-21 19:29         ` Matt Sealey
2013-01-21 20:44         ` Arnd Bergmann
2013-01-21 20:44           ` Arnd Bergmann
     [not found]           ` <201301212044.41865.arnd-r2nGTMty4D4@public.gmane.org>
2013-01-22 17:12             ` Russell King - ARM Linux
2013-01-22 17:12               ` Russell King - ARM Linux
2013-01-22 20:46           ` Rob Herring
2013-01-22 20:46             ` Rob Herring
2013-01-22 20:46             ` Rob Herring
2013-01-22 21:19             ` Arnd Bergmann
2013-01-22 21:19               ` Arnd Bergmann
2013-01-22 21:19               ` Arnd Bergmann
2013-01-21 22:37       ` Gregory CLEMENT
2013-01-21 22:37         ` Gregory CLEMENT
2013-01-22 15:57         ` Arnd Bergmann
2013-01-22 15:57           ` Arnd Bergmann
     [not found]           ` <201301221557.02976.arnd-r2nGTMty4D4@public.gmane.org>
2013-01-22 16:34             ` Gregory CLEMENT
2013-01-22 16:34               ` Gregory CLEMENT
2013-01-22 17:42               ` [PATCH] arm: kconfig: always select TWD with local timer for multiplatform Gregory CLEMENT
2013-01-22 17:18             ` [PATCH 3/6] arm: kconfig: don't select TWD with local timer for Armada 370/XP Russell King - ARM Linux
2013-01-22 17:18               ` Russell King - ARM Linux
     [not found]               ` <20130122171817.GM23505-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2013-01-22 17:42                 ` Arnd Bergmann
2013-01-22 17:42                   ` Arnd Bergmann
2013-01-21 17:54 ` [PATCH 4/6] arm: mvebu: update defconfig with local timer support Gregory CLEMENT
2013-01-21 17:54   ` Gregory CLEMENT
2013-01-21 17:54   ` Gregory CLEMENT
2013-01-21 17:54 ` [PATCH 5/6] arm: mvebu: update DT to support local timers Gregory CLEMENT
2013-01-21 17:54   ` Gregory CLEMENT
2013-01-21 17:54 ` [PATCH 6/6] clocksource: update and move armada-370-xp-timer documentation to timer directory Gregory CLEMENT
2013-01-21 17:54   ` Gregory CLEMENT
     [not found]   ` <1358790842-2986-7-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-01-21 18:22     ` Arnd Bergmann
2013-01-21 18:22       ` Arnd Bergmann
     [not found]       ` <201301211822.54129.arnd-r2nGTMty4D4@public.gmane.org>
2013-01-21 22:05         ` Gregory CLEMENT
2013-01-21 22:05           ` Gregory CLEMENT
     [not found]           ` <50FDBBB9.8090504-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-01-21 22:26             ` Arnd Bergmann
2013-01-21 22:26               ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FDBC0E.1030706@free-electrons.com \
    --to=gregory.clement-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=andrew-g2DYL2Zd6BY@public.gmane.org \
    --cc=benavi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=dmarlin-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ike.pan-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=jani.monoses-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=leif.lindholm-5wv7dgnIgG8@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=maen-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=shadi@marvell \
    --cc=tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=vanhoof-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.