From: Boris Ostrovsky <boris.ostrovsky@amd.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Borislav Petkov <bp@alien8.de>,
Stefan Bader <stefan.bader@canonical.com>,
Andre Przywara <andre@andrep.de>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [Xen-devel] kernel 3.7+ cpufreq regression on AMD system running as dom0
Date: Mon, 21 Jan 2013 19:01:53 -0500 [thread overview]
Message-ID: <50FDD6F1.5030208@amd.com> (raw)
In-Reply-To: <20130118190015.GC11351@phenom.dumpdata.com>
On 01/18/2013 02:00 PM, Konrad Rzeszutek Wilk wrote:
>
> So something like this in the hypervisor maybe (not even tested):
>
> diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c
> index a9b7792..54e7808 100644
> --- a/xen/arch/x86/acpi/cpufreq/powernow.c
> +++ b/xen/arch/x86/acpi/cpufreq/powernow.c
> @@ -146,7 +146,40 @@ static int powernow_cpufreq_target(struct cpufreq_policy *policy,
>
> return 0;
> }
> +#define MSR_AMD_PSTATE_DEF_BASE 0xc0010064
> +static void amd_fixup_frequency(struct xen_processor_px *px, int i)
> +{
> + u32 hi, lo, fid, did;
> + int index = px->control & 0x00000007;
> +
> + if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
> + return;
> +
> + if ((boot_cpu_data.x86 == 0x10 && boot_cpu_data.x86_model < 10)
> + || boot_cpu_data.x86 == 0x11) {
> + rdmsr(MSR_AMD_PSTATE_DEF_BASE + index, lo, hi);
> + /* Bit 63 indicates whether contents are valid */
> + if (!(hi & 0x80000000))
> + return;
> +
> + fid = lo & 0x3f;
> + did = (lo >> 6) & 7;
> + if (boot_cpu_data.x86 == 0x10)
> + px->core_frequency = (100 * (fid + 0x10)) >> did;
> + else
> + px->core_frequency = (100 * (fid + 8)) >> did;
> + }
> +}
> +
> +static void amd_fixup_freq(struct processor_performance *perf)
> +{
>
> + int i;
> +
> + for (i = 0; i < perf->state_count; i++)
> + amd_fixup_frequency(perf->states, i);
amd_fixup_frequency(&perf->states[i]) will walk P-states.
> +
> +}
> static int powernow_cpufreq_verify(struct cpufreq_policy *policy)
> {
> struct acpi_cpufreq_data *data;
> @@ -158,6 +191,8 @@ static int powernow_cpufreq_verify(struct cpufreq_policy *policy)
>
> perf = &processor_pminfo[policy->cpu]->perf;
>
> + amd_fixup_freq(perf);
Maybe move to powernow_cpufreq_cpu_init(), although this works too.
-boris
> +
> cpufreq_verify_within_limits(policy, 0,
> perf->states[perf->platform_limit].core_frequency * 1000);
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
next prev parent reply other threads:[~2013-01-22 0:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 15:58 kernel 3.7+ cpufreq regression on AMD system running as dom0 Stefan Bader
2013-01-14 16:34 ` Borislav Petkov
2013-01-14 16:55 ` [Xen-devel] " Jan Beulich
2013-01-14 17:08 ` Stefan Bader
2013-01-14 17:40 ` André Przywara
2013-01-14 17:40 ` André Przywara
2013-01-15 17:53 ` Konrad Rzeszutek Wilk
2013-01-15 18:18 ` Borislav Petkov
2013-01-18 19:00 ` Konrad Rzeszutek Wilk
2013-01-18 19:38 ` [Xen-devel] " Boris Ostrovsky
2013-01-18 19:44 ` Andrew Cooper
2013-01-18 20:03 ` Borislav Petkov
2013-01-18 22:00 ` Konrad Rzeszutek Wilk
2013-01-21 12:22 ` Stefan Bader
2013-01-21 12:42 ` Borislav Petkov
2013-01-21 12:53 ` Rafael J. Wysocki
2013-01-21 13:08 ` Borislav Petkov
2013-01-21 13:11 ` Stefan Bader
2013-01-21 15:03 ` Stefan Bader
2013-01-21 15:31 ` Borislav Petkov
2013-01-22 13:54 ` Rafael J. Wysocki
2013-01-22 0:01 ` Boris Ostrovsky [this message]
2013-01-16 10:26 ` [Xen-devel] " Jan Beulich
2013-01-16 14:34 ` Stefan Bader
2013-01-16 14:34 ` [Xen-devel] " Stefan Bader
2013-01-16 10:26 ` Jan Beulich
2013-01-15 13:04 ` Matt Wilson
2013-01-15 17:59 ` [Xen-devel] " Matt Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FDD6F1.5030208@amd.com \
--to=boris.ostrovsky@amd.com \
--cc=andre@andrep.de \
--cc=bp@alien8.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
--cc=stefan.bader@canonical.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.