From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: masaki.ota@jp.alps.com, jikos@kernel.org, benjamin.tissoires@redhat.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> Subject: [PATCH 4/4] HID: alps: Fix some style in 't4_read_write_register()' Date: Mon, 19 Mar 2018 21:53:29 +0100 [thread overview] Message-ID: <50b54e595830cc86edfb977e045f5a7b2b1b726a.1521492069.git.christophe.jaillet@wanadoo.fr> (raw) In-Reply-To: <cover.1521492069.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <cover.1521492069.git.christophe.jaillet@wanadoo.fr> Better indent the code to improve readability. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/hid/hid-alps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 137b963779c6..60d3950692d9 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -223,20 +223,20 @@ static int t4_read_write_register(struct hid_device *hdev, u32 address, if (*(u32 *)&readbuf[6] != address) { dev_err(&hdev->dev, "read register address error (%x,%x)\n", - *(u32 *)&readbuf[6], address); + *(u32 *)&readbuf[6], address); goto exit_readbuf; } if (*(u16 *)&readbuf[10] != 1) { dev_err(&hdev->dev, "read register size error (%x)\n", - *(u16 *)&readbuf[10]); + *(u16 *)&readbuf[10]); goto exit_readbuf; } check_sum = t4_calc_check_sum(readbuf, 6, 7); if (*(u16 *)&readbuf[13] != check_sum) { dev_err(&hdev->dev, "read register checksum error (%x,%x)\n", - *(u16 *)&readbuf[13], check_sum); + *(u16 *)&readbuf[13], check_sum); goto exit_readbuf; } -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: masaki.ota@jp.alps.com, jikos@kernel.org, benjamin.tissoires@redhat.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> Subject: [PATCH 4/4] HID: alps: Fix some style in 't4_read_write_register()' Date: Mon, 19 Mar 2018 20:53:29 +0000 [thread overview] Message-ID: <50b54e595830cc86edfb977e045f5a7b2b1b726a.1521492069.git.christophe.jaillet@wanadoo.fr> (raw) In-Reply-To: <cover.1521492069.git.christophe.jaillet@wanadoo.fr> Better indent the code to improve readability. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/hid/hid-alps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 137b963779c6..60d3950692d9 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -223,20 +223,20 @@ static int t4_read_write_register(struct hid_device *hdev, u32 address, if (*(u32 *)&readbuf[6] != address) { dev_err(&hdev->dev, "read register address error (%x,%x)\n", - *(u32 *)&readbuf[6], address); + *(u32 *)&readbuf[6], address); goto exit_readbuf; } if (*(u16 *)&readbuf[10] != 1) { dev_err(&hdev->dev, "read register size error (%x)\n", - *(u16 *)&readbuf[10]); + *(u16 *)&readbuf[10]); goto exit_readbuf; } check_sum = t4_calc_check_sum(readbuf, 6, 7); if (*(u16 *)&readbuf[13] != check_sum) { dev_err(&hdev->dev, "read register checksum error (%x,%x)\n", - *(u16 *)&readbuf[13], check_sum); + *(u16 *)&readbuf[13], check_sum); goto exit_readbuf; } -- 2.14.1
next prev parent reply other threads:[~2018-03-19 20:54 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-19 20:53 [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()' Christophe JAILLET 2018-03-19 20:53 ` Christophe JAILLET 2018-03-19 20:53 ` [PATCH 1/4] HID: alps: Report an error if we receive invalid data in 't4_read_write_register()' Christophe JAILLET 2018-03-19 20:53 ` Christophe JAILLET 2018-03-19 20:53 ` [PATCH 2/4] HID: alps: Save a memory allocation in 't4_read_write_register()' when writing data Christophe JAILLET 2018-03-19 20:53 ` Christophe JAILLET 2018-03-19 20:53 ` [PATCH 3/4] HID: alps: Check errors returned by 't4_read_write_register()' Christophe JAILLET 2018-03-19 20:53 ` Christophe JAILLET 2018-03-19 20:53 ` Christophe JAILLET [this message] 2018-03-19 20:53 ` [PATCH 4/4] HID: alps: Fix some style in 't4_read_write_register()' Christophe JAILLET 2018-03-27 12:05 ` [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()' Jiri Kosina 2018-03-27 12:05 ` Jiri Kosina 2018-04-12 13:11 ` Jiri Kosina 2018-04-12 13:11 ` Jiri Kosina 2018-04-26 12:34 ` Jiri Kosina 2018-04-26 12:34 ` Jiri Kosina
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=50b54e595830cc86edfb977e045f5a7b2b1b726a.1521492069.git.christophe.jaillet@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=benjamin.tissoires@redhat.com \ --cc=jikos@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=masaki.ota@jp.alps.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.