All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: masaki.ota@jp.alps.com, benjamin.tissoires@redhat.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()'
Date: Thu, 12 Apr 2018 15:11:02 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.1804121510340.28129@cbobk.fhfr.pm> (raw)
In-Reply-To: <nycvar.YFH.7.76.1803271405420.15778@cbobk.fhfr.pm>

On Tue, 27 Mar 2018, Jiri Kosina wrote:

> > These patches are untested. Especially, patch 1 slightly changes the behavior
> > of 't4_read_write_register()'.
> > This looks logical to me, but please, review it carefully.
> > 
> > Christophe JAILLET (4):
> >   HID: alps: Report an error if we receive invalid data in
> >     't4_read_write_register()'
> >   HID: alps: Save a memory allocation in 't4_read_write_register()' when
> >     writing data
> >   HID: alps: Check errors returned by 't4_read_write_register()'
> >   HID: alps: Fix some style in 't4_read_write_register()'
> > 
> >  drivers/hid/hid-alps.c | 27 ++++++++++++++++++++++-----
> >  1 file changed, 22 insertions(+), 5 deletions(-)
> 
> Masaki-san,
> 
> do you have any comments to Christophe's patchset please?

If there is no feedback, I'll queue the set for 4.18.

Thanks,

-- 
Jiri Kosina
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Kosina <jikos@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: masaki.ota@jp.alps.com, benjamin.tissoires@redhat.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/4] HID: alps: Fix some bugs and improve code around  't4_read_write_register()'
Date: Thu, 12 Apr 2018 13:11:02 +0000	[thread overview]
Message-ID: <nycvar.YFH.7.76.1804121510340.28129@cbobk.fhfr.pm> (raw)
In-Reply-To: <nycvar.YFH.7.76.1803271405420.15778@cbobk.fhfr.pm>

On Tue, 27 Mar 2018, Jiri Kosina wrote:

> > These patches are untested. Especially, patch 1 slightly changes the behavior
> > of 't4_read_write_register()'.
> > This looks logical to me, but please, review it carefully.
> > 
> > Christophe JAILLET (4):
> >   HID: alps: Report an error if we receive invalid data in
> >     't4_read_write_register()'
> >   HID: alps: Save a memory allocation in 't4_read_write_register()' when
> >     writing data
> >   HID: alps: Check errors returned by 't4_read_write_register()'
> >   HID: alps: Fix some style in 't4_read_write_register()'
> > 
> >  drivers/hid/hid-alps.c | 27 ++++++++++++++++++++++-----
> >  1 file changed, 22 insertions(+), 5 deletions(-)
> 
> Masaki-san,
> 
> do you have any comments to Christophe's patchset please?

If there is no feedback, I'll queue the set for 4.18.

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2018-04-12 13:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 20:53 [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()' Christophe JAILLET
2018-03-19 20:53 ` Christophe JAILLET
2018-03-19 20:53 ` [PATCH 1/4] HID: alps: Report an error if we receive invalid data in 't4_read_write_register()' Christophe JAILLET
2018-03-19 20:53   ` Christophe JAILLET
2018-03-19 20:53 ` [PATCH 2/4] HID: alps: Save a memory allocation in 't4_read_write_register()' when writing data Christophe JAILLET
2018-03-19 20:53   ` Christophe JAILLET
2018-03-19 20:53 ` [PATCH 3/4] HID: alps: Check errors returned by 't4_read_write_register()' Christophe JAILLET
2018-03-19 20:53   ` Christophe JAILLET
2018-03-19 20:53 ` [PATCH 4/4] HID: alps: Fix some style in 't4_read_write_register()' Christophe JAILLET
2018-03-19 20:53   ` Christophe JAILLET
2018-03-27 12:05 ` [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()' Jiri Kosina
2018-03-27 12:05   ` Jiri Kosina
2018-04-12 13:11   ` Jiri Kosina [this message]
2018-04-12 13:11     ` Jiri Kosina
2018-04-26 12:34 ` Jiri Kosina
2018-04-26 12:34   ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.1804121510340.28129@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masaki.ota@jp.alps.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.