* Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
[not found] <alpine.LFD.2.00.1302061115590.1664@ja.ssi.bg>
@ 2013-02-06 9:36 ` Zhang Yanfei
0 siblings, 0 replies; 8+ messages in thread
From: Zhang Yanfei @ 2013-02-06 9:36 UTC (permalink / raw)
To: Julian Anastasov
Cc: Andrew Morton, horms, Linux MM, linux-kernel, kamezawa.hiroyu,
minchan, mgorman
于 2013年02月06日 17:29, Julian Anastasov 写道:
>
> Hello,
>
> Sorry that I'm writing a private email but I
> deleted your original message by mistake. Your change
> of the sysctl_sync_qlen_max from int to long is may be
> not enough.
>
> net/netfilter/ipvs/ip_vs_ctl.c contains
> proc var "sync_qlen_max" that should be changed to
> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>
Thanks for pointing this. I will update this in patch v2.
Thanks
Zhang Yanfei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
@ 2013-02-06 9:36 ` Zhang Yanfei
0 siblings, 0 replies; 8+ messages in thread
From: Zhang Yanfei @ 2013-02-06 9:36 UTC (permalink / raw)
To: Julian Anastasov
Cc: Andrew Morton, horms, Linux MM, linux-kernel, kamezawa.hiroyu,
minchan, mgorman
于 2013年02月06日 17:29, Julian Anastasov 写道:
>
> Hello,
>
> Sorry that I'm writing a private email but I
> deleted your original message by mistake. Your change
> of the sysctl_sync_qlen_max from int to long is may be
> not enough.
>
> net/netfilter/ipvs/ip_vs_ctl.c contains
> proc var "sync_qlen_max" that should be changed to
> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>
Thanks for pointing this. I will update this in patch v2.
Thanks
Zhang Yanfei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
2013-02-06 9:36 ` Zhang Yanfei
@ 2013-02-07 1:09 ` Simon Horman
-1 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-02-07 1:09 UTC (permalink / raw)
To: Zhang Yanfei
Cc: Julian Anastasov, Andrew Morton, Linux MM, linux-kernel,
kamezawa.hiroyu, minchan, mgorman
On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
> 于 2013年02月06日 17:29, Julian Anastasov 写道:
> >
> > Hello,
> >
> > Sorry that I'm writing a private email but I
> > deleted your original message by mistake. Your change
> > of the sysctl_sync_qlen_max from int to long is may be
> > not enough.
> >
> > net/netfilter/ipvs/ip_vs_ctl.c contains
> > proc var "sync_qlen_max" that should be changed to
> > sizeof(unsigned long) and updated with proc_doulongvec_minmax.
> >
>
> Thanks for pointing this. I will update this in patch v2.
Hi Zhang,
Thanks for helping to keep IPVS up to date.
It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
may also need to be updated.
Could you look at including that in v2 too?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
@ 2013-02-07 1:09 ` Simon Horman
0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-02-07 1:09 UTC (permalink / raw)
To: Zhang Yanfei
Cc: Julian Anastasov, Andrew Morton, Linux MM, linux-kernel,
kamezawa.hiroyu, minchan, mgorman
On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
> ao? 2013a1'02ae??06ae?JPY 17:29, Julian Anastasov a??e??:
> >
> > Hello,
> >
> > Sorry that I'm writing a private email but I
> > deleted your original message by mistake. Your change
> > of the sysctl_sync_qlen_max from int to long is may be
> > not enough.
> >
> > net/netfilter/ipvs/ip_vs_ctl.c contains
> > proc var "sync_qlen_max" that should be changed to
> > sizeof(unsigned long) and updated with proc_doulongvec_minmax.
> >
>
> Thanks for pointing this. I will update this in patch v2.
Hi Zhang,
Thanks for helping to keep IPVS up to date.
It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
may also need to be updated.
Could you look at including that in v2 too?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
2013-02-07 1:09 ` Simon Horman
@ 2013-02-07 1:50 ` Zhang Yanfei
-1 siblings, 0 replies; 8+ messages in thread
From: Zhang Yanfei @ 2013-02-07 1:50 UTC (permalink / raw)
To: Simon Horman
Cc: Julian Anastasov, Andrew Morton, Linux MM, linux-kernel,
kamezawa.hiroyu, minchan, mgorman
于 2013年02月07日 09:09, Simon Horman 写道:
> On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
>> 于 2013年02月06日 17:29, Julian Anastasov 写道:
>>>
>>> Hello,
>>>
>>> Sorry that I'm writing a private email but I
>>> deleted your original message by mistake. Your change
>>> of the sysctl_sync_qlen_max from int to long is may be
>>> not enough.
>>>
>>> net/netfilter/ipvs/ip_vs_ctl.c contains
>>> proc var "sync_qlen_max" that should be changed to
>>> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>>>
>>
>> Thanks for pointing this. I will update this in patch v2.
>
> Hi Zhang,
>
> Thanks for helping to keep IPVS up to date.
>
> It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
> and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
> may also need to be updated.
>
> Could you look at including that in v2 too?
OK. I will update it.
Thanks
Zhang
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
@ 2013-02-07 1:50 ` Zhang Yanfei
0 siblings, 0 replies; 8+ messages in thread
From: Zhang Yanfei @ 2013-02-07 1:50 UTC (permalink / raw)
To: Simon Horman
Cc: Julian Anastasov, Andrew Morton, Linux MM, linux-kernel,
kamezawa.hiroyu, minchan, mgorman
于 2013年02月07日 09:09, Simon Horman 写道:
> On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
>> 于 2013年02月06日 17:29, Julian Anastasov 写道:
>>>
>>> Hello,
>>>
>>> Sorry that I'm writing a private email but I
>>> deleted your original message by mistake. Your change
>>> of the sysctl_sync_qlen_max from int to long is may be
>>> not enough.
>>>
>>> net/netfilter/ipvs/ip_vs_ctl.c contains
>>> proc var "sync_qlen_max" that should be changed to
>>> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>>>
>>
>> Thanks for pointing this. I will update this in patch v2.
>
> Hi Zhang,
>
> Thanks for helping to keep IPVS up to date.
>
> It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
> and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
> may also need to be updated.
>
> Could you look at including that in v2 too?
OK. I will update it.
Thanks
Zhang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/7] mm: fix types for some functions and variables in case of overflow
@ 2013-02-06 5:11 Zhang Yanfei
2013-02-06 5:20 ` Zhang Yanfei
0 siblings, 1 reply; 8+ messages in thread
From: Zhang Yanfei @ 2013-02-06 5:11 UTC (permalink / raw)
To: Andrew Morton, mgorman, minchan, kamezawa.hiroyu; +Cc: Linux MM, linux-kernel
Currently, the amount of RAM that functions nr_free_*_pages return
is held in unsigned int. But in machines with big memory (exceeding
16TB), the amount may be incorrect because of overflow, so fix this
problem.
Also, fix the types of variables that is related to nr_free_*_pages.
For these variables are placed in several subsystems, I may be incorrectly
fix them, if there is any problem with the fix, please correct me.
Zhang Yanfei (7):
mm: fix return type for functions nr_free_*_pages
ia64: use %ld to print pages calculated in nr_free_buffer_pages
fs/buffer.c: change type of max_buffer_heads to unsigned long
fs/nfsd: change type of max_delegations, nfsd_drc_max_mem and
nfsd_drc_mem_used
vmscan: change type of vm_total_pages to unsigned long
net: change type of netns_ipvs->sysctl_sync_qlen_max
net: change type of virtio_chan->p9_max_pages
arch/ia64/mm/contig.c | 2 +-
arch/ia64/mm/discontig.c | 2 +-
fs/buffer.c | 4 ++--
fs/nfsd/nfs4state.c | 6 +++---
fs/nfsd/nfsd.h | 6 +++---
fs/nfsd/nfssvc.c | 6 +++---
include/linux/swap.h | 6 +++---
include/net/ip_vs.h | 2 +-
mm/page_alloc.c | 8 ++++----
mm/vmscan.c | 2 +-
net/9p/trans_virtio.c | 2 +-
11 files changed, 23 insertions(+), 23 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
2013-02-06 5:11 [PATCH 0/7] mm: fix types for some functions and variables in case of overflow Zhang Yanfei
@ 2013-02-06 5:20 ` Zhang Yanfei
0 siblings, 0 replies; 8+ messages in thread
From: Zhang Yanfei @ 2013-02-06 5:20 UTC (permalink / raw)
To: Andrew Morton, mgorman, minchan, kamezawa.hiroyu, wensong, horms, ja
Cc: Linux MM, linux-kernel
This member of struct netns_ipvs is calculated from nr_free_buffer_pages
so change its type to unsigned long in case of overflow.
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
include/net/ip_vs.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 68c69d5..66e6c01 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -966,7 +966,7 @@ struct netns_ipvs {
int sysctl_snat_reroute;
int sysctl_sync_ver;
int sysctl_sync_ports;
- int sysctl_sync_qlen_max;
+ unsigned long sysctl_sync_qlen_max;
int sysctl_sync_sock_size;
int sysctl_cache_bypass;
int sysctl_expire_nodest_conn;
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
@ 2013-02-06 5:20 ` Zhang Yanfei
0 siblings, 0 replies; 8+ messages in thread
From: Zhang Yanfei @ 2013-02-06 5:20 UTC (permalink / raw)
To: Andrew Morton, mgorman, minchan, kamezawa.hiroyu, wensong, horms, ja
Cc: Linux MM, linux-kernel
This member of struct netns_ipvs is calculated from nr_free_buffer_pages
so change its type to unsigned long in case of overflow.
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
include/net/ip_vs.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 68c69d5..66e6c01 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -966,7 +966,7 @@ struct netns_ipvs {
int sysctl_snat_reroute;
int sysctl_sync_ver;
int sysctl_sync_ports;
- int sysctl_sync_qlen_max;
+ unsigned long sysctl_sync_qlen_max;
int sysctl_sync_sock_size;
int sysctl_cache_bypass;
int sysctl_expire_nodest_conn;
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-02-07 1:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <alpine.LFD.2.00.1302061115590.1664@ja.ssi.bg>
2013-02-06 9:36 ` [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max Zhang Yanfei
2013-02-06 9:36 ` Zhang Yanfei
2013-02-07 1:09 ` Simon Horman
2013-02-07 1:09 ` Simon Horman
2013-02-07 1:50 ` Zhang Yanfei
2013-02-07 1:50 ` Zhang Yanfei
2013-02-06 5:11 [PATCH 0/7] mm: fix types for some functions and variables in case of overflow Zhang Yanfei
2013-02-06 5:20 ` [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max Zhang Yanfei
2013-02-06 5:20 ` Zhang Yanfei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.