Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Zhang Yanfei]

于 2013年02月06日 17:29, Julian Anastasov 写道:
> 
> 	Hello,
> 
> 	Sorry that I'm writing a private email but I
> deleted your original message by mistake. Your change
> of the sysctl_sync_qlen_max from int to long is may be
> not enough.
> 
> 	net/netfilter/ipvs/ip_vs_ctl.c contains
> proc var "sync_qlen_max" that should be changed to
> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
> 

Thanks for pointing this. I will update this in patch v2.

Thanks
Zhang Yanfei

Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Zhang Yanfei]

于 2013年02月06日 17:29, Julian Anastasov 写道:
> 
> 	Hello,
> 
> 	Sorry that I'm writing a private email but I
> deleted your original message by mistake. Your change
> of the sysctl_sync_qlen_max from int to long is may be
> not enough.
> 
> 	net/netfilter/ipvs/ip_vs_ctl.c contains
> proc var "sync_qlen_max" that should be changed to
> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
> 

Thanks for pointing this. I will update this in patch v2.

Thanks
Zhang Yanfei



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Simon Horman]

On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
> 于 2013年02月06日 17:29, Julian Anastasov 写道:
> > 
> > 	Hello,
> > 
> > 	Sorry that I'm writing a private email but I
> > deleted your original message by mistake. Your change
> > of the sysctl_sync_qlen_max from int to long is may be
> > not enough.
> > 
> > 	net/netfilter/ipvs/ip_vs_ctl.c contains
> > proc var "sync_qlen_max" that should be changed to
> > sizeof(unsigned long) and updated with proc_doulongvec_minmax.
> > 
> 
> Thanks for pointing this. I will update this in patch v2.

Hi Zhang,

Thanks for helping to keep IPVS up to date.

It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
may also need to be updated.

Could you look at including that in v2 too?

Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Simon Horman]

On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
> ao? 2013a1'02ae??06ae?JPY 17:29, Julian Anastasov a??e??:
> > 
> > 	Hello,
> > 
> > 	Sorry that I'm writing a private email but I
> > deleted your original message by mistake. Your change
> > of the sysctl_sync_qlen_max from int to long is may be
> > not enough.
> > 
> > 	net/netfilter/ipvs/ip_vs_ctl.c contains
> > proc var "sync_qlen_max" that should be changed to
> > sizeof(unsigned long) and updated with proc_doulongvec_minmax.
> > 
> 
> Thanks for pointing this. I will update this in patch v2.

Hi Zhang,

Thanks for helping to keep IPVS up to date.

It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
may also need to be updated.

Could you look at including that in v2 too?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Zhang Yanfei]

于 2013年02月07日 09:09, Simon Horman 写道:
> On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
>> 于 2013年02月06日 17:29, Julian Anastasov 写道:
>>>
>>> 	Hello,
>>>
>>> 	Sorry that I'm writing a private email but I
>>> deleted your original message by mistake. Your change
>>> of the sysctl_sync_qlen_max from int to long is may be
>>> not enough.
>>>
>>> 	net/netfilter/ipvs/ip_vs_ctl.c contains
>>> proc var "sync_qlen_max" that should be changed to
>>> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>>>
>>
>> Thanks for pointing this. I will update this in patch v2.
> 
> Hi Zhang,
> 
> Thanks for helping to keep IPVS up to date.
> 
> It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
> and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
> may also need to be updated.
> 
> Could you look at including that in v2 too?

OK. I will update it.

Thanks
Zhang

Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Zhang Yanfei]

于 2013年02月07日 09:09, Simon Horman 写道:
> On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
>> 于 2013年02月06日 17:29, Julian Anastasov 写道:
>>>
>>> 	Hello,
>>>
>>> 	Sorry that I'm writing a private email but I
>>> deleted your original message by mistake. Your change
>>> of the sysctl_sync_qlen_max from int to long is may be
>>> not enough.
>>>
>>> 	net/netfilter/ipvs/ip_vs_ctl.c contains
>>> proc var "sync_qlen_max" that should be changed to
>>> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>>>
>>
>> Thanks for pointing this. I will update this in patch v2.
> 
> Hi Zhang,
> 
> Thanks for helping to keep IPVS up to date.
> 
> It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
> and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
> may also need to be updated.
> 
> Could you look at including that in v2 too?

OK. I will update it.

Thanks
Zhang


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Zhang Yanfei]

This member of struct netns_ipvs is calculated from nr_free_buffer_pages
so change its type to unsigned long in case of overflow.

Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
 include/net/ip_vs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 68c69d5..66e6c01 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -966,7 +966,7 @@ struct netns_ipvs {
 	int			sysctl_snat_reroute;
 	int			sysctl_sync_ver;
 	int			sysctl_sync_ports;
-	int			sysctl_sync_qlen_max;
+	unsigned long		sysctl_sync_qlen_max;
 	int			sysctl_sync_sock_size;
 	int			sysctl_cache_bypass;
 	int			sysctl_expire_nodest_conn;
-- 
1.7.1

[PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

[Zhang Yanfei]

This member of struct netns_ipvs is calculated from nr_free_buffer_pages
so change its type to unsigned long in case of overflow.

Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
 include/net/ip_vs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 68c69d5..66e6c01 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -966,7 +966,7 @@ struct netns_ipvs {
 	int			sysctl_snat_reroute;
 	int			sysctl_sync_ver;
 	int			sysctl_sync_ports;
-	int			sysctl_sync_qlen_max;
+	unsigned long		sysctl_sync_qlen_max;
 	int			sysctl_sync_sock_size;
 	int			sysctl_cache_bypass;
 	int			sysctl_expire_nodest_conn;
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>