From: Santosh Shilimkar <santosh.shilimkar@ti.com> To: Kevin Hilman <khilman@linaro.org> Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off Date: Tue, 12 Feb 2013 10:25:09 +0530 [thread overview] Message-ID: <5119CB2D.9040001@ti.com> (raw) In-Reply-To: <87d2wazep6.fsf@linaro.org> On Saturday 09 February 2013 02:49 AM, Kevin Hilman wrote: > Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > >> Current CPU PM code code make use of common cpu_suspend() path for all the >> CPU power states which is not optimal. In fact cpu_suspend() path is needed >> only when we put CPU power domain to off state where the CPU context is lost. >> >> Update the code accordingly so that the expensive cpu_suspend() path >> can be avoided for the shallow CPU power states like CPU PD INA/CSWR. >> >> Cc: Kevin Hilman <khilman@deeprootsystems.com> >> >> Reported-by: Richard Woodruff <r-woodruff2@ti.com> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Looks OK at first glance, but are you sure this is right for the > various ways both clusters might idle using coupled CPUidle? > Yes it is perfectly safe from all C-states. This patch has been part of the OMAP4/OMAP5 product port for some time. I forgot to send it upstream some how :( > Some description of the testing would be helpful here. > Sorry. Should have mentioned it in first place. Patch is being tested on OMAP4430 (idle/suspend) and OMAP5 with few out of tree patches. Regards, Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off Date: Tue, 12 Feb 2013 10:25:09 +0530 [thread overview] Message-ID: <5119CB2D.9040001@ti.com> (raw) In-Reply-To: <87d2wazep6.fsf@linaro.org> On Saturday 09 February 2013 02:49 AM, Kevin Hilman wrote: > Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > >> Current CPU PM code code make use of common cpu_suspend() path for all the >> CPU power states which is not optimal. In fact cpu_suspend() path is needed >> only when we put CPU power domain to off state where the CPU context is lost. >> >> Update the code accordingly so that the expensive cpu_suspend() path >> can be avoided for the shallow CPU power states like CPU PD INA/CSWR. >> >> Cc: Kevin Hilman <khilman@deeprootsystems.com> >> >> Reported-by: Richard Woodruff <r-woodruff2@ti.com> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Looks OK at first glance, but are you sure this is right for the > various ways both clusters might idle using coupled CPUidle? > Yes it is perfectly safe from all C-states. This patch has been part of the OMAP4/OMAP5 product port for some time. I forgot to send it upstream some how :( > Some description of the testing would be helpful here. > Sorry. Should have mentioned it in first place. Patch is being tested on OMAP4430 (idle/suspend) and OMAP5 with few out of tree patches. Regards, Santosh
next prev parent reply other threads:[~2013-02-12 4:53 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-08 15:11 [PATCH] ARM: OMAP2+: PM: Fix the dt return condition in pm_late_init() Santosh Shilimkar 2013-02-08 15:11 ` Santosh Shilimkar 2013-02-08 15:11 ` [PATCH] ARM: OMAP2+: Remove duplicate omap4430_init_late() declaration Santosh Shilimkar 2013-02-08 15:11 ` Santosh Shilimkar 2013-02-08 15:21 ` Felipe Balbi 2013-02-08 15:21 ` Felipe Balbi 2013-02-15 9:35 ` Santosh Shilimkar 2013-02-15 9:35 ` Santosh Shilimkar 2013-03-04 18:19 ` Tony Lindgren 2013-03-04 18:19 ` Tony Lindgren 2013-02-08 15:11 ` [PATCH] ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off Santosh Shilimkar 2013-02-08 15:11 ` Santosh Shilimkar 2013-02-08 15:26 ` Felipe Balbi 2013-02-08 15:26 ` Felipe Balbi 2013-02-08 15:34 ` Santosh Shilimkar 2013-02-08 15:34 ` Santosh Shilimkar 2013-02-08 21:19 ` Kevin Hilman 2013-02-08 21:19 ` Kevin Hilman 2013-02-12 4:55 ` Santosh Shilimkar [this message] 2013-02-12 4:55 ` Santosh Shilimkar 2013-02-12 15:18 ` Kevin Hilman 2013-02-12 15:18 ` Kevin Hilman 2013-02-13 5:05 ` Santosh Shilimkar 2013-02-13 5:05 ` Santosh Shilimkar 2013-02-08 15:20 ` [PATCH] ARM: OMAP2+: PM: Fix the dt return condition in pm_late_init() Felipe Balbi 2013-02-08 15:20 ` Felipe Balbi 2013-02-08 15:34 ` Paul Walmsley 2013-02-08 15:34 ` Paul Walmsley 2013-02-08 15:36 ` Santosh Shilimkar 2013-02-08 15:36 ` Santosh Shilimkar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5119CB2D.9040001@ti.com \ --to=santosh.shilimkar@ti.com \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.