All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Bryan Wu <cooloney@gmail.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
	Richard Purdie <rpurdie@rpsys.net>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep
Date: Wed, 27 Feb 2013 17:08:56 +0100	[thread overview]
Message-ID: <512E2F98.6070404@epfl.ch> (raw)
In-Reply-To: <20130130081728.GC13568@avionic-0098.mockup.avionic-design.de>

Hi Bryan,

On 01/30/2013 09:17 AM, Thierry Reding wrote:
> On Mon, Jan 28, 2013 at 03:00:59PM +0100, Florian Vaussard wrote:
>> Call to led_pwm_set() can happen inside atomic context, like triggers.
>> If the PWM call can sleep, defer using a worker.
>>
>> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>>   drivers/leds/leds-pwm.c |   50 +++++++++++++++++++++++++++++++++++++++-------
>>   1 files changed, 42 insertions(+), 8 deletions(-)
>
> Bryan, I assume that you'll be taking this? It doesn't apply cleanly to
> my tree, probably because of Peter's recent changes that you took
> through your tree and Florian based his patches on top of that. The
> conflict resolution should be trivial, though.
>

It seems that this patch was not taken. Could you pull it, as the other
part is already in linux-pwm? Or is there any show stopper?

Many thanks.

Florian

WARNING: multiple messages have this Message-ID (diff)
From: florian.vaussard@epfl.ch (Florian Vaussard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep
Date: Wed, 27 Feb 2013 17:08:56 +0100	[thread overview]
Message-ID: <512E2F98.6070404@epfl.ch> (raw)
In-Reply-To: <20130130081728.GC13568@avionic-0098.mockup.avionic-design.de>

Hi Bryan,

On 01/30/2013 09:17 AM, Thierry Reding wrote:
> On Mon, Jan 28, 2013 at 03:00:59PM +0100, Florian Vaussard wrote:
>> Call to led_pwm_set() can happen inside atomic context, like triggers.
>> If the PWM call can sleep, defer using a worker.
>>
>> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>>   drivers/leds/leds-pwm.c |   50 +++++++++++++++++++++++++++++++++++++++-------
>>   1 files changed, 42 insertions(+), 8 deletions(-)
>
> Bryan, I assume that you'll be taking this? It doesn't apply cleanly to
> my tree, probably because of Peter's recent changes that you took
> through your tree and Florian based his patches on top of that. The
> conflict resolution should be trivial, though.
>

It seems that this patch was not taken. Could you pull it, as the other
part is already in linux-pwm? Or is there any show stopper?

Many thanks.

Florian

  parent reply	other threads:[~2013-02-27 16:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 14:00 [PATCH v3 0/3] leds-pwm: Defer PWM calls if PWM can sleep Florian Vaussard
2013-01-28 14:00 ` Florian Vaussard
2013-01-28 14:00 ` [PATCH v3 1/3] pwm: Add pwm_can_sleep() as exported API to users Florian Vaussard
2013-01-28 14:00   ` Florian Vaussard
2013-01-29  8:20   ` Peter Ujfalusi
2013-01-29  8:20     ` Peter Ujfalusi
2013-01-30  8:14   ` Thierry Reding
2013-01-30  8:14     ` Thierry Reding
2013-01-28 14:00 ` [PATCH v3 2/3] pwm: Add can_sleep property to drivers Florian Vaussard
2013-01-28 14:00   ` Florian Vaussard
2013-01-30  8:15   ` Thierry Reding
2013-01-30  8:15     ` Thierry Reding
2013-01-28 14:00 ` [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep Florian Vaussard
2013-01-28 14:00   ` Florian Vaussard
2013-01-29  8:20   ` Peter Ujfalusi
2013-01-29  8:20     ` Peter Ujfalusi
2013-01-30  8:17   ` Thierry Reding
2013-01-30  8:17     ` Thierry Reding
2013-02-04  8:53     ` Florian Vaussard
2013-02-04  8:53       ` Florian Vaussard
2013-02-27 16:08     ` Florian Vaussard [this message]
2013-02-27 16:08       ` Florian Vaussard
2013-03-04 10:44       ` Florian Vaussard
2013-03-04 10:44         ` Florian Vaussard
2013-03-04 10:58         ` Thierry Reding
2013-03-04 10:58           ` Thierry Reding
2013-03-05 15:39           ` Florian Vaussard
2013-03-05 15:39             ` Florian Vaussard
2013-03-12 10:06           ` Florian Vaussard
2013-03-12 10:06             ` Florian Vaussard
2013-03-15 17:08             ` Bryan Wu
2013-03-15 17:08               ` Bryan Wu
2013-03-15 18:59               ` Thierry Reding
2013-03-15 18:59                 ` Thierry Reding
2013-03-15 20:09                 ` Florian Vaussard
2013-03-15 20:09                   ` Florian Vaussard
2013-03-15 21:02                   ` Bryan Wu
2013-03-15 21:02                     ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512E2F98.6070404@epfl.ch \
    --to=florian.vaussard@epfl.ch \
    --cc=cooloney@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=rpurdie@rpsys.net \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.