All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
	Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers
Date: Wed, 29 Jun 2016 19:54:31 -0400	[thread overview]
Message-ID: <51308073-3e51-c5fb-02d3-ab04dfb9a2a3@redhat.com> (raw)
In-Reply-To: <8760stemfk.fsf@dusky.pond.sub.org>



On 06/28/2016 04:40 AM, Markus Armbruster wrote:
> Sascha Silbe <silbe@linux.vnet.ibm.com> writes:
> 
>> Dear Paolo,
>>
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>>> After applying your series on top of f12103af and running "./configure"
>>>> in a clean working directory, I get the following errors for "make
>>>> check-source":
>>>>
>>>> $ make check-source
>>>> egrep: config-host.h: No such file or directory
>>>> egrep: qmp-commands.h: No such file or directory
>> [...]
>>>>   GEN   aarch64-softmmu/config-devices.mak.tmp
>>>>   GEN   aarch64-softmmu/config-devices.mak
>>>> [...]
>>>>   GEN   tests/test-qmp-introspect.h
>>>> make: *** No rule to make target `tests/headers/audio/audio.o', needed by `check-headers'. Stop.
>>>
>>> Hi Sascha,
>>>
>>> these are all generated headers.  In general, "make check" must be run
>>> after "make", and I suppose the same holds for "make check-headers".
>>
>> Still no dice. The egrep error messages don't occur when running "make
>> check-source" after a full "make" run, but the audio.o error still
>> happens:
>>
>> $ make check-source
>> make: *** No rule to make target `tests/headers/audio/audio.o', needed by `check-headers'. Stop.
> 
> Works fine in my build tree, fails in a fresh clone, can't yet say why.
> Thanks for reporting!
> 

I tried to manually exclude audio/audio.h, but it goes on to barf on the
next header in audio/. Not sure why your formula doesn't like that
directory for us.

(I *hate* Makefiles ...)

--js

  reply	other threads:[~2016-06-29 23:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 14:19 [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers Markus Armbruster
2016-06-24 14:54   ` Eric Blake
2016-06-27  6:34     ` Markus Armbruster
2016-06-27  8:50     ` Markus Armbruster
2016-06-27 10:07       ` Peter Maydell
2016-06-28  8:17         ` Markus Armbruster
2016-06-27 14:23       ` Eric Blake
2016-06-28  8:09         ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source Markus Armbruster
2016-06-24 14:23   ` Peter Maydell
2016-06-27  6:34     ` Markus Armbruster
2016-06-27 10:02       ` Peter Maydell
2016-06-28  8:19         ` Markus Armbruster
2016-06-28  8:33           ` Peter Maydell
2016-06-30  6:30   ` [Qemu-devel] [PATCH RFC] fixup! " Markus Armbruster
2016-06-30 10:58     ` Sascha Silbe
2016-06-30 12:14       ` Markus Armbruster
2016-07-01 13:52         ` Markus Armbruster
2016-07-04 11:16           ` Sascha Silbe
2016-07-06 13:46             ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony target Markus Armbruster
2016-06-24 15:17   ` Eric Blake
2016-06-27  6:35     ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 4/5] include: Move typedef qemu_irq to qemu/typedefs.h Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 5/5] include: Include exec/hwaddr.h where hwaddr is used Markus Armbruster
2016-06-27 17:27 ` [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers Sascha Silbe
2016-06-27 18:13   ` Paolo Bonzini
2016-06-27 20:39     ` Sascha Silbe
2016-06-28  8:40       ` Markus Armbruster
2016-06-29 23:54         ` John Snow [this message]
2016-06-30  6:30           ` Markus Armbruster
2016-06-30 16:19             ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51308073-3e51-c5fb-02d3-ab04dfb9a2a3@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=silbe@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.