All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony target
Date: Mon, 27 Jun 2016 08:35:31 +0200	[thread overview]
Message-ID: <87shvzb0lo.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <576D4F0A.9010103@redhat.com> (Eric Blake's message of "Fri, 24 Jun 2016 09:17:30 -0600")

Eric Blake <eblake@redhat.com> writes:

> On 06/24/2016 08:19 AM, Markus Armbruster wrote:
>> Forgotten in commit b8c6f29.
>
> Umm, really?  That commit starts with:
>
> tests/Makefile
> -.PHONY: check
> +
> +.PHONY: check check-block
>
> Rather, I think it was b93b63f5 that accidentally lost it during an
> overhaul.

Oops.  Will fix.

>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  tests/Makefile.include | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 7b0446b..233cb9c 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -752,7 +752,7 @@ tests/headers/%.c: tests/header-test-template.c
>>  
>>  # Consolidated targets
>>  
>> -.PHONY: check-qapi-schema check-qtest check-unit check check-source check-clean
>> +.PHONY: check-qapi-schema check-qtest check-unit check check-block check-source check-clean
>
> Long line; worth splitting?

Yes.

> With commit message improved,
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

  reply	other threads:[~2016-06-27  6:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 14:19 [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers Markus Armbruster
2016-06-24 14:54   ` Eric Blake
2016-06-27  6:34     ` Markus Armbruster
2016-06-27  8:50     ` Markus Armbruster
2016-06-27 10:07       ` Peter Maydell
2016-06-28  8:17         ` Markus Armbruster
2016-06-27 14:23       ` Eric Blake
2016-06-28  8:09         ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source Markus Armbruster
2016-06-24 14:23   ` Peter Maydell
2016-06-27  6:34     ` Markus Armbruster
2016-06-27 10:02       ` Peter Maydell
2016-06-28  8:19         ` Markus Armbruster
2016-06-28  8:33           ` Peter Maydell
2016-06-30  6:30   ` [Qemu-devel] [PATCH RFC] fixup! " Markus Armbruster
2016-06-30 10:58     ` Sascha Silbe
2016-06-30 12:14       ` Markus Armbruster
2016-07-01 13:52         ` Markus Armbruster
2016-07-04 11:16           ` Sascha Silbe
2016-07-06 13:46             ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony target Markus Armbruster
2016-06-24 15:17   ` Eric Blake
2016-06-27  6:35     ` Markus Armbruster [this message]
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 4/5] include: Move typedef qemu_irq to qemu/typedefs.h Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 5/5] include: Include exec/hwaddr.h where hwaddr is used Markus Armbruster
2016-06-27 17:27 ` [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers Sascha Silbe
2016-06-27 18:13   ` Paolo Bonzini
2016-06-27 20:39     ` Sascha Silbe
2016-06-28  8:40       ` Markus Armbruster
2016-06-29 23:54         ` John Snow
2016-06-30  6:30           ` Markus Armbruster
2016-06-30 16:19             ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shvzb0lo.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.