From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers
Date: Tue, 28 Jun 2016 10:17:22 +0200 [thread overview]
Message-ID: <87h9cdenhp.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA9VQK8becbJgA=ZLJ_Pjw2KhTykDezvXWpO+CNhS+vHdA@mail.gmail.com> (Peter Maydell's message of "Mon, 27 Jun 2016 11:07:58 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On 27 June 2016 at 09:50, Markus Armbruster <armbru@redhat.com> wrote:
>> To spice up things, we
>> also name a few of our headers just like system headers we use
>> elsewhere, e.g. "util.h" in net/ vs. <util.h> in util/qemu-openpty.c.
>
> That would be nice to fix at some point I think, it's pretty brittle.
> (We had one issue recently that boiled down to system header vs local
> header confusion, though I forget the details.)
Fixing collisions we're aware of is easy enough, just rename our header.
Finding collisions is more interesting. Perhaps I can cook up something
for make check-source.
next prev parent reply other threads:[~2016-06-28 8:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 14:19 [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers Markus Armbruster
2016-06-24 14:54 ` Eric Blake
2016-06-27 6:34 ` Markus Armbruster
2016-06-27 8:50 ` Markus Armbruster
2016-06-27 10:07 ` Peter Maydell
2016-06-28 8:17 ` Markus Armbruster [this message]
2016-06-27 14:23 ` Eric Blake
2016-06-28 8:09 ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source Markus Armbruster
2016-06-24 14:23 ` Peter Maydell
2016-06-27 6:34 ` Markus Armbruster
2016-06-27 10:02 ` Peter Maydell
2016-06-28 8:19 ` Markus Armbruster
2016-06-28 8:33 ` Peter Maydell
2016-06-30 6:30 ` [Qemu-devel] [PATCH RFC] fixup! " Markus Armbruster
2016-06-30 10:58 ` Sascha Silbe
2016-06-30 12:14 ` Markus Armbruster
2016-07-01 13:52 ` Markus Armbruster
2016-07-04 11:16 ` Sascha Silbe
2016-07-06 13:46 ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony target Markus Armbruster
2016-06-24 15:17 ` Eric Blake
2016-06-27 6:35 ` Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 4/5] include: Move typedef qemu_irq to qemu/typedefs.h Markus Armbruster
2016-06-24 14:19 ` [Qemu-devel] [PATCH RFC v2 5/5] include: Include exec/hwaddr.h where hwaddr is used Markus Armbruster
2016-06-27 17:27 ` [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers Sascha Silbe
2016-06-27 18:13 ` Paolo Bonzini
2016-06-27 20:39 ` Sascha Silbe
2016-06-28 8:40 ` Markus Armbruster
2016-06-29 23:54 ` John Snow
2016-06-30 6:30 ` Markus Armbruster
2016-06-30 16:19 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9cdenhp.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.