[PATCH] mm/compaction: Fix warning of 'flags' may be used uninitialized

* [PATCH] mm/compaction: Fix warning of 'flags' may be used uninitialized
@ 2014-09-10  6:12 Xiubo Li
  2014-09-10 18:50 ` David Rientjes
  0 siblings, 1 reply; 5+ messages in thread
From: Xiubo Li @ 2014-09-10  6:12 UTC (permalink / raw)
  To: akpm, vbabka, mgorman, rientjes, minchan, linux-mm; +Cc: Xiubo Li

C      mm/compaction.o
mm/compaction.c: In function isolate_freepages_block:
mm/compaction.c:364:37: warning: flags may be used uninitialized in
this function [-Wmaybe-uninitialized]
       && compact_unlock_should_abort(&cc->zone->lock, flags,
                                     ^
In file included from include/linux/irqflags.h:15:0,
                 from ./arch/arm/include/asm/bitops.h:27,
                 from include/linux/bitops.h:33,
                 from include/linux/kernel.h:10,
                 from include/linux/list.h:8,
                 from include/linux/preempt.h:10,
                 from include/linux/spinlock.h:50,
                 from include/linux/swap.h:4,
                 from mm/compaction.c:10:
mm/compaction.c: In function isolate_migratepages_block:
./arch/arm/include/asm/irqflags.h:152:2: warning: flags may be used
uninitialized in this function [-Wmaybe-uninitialized]
  asm volatile(
  ^
mm/compaction.c:576:16: note: flags as declared here
  unsigned long flags;
                ^

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
 mm/compaction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 7d9d92e..fb28d85 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -344,7 +344,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
 {
 	int nr_scanned = 0, total_isolated = 0;
 	struct page *cursor, *valid_page = NULL;
-	unsigned long flags;
+	unsigned long flags = 0;
 	bool locked = false;
 	unsigned long blockpfn = *start_pfn;
 
@@ -573,7 +573,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
 	unsigned long nr_scanned = 0, nr_isolated = 0;
 	struct list_head *migratelist = &cc->migratepages;
 	struct lruvec *lruvec;
-	unsigned long flags;
+	unsigned long flags = 0;
 	bool locked = false;
 	struct page *page = NULL, *valid_page = NULL;
 
-- 
2.1.0.27.g96db324

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 5+ messages in thread