Re: [Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command

From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com,
	Paolo Bonzini <pbonzini@redhat.com>,
	xiawenc@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command
Date: Wed, 15 May 2013 13:04:55 -0600	[thread overview]
Message-ID: <5193DC57.5050203@redhat.com> (raw)
In-Reply-To: <1368628476-19622-4-git-send-email-stefanha@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote:
> @drive-backup
> 
> Start a point-in-time copy of a block device to a new destination.  The
> status of ongoing drive-backup operations can be checked with
> query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
> The operation can be stopped before it has completed using the
> block-job-cancel command.
> 

> +++ b/qmp-commands.hx
> @@ -912,6 +912,12 @@ EQMP
>      },
>  
>      {
> +        .name       = "drive-backup",
> +        .args_type  = "device:B,target:s,speed:i?,mode:s?,format:s?",
> +        .mhandler.cmd_new = qmp_marshal_input_drive_backup,
> +    },

No example?  But I'm not going to block this patch because of that.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]