Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction

From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org, imain@redhat.com,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction
Date: Thu, 16 May 2013 10:26:38 +0800	[thread overview]
Message-ID: <519443DE.5040809@linux.vnet.ibm.com> (raw)
In-Reply-To: <5193DB7B.5010404@redhat.com>

于 2013-5-16 3:01, Eric Blake 写道:
> On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote:
>> The Abort action can be used to test QMP 'transaction' failure.  Add it
>> as the last action to exercise the .abort() and .cleanup() code paths
>> for all previous actions.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>   blockdev.c       | 15 +++++++++++++++
>>   qapi-schema.json | 11 ++++++++++-
>>   2 files changed, 25 insertions(+), 1 deletion(-)
>
> I like it!  Even though libvirt will never use it, I can see how having
> it definitely helps development of other transaction actions.
>
>> +++ b/qapi-schema.json
>> @@ -1630,6 +1630,14 @@
>>               '*mode': 'NewImageMode', '*speed': 'int' } }
>>
>>   ##
>> +# @Abort
>> +#
>> +# This action can be used to test transaction failure.
>> +###
>> +{ 'type': 'Abort',
>> +  'data': { } }
>> +
>
> Probably should add a Since: 1.6 notation.  With that,
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
   Nice to have it for injecting error.

Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

-- 
Best Regards

Wenchao Xia