* [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat
@ 2013-05-17 7:44 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas KANDAGATLA @ 2013-05-17 7:44 UTC (permalink / raw)
To: Tony Prisk
Cc: Russell King, linux-arm-kernel, linux-kernel, Srinivas Kandagatla
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it
failed to boot. The issues seems to be changing by enabling or disabling
VT8550 platform. Having a quick look at dt_compat list, it seems to miss
a NULL terminator, which means of_flat_dt_match will compat check will
cross the boundary of dt_compat and fault at some point , which is what
was happening in my case.
Without this patch if we try to boot multi_v7_defconfig you might notice
that some of the platforms might fault if they fall after vt8500 in
machine-desc list. Other platforms which fall before vt8500 in mdesc list
will not fault.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
arch/arm/mach-vt8500/vt8500.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
index 1dd281e..f5c33df 100644
--- a/arch/arm/mach-vt8500/vt8500.c
+++ b/arch/arm/mach-vt8500/vt8500.c
@@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = {
"wm,wm8505",
"wm,wm8750",
"wm,wm8850",
+ NULL
};
DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)")
--
1.7.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat
@ 2013-05-17 7:44 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas KANDAGATLA @ 2013-05-17 7:44 UTC (permalink / raw)
To: linux-arm-kernel
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it
failed to boot. The issues seems to be changing by enabling or disabling
VT8550 platform. Having a quick look at dt_compat list, it seems to miss
a NULL terminator, which means of_flat_dt_match will compat check will
cross the boundary of dt_compat and fault at some point , which is what
was happening in my case.
Without this patch if we try to boot multi_v7_defconfig you might notice
that some of the platforms might fault if they fall after vt8500 in
machine-desc list. Other platforms which fall before vt8500 in mdesc list
will not fault.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
arch/arm/mach-vt8500/vt8500.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
index 1dd281e..f5c33df 100644
--- a/arch/arm/mach-vt8500/vt8500.c
+++ b/arch/arm/mach-vt8500/vt8500.c
@@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = {
"wm,wm8505",
"wm,wm8750",
"wm,wm8850",
+ NULL
};
DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)")
--
1.7.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat
2013-05-17 7:44 ` Srinivas KANDAGATLA
@ 2013-05-17 8:28 ` Tony Prisk
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Prisk @ 2013-05-17 8:28 UTC (permalink / raw)
To: Srinivas KANDAGATLA
Cc: Russell King, linux-arm-kernel, linux-kernel, Bergmann, Arnd,
Johansson, Olof
On 17/05/13 19:44, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it
> failed to boot. The issues seems to be changing by enabling or disabling
> VT8550 platform. Having a quick look at dt_compat list, it seems to miss
> a NULL terminator, which means of_flat_dt_match will compat check will
> cross the boundary of dt_compat and fault at some point , which is what
> was happening in my case.
>
> Without this patch if we try to boot multi_v7_defconfig you might notice
> that some of the platforms might fault if they fall after vt8500 in
> machine-desc list. Other platforms which fall before vt8500 in mdesc list
> will not fault.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> arch/arm/mach-vt8500/vt8500.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> index 1dd281e..f5c33df 100644
> --- a/arch/arm/mach-vt8500/vt8500.c
> +++ b/arch/arm/mach-vt8500/vt8500.c
> @@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = {
> "wm,wm8505",
> "wm,wm8750",
> "wm,wm8850",
> + NULL
> };
>
> DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)")
My bad. Thanks for the fix.
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Arnd, Olof: Can you apply this directly please.
Regards
Tony Prisk
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat
@ 2013-05-17 8:28 ` Tony Prisk
0 siblings, 0 replies; 6+ messages in thread
From: Tony Prisk @ 2013-05-17 8:28 UTC (permalink / raw)
To: linux-arm-kernel
On 17/05/13 19:44, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it
> failed to boot. The issues seems to be changing by enabling or disabling
> VT8550 platform. Having a quick look at dt_compat list, it seems to miss
> a NULL terminator, which means of_flat_dt_match will compat check will
> cross the boundary of dt_compat and fault at some point , which is what
> was happening in my case.
>
> Without this patch if we try to boot multi_v7_defconfig you might notice
> that some of the platforms might fault if they fall after vt8500 in
> machine-desc list. Other platforms which fall before vt8500 in mdesc list
> will not fault.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> arch/arm/mach-vt8500/vt8500.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> index 1dd281e..f5c33df 100644
> --- a/arch/arm/mach-vt8500/vt8500.c
> +++ b/arch/arm/mach-vt8500/vt8500.c
> @@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = {
> "wm,wm8505",
> "wm,wm8750",
> "wm,wm8850",
> + NULL
> };
>
> DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)")
My bad. Thanks for the fix.
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Arnd, Olof: Can you apply this directly please.
Regards
Tony Prisk
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat
2013-05-17 8:28 ` Tony Prisk
@ 2013-05-21 6:31 ` Olof Johansson
-1 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2013-05-21 6:31 UTC (permalink / raw)
To: Tony Prisk
Cc: Srinivas KANDAGATLA, Russell King, linux-arm-kernel,
linux-kernel, Bergmann, Arnd
On Fri, May 17, 2013 at 08:28:36PM +1200, Tony Prisk wrote:
> On 17/05/13 19:44, Srinivas KANDAGATLA wrote:
> >From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> >
> >When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it
> >failed to boot. The issues seems to be changing by enabling or disabling
> >VT8550 platform. Having a quick look at dt_compat list, it seems to miss
> >a NULL terminator, which means of_flat_dt_match will compat check will
> >cross the boundary of dt_compat and fault at some point , which is what
> >was happening in my case.
> >
> >Without this patch if we try to boot multi_v7_defconfig you might notice
> >that some of the platforms might fault if they fall after vt8500 in
> >machine-desc list. Other platforms which fall before vt8500 in mdesc list
> >will not fault.
> >
> >Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> >---
> > arch/arm/mach-vt8500/vt8500.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> >index 1dd281e..f5c33df 100644
> >--- a/arch/arm/mach-vt8500/vt8500.c
> >+++ b/arch/arm/mach-vt8500/vt8500.c
> >@@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = {
> > "wm,wm8505",
> > "wm,wm8750",
> > "wm,wm8850",
> >+ NULL
> > };
> > DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)")
> My bad. Thanks for the fix.
>
> Acked-by: Tony Prisk <linux@prisktech.co.nz>
>
> Arnd, Olof: Can you apply this directly please.
Done.
Thanks,
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat
@ 2013-05-21 6:31 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2013-05-21 6:31 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 17, 2013 at 08:28:36PM +1200, Tony Prisk wrote:
> On 17/05/13 19:44, Srinivas KANDAGATLA wrote:
> >From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> >
> >When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it
> >failed to boot. The issues seems to be changing by enabling or disabling
> >VT8550 platform. Having a quick look at dt_compat list, it seems to miss
> >a NULL terminator, which means of_flat_dt_match will compat check will
> >cross the boundary of dt_compat and fault at some point , which is what
> >was happening in my case.
> >
> >Without this patch if we try to boot multi_v7_defconfig you might notice
> >that some of the platforms might fault if they fall after vt8500 in
> >machine-desc list. Other platforms which fall before vt8500 in mdesc list
> >will not fault.
> >
> >Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> >---
> > arch/arm/mach-vt8500/vt8500.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> >index 1dd281e..f5c33df 100644
> >--- a/arch/arm/mach-vt8500/vt8500.c
> >+++ b/arch/arm/mach-vt8500/vt8500.c
> >@@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = {
> > "wm,wm8505",
> > "wm,wm8750",
> > "wm,wm8850",
> >+ NULL
> > };
> > DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)")
> My bad. Thanks for the fix.
>
> Acked-by: Tony Prisk <linux@prisktech.co.nz>
>
> Arnd, Olof: Can you apply this directly please.
Done.
Thanks,
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-21 6:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-17 7:44 [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat Srinivas KANDAGATLA
2013-05-17 7:44 ` Srinivas KANDAGATLA
2013-05-17 8:28 ` Tony Prisk
2013-05-17 8:28 ` Tony Prisk
2013-05-21 6:31 ` Olof Johansson
2013-05-21 6:31 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.