* [PATCH] mmc: omap_hsmmc: use for OMAP5 as well @ 2013-06-28 12:34 a-bindra 2013-06-28 15:57 ` Balaji T K 2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra 0 siblings, 2 replies; 14+ messages in thread From: a-bindra @ 2013-06-28 12:34 UTC (permalink / raw) To: linux-mmc, cjb; +Cc: linux-omap, Balaji T K, balbi, nm, Amarinder Bindra From: Amarinder Bindra <a-bindra@ti.com> OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations. Signed-off-by: Amarinder Bindra <a-bindra@ti.com> Acked-by: Felipe Balbi <balbi@ti.com> Acked-by: Nishanth Menon <nm@ti.com> --- drivers/mmc/host/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 009dabd..6722e21 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -254,11 +254,11 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 + depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5 help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a - Multimedia Card slot, say Y or M here. + If you have an OMAP2430 or OMAP3 board or OMAP4 board or OMAP5 + board with a Multimedia Card slot, say Y or M here. If unsure, say N. -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well 2013-06-28 12:34 [PATCH] mmc: omap_hsmmc: use for OMAP5 as well a-bindra @ 2013-06-28 15:57 ` Balaji T K 2013-07-07 20:13 ` Ezequiel Garcia 2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra 1 sibling, 1 reply; 14+ messages in thread From: Balaji T K @ 2013-06-28 15:57 UTC (permalink / raw) To: a-bindra; +Cc: linux-mmc, cjb, linux-omap, balbi, nm On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > From: Amarinder Bindra <a-bindra@ti.com> > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > Considering that the device tree entries are already there for this, > allow the driver to be built when only OMAP5 is enabled. > This allows MMC root filesystems to be available in "OMAP5 only" > configurations. > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > Acked-by: Felipe Balbi <balbi@ti.com> > Acked-by: Nishanth Menon <nm@ti.com> Looks good to me, Acked-by: Balaji T K <balajitk@ti.com> > --- > drivers/mmc/host/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 009dabd..6722e21 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -254,11 +254,11 @@ config MMC_OMAP > > config MMC_OMAP_HS > tristate "TI OMAP High Speed Multimedia Card Interface support" > - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 > + depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5 > help > This selects the TI OMAP High Speed Multimedia card Interface. > - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a > - Multimedia Card slot, say Y or M here. > + If you have an OMAP2430 or OMAP3 board or OMAP4 board or OMAP5 > + board with a Multimedia Card slot, say Y or M here. > > If unsure, say N. > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well 2013-06-28 15:57 ` Balaji T K @ 2013-07-07 20:13 ` Ezequiel Garcia 2013-07-08 7:46 ` Felipe Balbi 0 siblings, 1 reply; 14+ messages in thread From: Ezequiel Garcia @ 2013-07-07 20:13 UTC (permalink / raw) To: Balaji T K; +Cc: a-bindra, linux-mmc, cjb, linux-omap, balbi, nm Hi guys, On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > > From: Amarinder Bindra <a-bindra@ti.com> > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > > Considering that the device tree entries are already there for this, > > allow the driver to be built when only OMAP5 is enabled. > > This allows MMC root filesystems to be available in "OMAP5 only" > > configurations. > > > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > > Acked-by: Felipe Balbi <balbi@ti.com> > > Acked-by: Nishanth Menon <nm@ti.com> > > Looks good to me, > Acked-by: Balaji T K <balajitk@ti.com> > I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4. Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this: --- diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 9ab8f8d..bade7f2 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -273,10 +273,9 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a + If you have an OMAP2430, OMAP3, OMAP4 or AM3xx board with a Multimedia Card slot, say Y or M here. If unsure, say N. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well 2013-07-07 20:13 ` Ezequiel Garcia @ 2013-07-08 7:46 ` Felipe Balbi 2013-07-08 19:58 ` Nishanth Menon 0 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2013-07-08 7:46 UTC (permalink / raw) To: Ezequiel Garcia Cc: Balaji T K, a-bindra, linux-mmc, cjb, linux-omap, balbi, nm [-- Attachment #1: Type: text/plain, Size: 1318 bytes --] On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote: > Hi guys, > > On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: > > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > > > From: Amarinder Bindra <a-bindra@ti.com> > > > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > > > Considering that the device tree entries are already there for this, > > > allow the driver to be built when only OMAP5 is enabled. > > > This allows MMC root filesystems to be available in "OMAP5 only" > > > configurations. > > > > > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > > > Acked-by: Felipe Balbi <balbi@ti.com> > > > Acked-by: Nishanth Menon <nm@ti.com> > > > > Looks good to me, > > Acked-by: Balaji T K <balajitk@ti.com> > > > > I came across this same issue while trying MMC patches on AM3xx, > which is nor OMAP3 neither OMAP4. > > Now, looking at the driver I don't see any OMAP-specific bits > (welcome to the multiplatform world ;-) so I think we can just > remove the 'depends' line. Something like this: frankly speaking, this driver should be deleted and all users should be moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except for a couple quirks which can be easily worked around. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well 2013-07-08 7:46 ` Felipe Balbi @ 2013-07-08 19:58 ` Nishanth Menon 2013-07-08 20:27 ` Ezequiel Garcia 2013-07-09 6:52 ` Felipe Balbi 0 siblings, 2 replies; 14+ messages in thread From: Nishanth Menon @ 2013-07-08 19:58 UTC (permalink / raw) To: Felipe Balbi Cc: Ezequiel Garcia, Balaji T K, a-bindra, linux-mmc, cjb, linux-omap On 10:46-20130708, Felipe Balbi wrote: > On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote: > > Hi guys, > > > > On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: > > > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > > > > From: Amarinder Bindra <a-bindra@ti.com> > > > > > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > > > > Considering that the device tree entries are already there for this, > > > > allow the driver to be built when only OMAP5 is enabled. > > > > This allows MMC root filesystems to be available in "OMAP5 only" > > > > configurations. > > > > > > > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > > > > Acked-by: Felipe Balbi <balbi@ti.com> > > > > Acked-by: Nishanth Menon <nm@ti.com> > > > > > > Looks good to me, > > > Acked-by: Balaji T K <balajitk@ti.com> > > > > > > > I came across this same issue while trying MMC patches on AM3xx, > > which is nor OMAP3 neither OMAP4. > > > > Now, looking at the driver I don't see any OMAP-specific bits > > (welcome to the multiplatform world ;-) so I think we can just > > remove the 'depends' line. Something like this: > > frankly speaking, this driver should be deleted and all users should be > moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except > for a couple quirks which can be easily worked around. Do we take that as a NAK to this specific patch? I am not complaining about the future migration to a solution that is much more generic and scalable, but having fixes for current problems should'nt be ignored IMHO. How about a depends on CONFIG_ARCH_OMAP2PLUS instead? will that solve our pains with all OMAP2+ usin this? -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well 2013-07-08 19:58 ` Nishanth Menon @ 2013-07-08 20:27 ` Ezequiel Garcia 2013-07-09 6:55 ` Felipe Balbi 2013-07-09 6:52 ` Felipe Balbi 1 sibling, 1 reply; 14+ messages in thread From: Ezequiel Garcia @ 2013-07-08 20:27 UTC (permalink / raw) To: Nishanth Menon Cc: Felipe Balbi, Balaji T K, a-bindra, linux-mmc, cjb, linux-omap On Mon, Jul 08, 2013 at 02:58:28PM -0500, Nishanth Menon wrote: > On 10:46-20130708, Felipe Balbi wrote: > > On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote: > > > Hi guys, > > > > > > On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: > > > > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > > > > > From: Amarinder Bindra <a-bindra@ti.com> > > > > > > > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > > > > > Considering that the device tree entries are already there for this, > > > > > allow the driver to be built when only OMAP5 is enabled. > > > > > This allows MMC root filesystems to be available in "OMAP5 only" > > > > > configurations. > > > > > > > > > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > > > > > Acked-by: Felipe Balbi <balbi@ti.com> > > > > > Acked-by: Nishanth Menon <nm@ti.com> > > > > > > > > Looks good to me, > > > > Acked-by: Balaji T K <balajitk@ti.com> > > > > > > > > > > I came across this same issue while trying MMC patches on AM3xx, > > > which is nor OMAP3 neither OMAP4. > > > > > > Now, looking at the driver I don't see any OMAP-specific bits > > > (welcome to the multiplatform world ;-) so I think we can just > > > remove the 'depends' line. Something like this: > > > > frankly speaking, this driver should be deleted and all users should be > > moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except > > for a couple quirks which can be easily worked around. @Felipe: Do you mind giving me some hints about this quirks? I'm not too familiar with these drivers. > Do we take that as a NAK to this specific patch? > > I am not complaining about the future migration to a solution that is > much more generic and scalable, but having fixes for current problems > should'nt be ignored IMHO. > Of course. > How about a depends on CONFIG_ARCH_OMAP2PLUS instead? will that solve > our pains with all OMAP2+ usin this? Yes, I think that using ARCH_OMAP2PLUS should do. FWIW, until we have sdhci ready to replace omap_hsmmc, we have no choice but to apply such a patch. @Nishant, Balaji: Can you take care of resending this? Thanks! -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well 2013-07-08 20:27 ` Ezequiel Garcia @ 2013-07-09 6:55 ` Felipe Balbi 0 siblings, 0 replies; 14+ messages in thread From: Felipe Balbi @ 2013-07-09 6:55 UTC (permalink / raw) To: Ezequiel Garcia Cc: Nishanth Menon, Felipe Balbi, Balaji T K, a-bindra, linux-mmc, cjb, linux-omap [-- Attachment #1: Type: text/plain, Size: 2863 bytes --] On Mon, Jul 08, 2013 at 05:27:50PM -0300, Ezequiel Garcia wrote: > On Mon, Jul 08, 2013 at 02:58:28PM -0500, Nishanth Menon wrote: > > On 10:46-20130708, Felipe Balbi wrote: > > > On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote: > > > > Hi guys, > > > > > > > > On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: > > > > > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > > > > > > From: Amarinder Bindra <a-bindra@ti.com> > > > > > > > > > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > > > > > > Considering that the device tree entries are already there for this, > > > > > > allow the driver to be built when only OMAP5 is enabled. > > > > > > This allows MMC root filesystems to be available in "OMAP5 only" > > > > > > configurations. > > > > > > > > > > > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > > > > > > Acked-by: Felipe Balbi <balbi@ti.com> > > > > > > Acked-by: Nishanth Menon <nm@ti.com> > > > > > > > > > > Looks good to me, > > > > > Acked-by: Balaji T K <balajitk@ti.com> > > > > > > > > > > > > > I came across this same issue while trying MMC patches on AM3xx, > > > > which is nor OMAP3 neither OMAP4. > > > > > > > > Now, looking at the driver I don't see any OMAP-specific bits > > > > (welcome to the multiplatform world ;-) so I think we can just > > > > remove the 'depends' line. Something like this: > > > > > > frankly speaking, this driver should be deleted and all users should be > > > moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except > > > for a couple quirks which can be easily worked around. > > @Felipe: > Do you mind giving me some hints about this quirks? I'm not too familiar > with these drivers. one of the quirks is that TI decided to registers into one (because they both had 16-bits reserved, so, well, we can make the HW 0.0000000000001 dollar cheaper :-p ) The other is related where our SDHCI registers start. Because of TI's added registers (SYSConfig and REVISION, etc), SDHCI registers have an offset which generic SDHCI driver, doesn't cope with right now. > > Do we take that as a NAK to this specific patch? > > > > I am not complaining about the future migration to a solution that is > > much more generic and scalable, but having fixes for current problems > > should'nt be ignored IMHO. > > > > Of course. > > > How about a depends on CONFIG_ARCH_OMAP2PLUS instead? will that solve > > our pains with all OMAP2+ usin this? > > Yes, I think that using ARCH_OMAP2PLUS should do. FWIW, until we have > sdhci ready to replace omap_hsmmc, we have no choice but to apply such > a patch. if you do change to ARCH_OMAP2PLUS, please also add COMPILE_TEST (ARCH_OMAP2PLUS || COMPILE_TEST) so we can build in other archs. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well 2013-07-08 19:58 ` Nishanth Menon 2013-07-08 20:27 ` Ezequiel Garcia @ 2013-07-09 6:52 ` Felipe Balbi 1 sibling, 0 replies; 14+ messages in thread From: Felipe Balbi @ 2013-07-09 6:52 UTC (permalink / raw) To: Nishanth Menon Cc: Felipe Balbi, Ezequiel Garcia, Balaji T K, a-bindra, linux-mmc, cjb, linux-omap [-- Attachment #1: Type: text/plain, Size: 1764 bytes --] On Mon, Jul 08, 2013 at 02:58:28PM -0500, Nishanth Menon wrote: > On 10:46-20130708, Felipe Balbi wrote: > > On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote: > > > Hi guys, > > > > > > On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: > > > > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > > > > > From: Amarinder Bindra <a-bindra@ti.com> > > > > > > > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > > > > > Considering that the device tree entries are already there for this, > > > > > allow the driver to be built when only OMAP5 is enabled. > > > > > This allows MMC root filesystems to be available in "OMAP5 only" > > > > > configurations. > > > > > > > > > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > > > > > Acked-by: Felipe Balbi <balbi@ti.com> > > > > > Acked-by: Nishanth Menon <nm@ti.com> > > > > > > > > Looks good to me, > > > > Acked-by: Balaji T K <balajitk@ti.com> > > > > > > > > > > I came across this same issue while trying MMC patches on AM3xx, > > > which is nor OMAP3 neither OMAP4. > > > > > > Now, looking at the driver I don't see any OMAP-specific bits > > > (welcome to the multiplatform world ;-) so I think we can just > > > remove the 'depends' line. Something like this: > > > > frankly speaking, this driver should be deleted and all users should be > > moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except > > for a couple quirks which can be easily worked around. > Do we take that as a NAK to this specific patch? heh, not really. We can't prevent bug fixes to this driver just because long ago TI decided to write a TI-specific driver when it could just re-use SDHCI :-) -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices 2013-06-28 12:34 [PATCH] mmc: omap_hsmmc: use for OMAP5 as well a-bindra 2013-06-28 15:57 ` Balaji T K @ 2013-07-10 16:06 ` a-bindra 2013-07-10 21:13 ` Nishanth Menon ` (3 more replies) 1 sibling, 4 replies; 14+ messages in thread From: a-bindra @ 2013-07-10 16:06 UTC (permalink / raw) To: linux-mmc, cjb Cc: linux-omap, Balaji T K, Amarinder Bindra, Ezequiel Garcia, Felipe Balbi, Nishanth Menon From: Amarinder Bindra <a-bindra@ti.com> OMAP's hs_mmc driver is used for MMC controller operation on many omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x). Considering that the device tree entries are already present for these, allow the driver to be built using the config ARCH_OMAP2PLUS rather than individually adding a config for each SoC to enable the support. Use COMPILE_TEST to enable the build for other platforms. Signed-off-by: Amarinder Bindra <a-bindra@ti.com> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> Cc: Felipe Balbi <balbi@ti.com> Cc: Nishanth Menon <nm@ti.com> --- Changes in v2: - Use the config ARCH_OMAP2PLUS to enable the driver - Use COMPILE_TEST - Update the commit message v1: https://patchwork.kernel.org/patch/2824632/ drivers/mmc/host/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 009dabd..48f6fe7 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -254,11 +254,11 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 + depends on ARCH_OMAP2PLUS || COMPILE_TEST help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a - Multimedia Card slot, say Y or M here. + If you have an omap2plus board with a Multimedia Card slot, + say Y or M here. If unsure, say N. -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices 2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra @ 2013-07-10 21:13 ` Nishanth Menon 2013-07-10 22:42 ` Ezequiel Garcia ` (2 subsequent siblings) 3 siblings, 0 replies; 14+ messages in thread From: Nishanth Menon @ 2013-07-10 21:13 UTC (permalink / raw) To: a-bindra Cc: linux-mmc, cjb, linux-omap, Balaji T K, Ezequiel Garcia, Felipe Balbi On 21:36-20130710, a-bindra@ti.com wrote: > From: Amarinder Bindra <a-bindra@ti.com> > > OMAP's hs_mmc driver is used for MMC controller operation on many > omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x). > > Considering that the device tree entries are already present for these, > allow the driver to be built using the config ARCH_OMAP2PLUS rather > than individually adding a config for each SoC to enable the > support. > > Use COMPILE_TEST to enable the build for other platforms. > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > Cc: Felipe Balbi <balbi@ti.com> > Cc: Nishanth Menon <nm@ti.com> works for O5. Acked-by: Nishanth Menon <nm@ti.com> -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices 2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra 2013-07-10 21:13 ` Nishanth Menon @ 2013-07-10 22:42 ` Ezequiel Garcia 2013-07-11 13:09 ` Felipe Balbi 2013-08-25 19:51 ` Chris Ball 3 siblings, 0 replies; 14+ messages in thread From: Ezequiel Garcia @ 2013-07-10 22:42 UTC (permalink / raw) To: a-bindra Cc: linux-mmc, cjb, linux-omap, Balaji T K, Felipe Balbi, Nishanth Menon On Wed, Jul 10, 2013 at 09:36:24PM +0530, a-bindra@ti.com wrote: > From: Amarinder Bindra <a-bindra@ti.com> > > OMAP's hs_mmc driver is used for MMC controller operation on many > omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x). > > Considering that the device tree entries are already present for these, > allow the driver to be built using the config ARCH_OMAP2PLUS rather > than individually adding a config for each SoC to enable the > support. > > Use COMPILE_TEST to enable the build for other platforms. > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > Cc: Felipe Balbi <balbi@ti.com> > Cc: Nishanth Menon <nm@ti.com> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices 2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra 2013-07-10 21:13 ` Nishanth Menon 2013-07-10 22:42 ` Ezequiel Garcia @ 2013-07-11 13:09 ` Felipe Balbi 2013-08-16 16:35 ` Balaji T K 2013-08-25 19:51 ` Chris Ball 3 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2013-07-11 13:09 UTC (permalink / raw) To: a-bindra Cc: linux-mmc, cjb, linux-omap, Balaji T K, Ezequiel Garcia, Felipe Balbi, Nishanth Menon [-- Attachment #1: Type: text/plain, Size: 769 bytes --] On Wed, Jul 10, 2013 at 09:36:24PM +0530, a-bindra@ti.com wrote: > From: Amarinder Bindra <a-bindra@ti.com> > > OMAP's hs_mmc driver is used for MMC controller operation on many > omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x). > > Considering that the device tree entries are already present for these, > allow the driver to be built using the config ARCH_OMAP2PLUS rather > than individually adding a config for each SoC to enable the > support. > > Use COMPILE_TEST to enable the build for other platforms. > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> > Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > Cc: Felipe Balbi <balbi@ti.com> > Cc: Nishanth Menon <nm@ti.com> Acked-by: Felipe Balbi <balbi@ti.com> -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices 2013-07-11 13:09 ` Felipe Balbi @ 2013-08-16 16:35 ` Balaji T K 0 siblings, 0 replies; 14+ messages in thread From: Balaji T K @ 2013-08-16 16:35 UTC (permalink / raw) To: balbi Cc: a-bindra, linux-mmc, cjb, linux-omap, Ezequiel Garcia, Nishanth Menon On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote: > On Wed, Jul 10, 2013 at 09:36:24PM +0530, a-bindra@ti.com wrote: >> From: Amarinder Bindra <a-bindra@ti.com> >> >> OMAP's hs_mmc driver is used for MMC controller operation on many >> omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x). >> >> Considering that the device tree entries are already present for these, >> allow the driver to be built using the config ARCH_OMAP2PLUS rather >> than individually adding a config for each SoC to enable the >> support. >> >> Use COMPILE_TEST to enable the build for other platforms. >> >> Signed-off-by: Amarinder Bindra <a-bindra@ti.com> >> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> >> Cc: Felipe Balbi <balbi@ti.com> >> Cc: Nishanth Menon <nm@ti.com> > > Acked-by: Felipe Balbi <balbi@ti.com> > Acked-by: Balaji T K <balajitk@ti.com> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices 2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra ` (2 preceding siblings ...) 2013-07-11 13:09 ` Felipe Balbi @ 2013-08-25 19:51 ` Chris Ball 3 siblings, 0 replies; 14+ messages in thread From: Chris Ball @ 2013-08-25 19:51 UTC (permalink / raw) To: a-bindra Cc: linux-mmc, linux-omap, Balaji T K, Ezequiel Garcia, Felipe Balbi, Nishanth Menon Hi, On Wed, Jul 10 2013, a-bindra@ti.com wrote: > From: Amarinder Bindra <a-bindra@ti.com> > > OMAP's hs_mmc driver is used for MMC controller operation on many > omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x). > > Considering that the device tree entries are already present for these, > allow the driver to be built using the config ARCH_OMAP2PLUS rather > than individually adding a config for each SoC to enable the > support. > > Use COMPILE_TEST to enable the build for other platforms. > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com> Thanks, pushed to mmc-next for 3.12. - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-08-25 19:51 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-06-28 12:34 [PATCH] mmc: omap_hsmmc: use for OMAP5 as well a-bindra 2013-06-28 15:57 ` Balaji T K 2013-07-07 20:13 ` Ezequiel Garcia 2013-07-08 7:46 ` Felipe Balbi 2013-07-08 19:58 ` Nishanth Menon 2013-07-08 20:27 ` Ezequiel Garcia 2013-07-09 6:55 ` Felipe Balbi 2013-07-09 6:52 ` Felipe Balbi 2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra 2013-07-10 21:13 ` Nishanth Menon 2013-07-10 22:42 ` Ezequiel Garcia 2013-07-11 13:09 ` Felipe Balbi 2013-08-16 16:35 ` Balaji T K 2013-08-25 19:51 ` Chris Ball
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.