From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
Dominik Dingel <dingel@linux.vnet.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Xiantao Zhang <xiantao.zhang@intel.com>,
Alexander Graf <agraf@suse.de>,
Christoffer Dall <christoffer.dall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] PF: Async page fault support on s390
Date: Thu, 18 Jul 2013 16:12:24 +0200 [thread overview]
Message-ID: <51E7F7C8.9090506@de.ibm.com> (raw)
In-Reply-To: <51E7F440.2010600@redhat.com>
On 18/07/13 15:57, Paolo Bonzini wrote:
> Il 11/07/2013 12:41, Christian Borntraeger ha scritto:
>> On 11/07/13 11:04, Gleb Natapov wrote:
>>> On Wed, Jul 10, 2013 at 02:59:55PM +0200, Dominik Dingel wrote:
>>>> This patch enables async page faults for s390 kvm guests.
>>>> It provides the userspace API to enable, disable or get the status of this
>>>> feature. Also it includes the diagnose code, called by the guest to enable
>>>> async page faults.
>>>>
>>>> The async page faults will use an already existing guest interface for this
>>>> purpose, as described in "CP Programming Services (SC24-6084)".
>>>>
>>>> Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
>>> Christian, looks good now?
>>
>> Looks good, but I just had a discussion with Dominik about several other cases
>> (guest driven reboot, qemu driven reboot, life migration). This patch should
>> allow all these cases (independent from this patch we need an ioctl to flush the
>> list of pending interrupts to do so, but reboot is currently broken in that
>> regard anyway - patch is currently being looked at)
>>
>> We are currently discussion if we should get rid of the APF_STATUS and let
>> the kernel wait for outstanding page faults before returning from KVM_RUN
>> or if we go with this patch and let userspace wait for completion.
>>
>> Will discuss this with Dominik, Conny and Alex. So lets defer that till next
>> week, ok?
>
> Let us know if we should wait for a v5. :)
Yes, there will be a v5
WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
Dominik Dingel <dingel@linux.vnet.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Xiantao Zhang <xiantao.zhang@intel.com>,
Alexander Graf <agraf@suse.de>,
Christoffer Dall <christoffer.dall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] PF: Async page fault support on s390
Date: Thu, 18 Jul 2013 16:12:24 +0200 [thread overview]
Message-ID: <51E7F7C8.9090506@de.ibm.com> (raw)
In-Reply-To: <51E7F440.2010600@redhat.com>
On 18/07/13 15:57, Paolo Bonzini wrote:
> Il 11/07/2013 12:41, Christian Borntraeger ha scritto:
>> On 11/07/13 11:04, Gleb Natapov wrote:
>>> On Wed, Jul 10, 2013 at 02:59:55PM +0200, Dominik Dingel wrote:
>>>> This patch enables async page faults for s390 kvm guests.
>>>> It provides the userspace API to enable, disable or get the status of this
>>>> feature. Also it includes the diagnose code, called by the guest to enable
>>>> async page faults.
>>>>
>>>> The async page faults will use an already existing guest interface for this
>>>> purpose, as described in "CP Programming Services (SC24-6084)".
>>>>
>>>> Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
>>> Christian, looks good now?
>>
>> Looks good, but I just had a discussion with Dominik about several other cases
>> (guest driven reboot, qemu driven reboot, life migration). This patch should
>> allow all these cases (independent from this patch we need an ioctl to flush the
>> list of pending interrupts to do so, but reboot is currently broken in that
>> regard anyway - patch is currently being looked at)
>>
>> We are currently discussion if we should get rid of the APF_STATUS and let
>> the kernel wait for outstanding page faults before returning from KVM_RUN
>> or if we go with this patch and let userspace wait for completion.
>>
>> Will discuss this with Dominik, Conny and Alex. So lets defer that till next
>> week, ok?
>
> Let us know if we should wait for a v5. :)
Yes, there will be a v5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-18 14:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 12:59 [PATCH v4 0/4] Enable async page faults on s390 Dominik Dingel
2013-07-10 12:59 ` Dominik Dingel
2013-07-10 12:59 ` [PATCH 1/4] PF: Add FAULT_FLAG_RETRY_NOWAIT for guest fault Dominik Dingel
2013-07-10 12:59 ` Dominik Dingel
2013-07-10 12:59 ` [PATCH 2/4] PF: Make KVM_HVA_ERR_BAD usable on s390 Dominik Dingel
2013-07-10 12:59 ` Dominik Dingel
2013-07-10 12:59 ` [PATCH 3/4] PF: Provide additional direct page notification Dominik Dingel
2013-07-10 12:59 ` Dominik Dingel
2013-07-10 12:59 ` [PATCH 4/4] PF: Async page fault support on s390 Dominik Dingel
2013-07-10 12:59 ` Dominik Dingel
2013-07-11 9:04 ` Gleb Natapov
2013-07-11 9:04 ` Gleb Natapov
2013-07-11 10:41 ` Christian Borntraeger
2013-07-11 10:41 ` Christian Borntraeger
2013-07-11 10:58 ` Gleb Natapov
2013-07-11 10:58 ` Gleb Natapov
2013-07-18 13:57 ` Paolo Bonzini
2013-07-18 13:57 ` Paolo Bonzini
2013-07-18 14:12 ` Christian Borntraeger [this message]
2013-07-18 14:12 ` Christian Borntraeger
-- strict thread matches above, loose matches on Subject: below --
2013-07-09 13:56 [PATCH v3 0/4] Enable async page faults " Dominik Dingel
2013-07-09 13:56 ` [PATCH 4/4] PF: Async page fault support " Dominik Dingel
2013-07-09 13:56 ` Dominik Dingel
2013-07-10 8:18 ` Christian Borntraeger
2013-07-10 8:18 ` Christian Borntraeger
2013-07-05 20:55 [RFC PATCH v2 0/4] Enable async page faults " Dominik Dingel
2013-07-05 20:55 ` [PATCH 4/4] PF: Async page fault support " Dominik Dingel
2013-07-05 20:55 ` Dominik Dingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E7F7C8.9090506@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=gleb@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.