From: Nishanth Menon <nm@ti.com> To: Tero Kristo <t-kristo@ti.com> Cc: linux-omap@vger.kernel.org, paul@pwsan.com, khilman@linaro.org, tony@atomide.com, mturquette@linaro.org, rnayak@ti.com, linux-arm-kernel@lists.infradead.org, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCHv4 21/33] CLK: OMAP: DPLL: add omap3 dpll support Date: Thu, 1 Aug 2013 09:46:06 -0500 [thread overview] Message-ID: <51FA74AE.8050704@ti.com> (raw) In-Reply-To: <51F92758.20405@ti.com> On 07/31/2013 10:03 AM, Tero Kristo wrote: > On 07/30/2013 11:08 PM, Nishanth Menon wrote: >> On 07/23/2013 02:20 AM, Tero Kristo wrote: [...] >> >>> pr_err("%s: ti,clk-bypass for %s not found\n", __func__, >>> clk_name); >>> goto cleanup; >>> @@ -225,14 +259,31 @@ static void __init of_omap_dpll_setup(struct >>> device_node *node, >>> dd->enable_mask = enable_mask; >>> dd->autoidle_mask = autoidle_mask; >>> >>> - dd->modes = 0xa0; >>> + if (!of_property_read_u32(node, "ti,recal-en-bit", &val)) >>> + dd->recal_en_bit = val; >>> + >>> + if (!of_property_read_u32(node, "ti,recal-st-bit", &val)) >>> + dd->recal_st_bit = val; >>> + >>> + if (!of_property_read_u32(node, "ti,auto-recal-bit", &val)) >>> + dd->auto_recal_bit = val; >> >> now I understand what it means. > > I am not quite sure you do, as I don't quite get your comment here. :) > You referring to that dd->modes part? yep. > >> >>> + >>> + of_property_read_u32(node, "ti,modes", &modes); >> i see we pass in modes, and read ti,modes to &modes. it is a bit sketchy >> without bindings documentation. > > ti,modes can be used to override the default modes. I get it, but prefer seeing it in Documentation/devicetree/bindings/... So that you would not have to repeat it anymore :D > >> >>> + >>> + dd->modes = modes; >> >> Should have belonged to original patch. > > If I squash this then we are fine. yes, thanks. >>> >>> - of_omap_dpll_setup(node, ops); >>> + of_omap_dpll_setup(node, ops, 0, 0xa0, 0, SUBTYPE_OMAP4_DPLL); >> what is 0xa0? > > Magic modes for DPLL. I'll copy over the macro def as mentioned in one > of the previous patches. yes, please.. > >> >>> } >>> EXPORT_SYMBOL_GPL(of_omap4_dpll_setup); >>> CLK_OF_DECLARE(omap4_dpll_clock, "ti,omap4-dpll-clock", >>> of_omap4_dpll_setup); >>> >> >> I think this should be squashed and a single dpll.c introduction to be >> done. > > Ok. thanks. -- Regards, Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv4 21/33] CLK: OMAP: DPLL: add omap3 dpll support Date: Thu, 1 Aug 2013 09:46:06 -0500 [thread overview] Message-ID: <51FA74AE.8050704@ti.com> (raw) In-Reply-To: <51F92758.20405@ti.com> On 07/31/2013 10:03 AM, Tero Kristo wrote: > On 07/30/2013 11:08 PM, Nishanth Menon wrote: >> On 07/23/2013 02:20 AM, Tero Kristo wrote: [...] >> >>> pr_err("%s: ti,clk-bypass for %s not found\n", __func__, >>> clk_name); >>> goto cleanup; >>> @@ -225,14 +259,31 @@ static void __init of_omap_dpll_setup(struct >>> device_node *node, >>> dd->enable_mask = enable_mask; >>> dd->autoidle_mask = autoidle_mask; >>> >>> - dd->modes = 0xa0; >>> + if (!of_property_read_u32(node, "ti,recal-en-bit", &val)) >>> + dd->recal_en_bit = val; >>> + >>> + if (!of_property_read_u32(node, "ti,recal-st-bit", &val)) >>> + dd->recal_st_bit = val; >>> + >>> + if (!of_property_read_u32(node, "ti,auto-recal-bit", &val)) >>> + dd->auto_recal_bit = val; >> >> now I understand what it means. > > I am not quite sure you do, as I don't quite get your comment here. :) > You referring to that dd->modes part? yep. > >> >>> + >>> + of_property_read_u32(node, "ti,modes", &modes); >> i see we pass in modes, and read ti,modes to &modes. it is a bit sketchy >> without bindings documentation. > > ti,modes can be used to override the default modes. I get it, but prefer seeing it in Documentation/devicetree/bindings/... So that you would not have to repeat it anymore :D > >> >>> + >>> + dd->modes = modes; >> >> Should have belonged to original patch. > > If I squash this then we are fine. yes, thanks. >>> >>> - of_omap_dpll_setup(node, ops); >>> + of_omap_dpll_setup(node, ops, 0, 0xa0, 0, SUBTYPE_OMAP4_DPLL); >> what is 0xa0? > > Magic modes for DPLL. I'll copy over the macro def as mentioned in one > of the previous patches. yes, please.. > >> >>> } >>> EXPORT_SYMBOL_GPL(of_omap4_dpll_setup); >>> CLK_OF_DECLARE(omap4_dpll_clock, "ti,omap4-dpll-clock", >>> of_omap4_dpll_setup); >>> >> >> I think this should be squashed and a single dpll.c introduction to be >> done. > > Ok. thanks. -- Regards, Nishanth Menon
next prev parent reply other threads:[~2013-08-01 14:46 UTC|newest] Thread overview: 204+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-23 7:19 [PATCHv4 00/33] ARM: OMAP: clock conversion to DT Tero Kristo 2013-07-23 7:19 ` Tero Kristo 2013-07-23 7:19 ` [PATCHv4 01/33] CLK: clkdev: add support for looking up clocks from DT Tero Kristo 2013-07-23 7:19 ` Tero Kristo 2013-07-30 15:04 ` Nishanth Menon 2013-07-30 15:04 ` Nishanth Menon 2013-07-31 8:43 ` Tero Kristo 2013-07-31 8:43 ` Tero Kristo 2013-07-23 7:19 ` [PATCHv4 02/33] clk: omap: introduce clock driver Tero Kristo 2013-07-23 7:19 ` Tero Kristo 2013-07-30 15:21 ` Nishanth Menon 2013-07-30 15:21 ` Nishanth Menon 2013-07-31 8:59 ` Tero Kristo 2013-07-31 8:59 ` Tero Kristo 2013-08-01 13:44 ` Nishanth Menon 2013-08-01 13:44 ` Nishanth Menon 2013-08-01 14:59 ` Tero Kristo 2013-08-01 14:59 ` Tero Kristo 2013-07-23 7:19 ` [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support Tero Kristo 2013-07-23 7:19 ` Tero Kristo 2013-07-30 16:23 ` Nishanth Menon 2013-07-30 16:23 ` Nishanth Menon 2013-07-31 9:46 ` Tero Kristo 2013-07-31 9:46 ` Tero Kristo 2013-08-01 14:00 ` Nishanth Menon 2013-08-01 14:00 ` Nishanth Menon 2013-08-01 15:08 ` Tero Kristo 2013-08-01 15:08 ` Tero Kristo 2013-08-01 15:13 ` Nishanth Menon 2013-08-01 15:13 ` Nishanth Menon 2013-08-01 8:29 ` Rajendra Nayak 2013-08-01 8:29 ` Rajendra Nayak 2013-08-01 15:10 ` Nishanth Menon 2013-08-01 15:10 ` Nishanth Menon 2013-08-01 15:41 ` Tero Kristo 2013-08-01 15:41 ` Tero Kristo 2013-07-23 7:19 ` [PATCHv4 04/33] CLK: omap: move part of the machine specific clock header contents to driver Tero Kristo 2013-07-23 7:19 ` Tero Kristo 2013-07-30 18:22 ` Nishanth Menon 2013-07-30 18:22 ` Nishanth Menon 2013-07-31 9:59 ` Tero Kristo 2013-07-31 9:59 ` Tero Kristo 2013-08-01 14:04 ` Nishanth Menon 2013-08-01 14:04 ` Nishanth Menon 2013-08-01 15:12 ` Tero Kristo 2013-08-01 15:12 ` Tero Kristo 2013-08-01 15:21 ` Nishanth Menon 2013-08-01 15:21 ` Nishanth Menon 2013-07-23 7:20 ` [PATCHv4 05/33] CLK: omap: add DT duplicate clock registration mechanism Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 18:40 ` Nishanth Menon 2013-07-30 18:40 ` Nishanth Menon 2013-07-31 10:07 ` Tero Kristo 2013-07-31 10:07 ` Tero Kristo 2013-08-01 14:25 ` Nishanth Menon 2013-08-01 14:25 ` Nishanth Menon 2013-08-01 15:18 ` Tero Kristo 2013-08-01 15:18 ` Tero Kristo 2013-08-01 15:24 ` Nishanth Menon 2013-08-01 15:24 ` Nishanth Menon 2013-08-01 15:30 ` Tero Kristo 2013-08-01 15:30 ` Tero Kristo 2013-08-02 7:22 ` Tony Lindgren 2013-08-02 7:22 ` Tony Lindgren 2013-07-23 7:20 ` [PATCHv4 06/33] CLK: omap: add autoidle support Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 18:56 ` Nishanth Menon 2013-07-30 18:56 ` Nishanth Menon 2013-07-31 10:13 ` Tero Kristo 2013-07-31 10:13 ` Tero Kristo 2013-08-01 14:11 ` Nishanth Menon 2013-08-01 14:11 ` Nishanth Menon 2013-08-01 15:22 ` Tero Kristo 2013-08-01 15:22 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 07/33] CLK: omap: add support for OMAP gate clock Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 19:17 ` Nishanth Menon 2013-07-30 19:17 ` Nishanth Menon 2013-07-31 14:45 ` Tero Kristo 2013-07-31 14:45 ` Tero Kristo 2013-08-01 14:33 ` Nishanth Menon 2013-08-01 14:33 ` Nishanth Menon 2013-08-01 15:29 ` Tero Kristo 2013-08-01 15:29 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 08/33] ARM: dts: omap4 clock data Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 19:27 ` Nishanth Menon 2013-07-30 19:27 ` Nishanth Menon 2013-07-31 14:49 ` Tero Kristo 2013-07-31 14:49 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 09/33] CLK: omap: add omap4 clock init file Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 19:33 ` Nishanth Menon 2013-07-30 19:33 ` Nishanth Menon 2013-07-31 14:52 ` Tero Kristo 2013-07-31 14:52 ` Tero Kristo 2013-08-01 14:40 ` Nishanth Menon 2013-08-01 14:40 ` Nishanth Menon 2013-08-01 15:34 ` Tero Kristo 2013-08-01 15:34 ` Tero Kristo 2013-08-01 16:10 ` Nishanth Menon 2013-08-01 16:10 ` Nishanth Menon 2013-07-23 7:20 ` [PATCHv4 10/33] ARM: OMAP4: remove old clock data and link in new clock init code Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 19:42 ` Nishanth Menon 2013-07-30 19:42 ` Nishanth Menon 2013-07-31 14:55 ` Tero Kristo 2013-07-31 14:55 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 11/33] ARM: dts: omap5 clock data Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 12/33] CLK: omap: add omap5 clock init file Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 13/33] ARM: dts: dra7 clock data Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 14/33] CLK: omap: add dra7 clock init file Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 15/33] CLK: OMAP: DPLL: add support for DT property ti,dpll-no-gate Tero Kristo 2013-07-23 7:20 ` [PATCHv4 15/33] CLK: OMAP: DPLL: add support for DT property ti, dpll-no-gate Tero Kristo 2013-07-30 19:18 ` [PATCHv4 15/33] CLK: OMAP: DPLL: add support for DT property ti,dpll-no-gate Nishanth Menon 2013-07-30 19:18 ` Nishanth Menon 2013-07-31 14:56 ` Tero Kristo 2013-07-31 14:56 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 16/33] CLK: OMAP: DPLL: do not of_iomap NULL autoidle register Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 19:49 ` Nishanth Menon 2013-07-30 19:49 ` Nishanth Menon 2013-07-31 14:57 ` Tero Kristo 2013-07-31 14:57 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 17/33] CLK: DT: add support for set-rate-parent flag Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 19:58 ` Nishanth Menon 2013-07-30 19:58 ` Nishanth Menon 2013-07-23 7:20 ` [PATCHv4 18/33] ARM: dts: am33xx clock data Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 19/33] CLK: omap: add am33xx clock init file Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 20:00 ` Nishanth Menon 2013-07-30 20:00 ` Nishanth Menon 2013-07-31 14:59 ` Tero Kristo 2013-07-31 14:59 ` Tero Kristo 2013-08-01 14:43 ` Nishanth Menon 2013-08-01 14:43 ` Nishanth Menon 2013-08-01 15:35 ` Tero Kristo 2013-08-01 15:35 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 20/33] ARM: AM33xx: remove old clock data and link in new clock init code Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 21/33] CLK: OMAP: DPLL: add omap3 dpll support Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 20:08 ` Nishanth Menon 2013-07-30 20:08 ` Nishanth Menon 2013-07-31 15:03 ` Tero Kristo 2013-07-31 15:03 ` Tero Kristo 2013-08-01 14:46 ` Nishanth Menon [this message] 2013-08-01 14:46 ` Nishanth Menon 2013-07-23 7:20 ` [PATCHv4 22/33] CLK: OMAP: update gate clock setup for OMAP3 Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 20:13 ` Nishanth Menon 2013-07-30 20:13 ` Nishanth Menon 2013-07-31 15:05 ` Tero Kristo 2013-07-31 15:05 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 23/33] CLK: OMAP: add interface clock support " Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-30 20:23 ` Nishanth Menon 2013-07-30 20:23 ` Nishanth Menon 2013-07-31 15:09 ` Tero Kristo 2013-07-31 15:09 ` Tero Kristo 2013-08-01 14:50 ` Nishanth Menon 2013-08-01 14:50 ` Nishanth Menon 2013-07-23 7:20 ` [PATCHv4 24/33] CLK: OMAP: move some defines from machine to driver header Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 25/33] ARM: OMAP: hwmod: fix an incorrect clk type cast with _get_clkdm Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 26/33] CLK: omap: gate: add support for OMAP36xx dpllx_mx_ck:s Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 27/33] ARM: OMAP3: hwmod: initialize clkdm from clkdm_name Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 28/33] ARM: dts: omap3 clock data Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 30/33] clk: OMAP: DRA7: Add APLL support Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 31/33] ARM: dts: clk: Add apll related clocks Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 32/33] clk: OMAP: DRA7: Change apll_pcie_m2_ck to fixed factor clock Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 7:20 ` [PATCHv4 33/33] clk: DTS: DRA7: Add PCIe related clock nodes Tero Kristo 2013-07-23 7:20 ` Tero Kristo 2013-07-23 8:24 ` [PATCHv4 00/33] ARM: OMAP: clock conversion to DT Tero Kristo 2013-07-23 8:24 ` Tero Kristo 2013-07-24 14:16 ` Roger Quadros 2013-07-24 14:16 ` Roger Quadros 2013-07-24 14:29 ` Tero Kristo 2013-07-24 14:29 ` Tero Kristo 2013-07-24 14:34 ` Roger Quadros 2013-07-24 14:34 ` Roger Quadros 2013-07-24 14:43 ` Tero Kristo 2013-07-24 14:43 ` Tero Kristo [not found] ` <1374564028-11352-30-git-send-email-t-kristo@ti.com> 2013-07-30 20:19 ` [PATCHv4 29/33] CLK: omap: add omap3 clock init file Nishanth Menon 2013-07-30 20:19 ` Nishanth Menon 2013-07-31 6:35 ` Tony Lindgren 2013-07-31 6:35 ` Tony Lindgren 2013-07-31 15:10 ` Tero Kristo 2013-07-31 15:10 ` Tero Kristo 2013-08-02 7:24 ` Tony Lindgren 2013-08-02 7:24 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51FA74AE.8050704@ti.com \ --to=nm@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=mturquette@linaro.org \ --cc=paul@pwsan.com \ --cc=rnayak@ti.com \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.