From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Jean-Francois Moine <moinejf@free.fr>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>, Jason Cooper <jason@lakedaemon.net>, Pawel Moll <pawel.moll@arm.com>, Stephen Warren <swarren@wwwdotorg.org>, linux-kernel@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>, Gregory CLEMENT <gregory.clement@free-electrons.com>, linux-arm-kernel@lists.infradead.org, Ian Campbell <ian.campbell@citrix.com> Subject: Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT Date: Wed, 28 Aug 2013 13:44:51 +0200 [thread overview] Message-ID: <521DE2B3.9050508@gmail.com> (raw) In-Reply-To: <20130828131548.0009d613@skate> On 08/28/13 13:15, Thomas Petazzoni wrote: > On Wed, 28 Aug 2013 12:26:31 +0200, Sebastian Hesselbarth wrote: >>>> as Mark Brown already took the bindings patch for above generic >>>> compatible, how are we going to discriminate different >>>> implementations/features of Dove, Kirkwood, and Armada 370? >>> >>> I agree that mvebu-audio is not a really good compatible string. It >>> should use the first SoC that introduced the IP block, so that if >>> future SOCs have variations, we can introduce separate compatible >>> strings. >>> >>> So for now, the compatible string should be kirkwood-audio. >> >> Unfortunately, mvebu-audio has already been taken by Mark. Also, we >> know the differences for the three SoCs now and should have a compatible >> for each (and maybe mvebu-audio for fallback). > > For 3.12, right? So 3.12 hasn't been released yet, so it's still time > to fix this. I guess, yes. >> Also, we'll need to distinguish between the different audio controllers >> on a single SoC, i.e. i2s0 and i2s1. I suggest checking the (phys) reg >> base passed. > > For what reason does the driver needs to know whether it's the instance > 0 or instance 1 ? If it's needed for some specific reason, then there > should probably be something like marvell,i2s-channel-id = <0> and > marvell,i2s-channel-id = <1>. On Dove, audio1 has SPDIF out, audio0 hasn't. Russell also mentioned to get rid of "i2s" and use "audio" instead. Most SoC's controllers are i2s only but as soon as SPDIF comes into play, it is a different interface protocol. I am fine with having a "marvell,channel-id" (no "i2s") to discriminate the instances, although reg offset should be sufficient. Jean-Francois: Can you please also rename the DT nodes to "audio0" and "audio1" instead? Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] ARM: Dove: Add the audio devices in DT Date: Wed, 28 Aug 2013 13:44:51 +0200 [thread overview] Message-ID: <521DE2B3.9050508@gmail.com> (raw) In-Reply-To: <20130828131548.0009d613@skate> On 08/28/13 13:15, Thomas Petazzoni wrote: > On Wed, 28 Aug 2013 12:26:31 +0200, Sebastian Hesselbarth wrote: >>>> as Mark Brown already took the bindings patch for above generic >>>> compatible, how are we going to discriminate different >>>> implementations/features of Dove, Kirkwood, and Armada 370? >>> >>> I agree that mvebu-audio is not a really good compatible string. It >>> should use the first SoC that introduced the IP block, so that if >>> future SOCs have variations, we can introduce separate compatible >>> strings. >>> >>> So for now, the compatible string should be kirkwood-audio. >> >> Unfortunately, mvebu-audio has already been taken by Mark. Also, we >> know the differences for the three SoCs now and should have a compatible >> for each (and maybe mvebu-audio for fallback). > > For 3.12, right? So 3.12 hasn't been released yet, so it's still time > to fix this. I guess, yes. >> Also, we'll need to distinguish between the different audio controllers >> on a single SoC, i.e. i2s0 and i2s1. I suggest checking the (phys) reg >> base passed. > > For what reason does the driver needs to know whether it's the instance > 0 or instance 1 ? If it's needed for some specific reason, then there > should probably be something like marvell,i2s-channel-id = <0> and > marvell,i2s-channel-id = <1>. On Dove, audio1 has SPDIF out, audio0 hasn't. Russell also mentioned to get rid of "i2s" and use "audio" instead. Most SoC's controllers are i2s only but as soon as SPDIF comes into play, it is a different interface protocol. I am fine with having a "marvell,channel-id" (no "i2s") to discriminate the instances, although reg offset should be sufficient. Jean-Francois: Can you please also rename the DT nodes to "audio0" and "audio1" instead? Sebastian
next prev parent reply other threads:[~2013-08-28 11:44 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-28 9:34 [PATCH 1/2] ARM: Dove: Add the audio devices in DT Jean-Francois Moine 2013-08-28 9:34 ` Jean-Francois Moine 2013-08-28 10:13 ` Sebastian Hesselbarth 2013-08-28 10:13 ` Sebastian Hesselbarth 2013-08-28 10:13 ` Sebastian Hesselbarth 2013-08-28 10:19 ` Thomas Petazzoni 2013-08-28 10:19 ` Thomas Petazzoni 2013-08-28 10:19 ` Thomas Petazzoni 2013-08-28 10:26 ` Sebastian Hesselbarth 2013-08-28 10:26 ` Sebastian Hesselbarth 2013-08-28 10:26 ` Sebastian Hesselbarth 2013-08-28 11:15 ` Thomas Petazzoni 2013-08-28 11:15 ` Thomas Petazzoni 2013-08-28 11:44 ` Sebastian Hesselbarth [this message] 2013-08-28 11:44 ` Sebastian Hesselbarth 2013-08-28 11:58 ` Thomas Petazzoni 2013-08-28 11:58 ` Thomas Petazzoni 2013-08-28 12:13 ` Russell King - ARM Linux 2013-08-28 12:13 ` Russell King - ARM Linux 2013-08-28 12:29 ` Thomas Petazzoni 2013-08-28 12:29 ` Thomas Petazzoni 2013-08-28 12:42 ` Russell King - ARM Linux 2013-08-28 12:42 ` Russell King - ARM Linux 2013-08-28 12:51 ` Thomas Petazzoni 2013-08-28 12:51 ` Thomas Petazzoni 2013-08-28 13:58 ` Russell King - ARM Linux 2013-08-28 13:58 ` Russell King - ARM Linux 2013-08-28 12:16 ` Sebastian Hesselbarth 2013-08-28 12:16 ` Sebastian Hesselbarth 2013-08-29 10:07 ` Jean-Francois Moine 2013-08-29 10:07 ` Jean-Francois Moine 2013-08-29 10:13 ` Russell King - ARM Linux 2013-08-29 10:13 ` Russell King - ARM Linux 2013-08-29 11:01 ` Sebastian Hesselbarth 2013-08-29 11:01 ` Sebastian Hesselbarth 2013-08-30 15:08 ` Russell King - ARM Linux 2013-08-30 15:08 ` Russell King - ARM Linux 2013-08-29 9:46 ` Jean-Francois Moine 2013-08-29 9:46 ` Jean-Francois Moine 2013-08-29 16:12 ` Mark Brown 2013-08-29 16:12 ` Mark Brown 2013-08-29 16:33 ` Russell King - ARM Linux 2013-08-29 16:33 ` Russell King - ARM Linux 2013-08-29 17:12 ` Mark Brown 2013-08-29 17:12 ` Mark Brown 2013-08-29 18:02 ` Sebastian Hesselbarth 2013-08-29 18:02 ` Sebastian Hesselbarth 2013-08-29 18:20 ` Mark Brown 2013-08-29 18:20 ` Mark Brown 2013-08-29 18:34 ` Russell King - ARM Linux 2013-08-29 18:34 ` Russell King - ARM Linux 2013-08-28 19:49 ` Sergei Shtylyov 2013-08-28 19:49 ` Sergei Shtylyov 2013-08-29 9:38 ` Jean-Francois Moine 2013-08-29 9:38 ` Jean-Francois Moine 2013-08-29 14:13 ` Sergei Shtylyov 2013-08-29 14:13 ` Sergei Shtylyov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=521DE2B3.9050508@gmail.com \ --to=sebastian.hesselbarth@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@free-electrons.com \ --cc=ian.campbell@citrix.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=moinejf@free.fr \ --cc=pawel.moll@arm.com \ --cc=rob.herring@calxeda.com \ --cc=swarren@wwwdotorg.org \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.