All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Robert Richter <rric@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Russell King <linux@arm.linux.org.uk>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm, kbuild: make "make install" not depend on vmlinux
Date: Wed, 09 Oct 2013 12:28:10 +0200	[thread overview]
Message-ID: <52552FBA.7040806@suse.cz> (raw)
In-Reply-To: <CAMuHMdW-YWGgZjR9ow6FMW7BrOorbbVAEm9sYsVvPkfg-_=jag@mail.gmail.com>

On 9.10.2013 09:18, Geert Uytterhoeven wrote:
> On Mon, Sep 30, 2013 at 6:31 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>> On 2013-09-30 10:49 +0200, Robert Richter spake thusly:
>>> On 18.07.13 11:22:24, Michal Marek wrote:
>>>>> So Michal (or ARM people - whoever wants to take the patch), just take
>>>>> my ack. No objections.
>>>>
>>>> I can add it to the kbuild tree if needed. Otherwise you can add
>>>> Acked-by: Michal Marek <mmarek@suse.cz>.
>>>
>>> This didn't make it upstream yet, can somebody at it to a tree?
>>
>> Since it's been acked-by Linus, I'll queue it in my tree, for Michal to
>> pull from. Expect a pull-request soon.
> 
> Sorry for chiming in that late, but I didn't think of this when reading the
> original submission.
> 
> Just doing "make oldconfig; make install" used to work.

On ARM and maybe other architectures.


> Removing the dependency of "make vmlinux" on vmlinux breaks this, doesn't it?

Yes.


> I had the habit of doing the above many years ago, when I was mostly doing
> native builds, and before I had my own custom linux-install-kernel
> script that e.g.
> knows how to copy kernels and modules around to NFS servers.
> 
> Not that I'm strongly attached to it, but there may be other users...

We can't eat the cake and have it :). What can be done is to make
arch/arm/boot/install.sh print a friendlier error message, like the x86
version does:

if [ ! -f "$1" ]; then
	echo ""                                                   1>&2
	echo " *** Missing file: $1"                              1>&2
	echo ' *** You need to run "make" before "make install".' 1>&2
	echo ""                                                   1>&2
	exit 1
fi

Michal

WARNING: multiple messages have this Message-ID (diff)
From: mmarek@suse.cz (Michal Marek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm, kbuild: make "make install" not depend on vmlinux
Date: Wed, 09 Oct 2013 12:28:10 +0200	[thread overview]
Message-ID: <52552FBA.7040806@suse.cz> (raw)
In-Reply-To: <CAMuHMdW-YWGgZjR9ow6FMW7BrOorbbVAEm9sYsVvPkfg-_=jag@mail.gmail.com>

On 9.10.2013 09:18, Geert Uytterhoeven wrote:
> On Mon, Sep 30, 2013 at 6:31 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>> On 2013-09-30 10:49 +0200, Robert Richter spake thusly:
>>> On 18.07.13 11:22:24, Michal Marek wrote:
>>>>> So Michal (or ARM people - whoever wants to take the patch), just take
>>>>> my ack. No objections.
>>>>
>>>> I can add it to the kbuild tree if needed. Otherwise you can add
>>>> Acked-by: Michal Marek <mmarek@suse.cz>.
>>>
>>> This didn't make it upstream yet, can somebody at it to a tree?
>>
>> Since it's been acked-by Linus, I'll queue it in my tree, for Michal to
>> pull from. Expect a pull-request soon.
> 
> Sorry for chiming in that late, but I didn't think of this when reading the
> original submission.
> 
> Just doing "make oldconfig; make install" used to work.

On ARM and maybe other architectures.


> Removing the dependency of "make vmlinux" on vmlinux breaks this, doesn't it?

Yes.


> I had the habit of doing the above many years ago, when I was mostly doing
> native builds, and before I had my own custom linux-install-kernel
> script that e.g.
> knows how to copy kernels and modules around to NFS servers.
> 
> Not that I'm strongly attached to it, but there may be other users...

We can't eat the cake and have it :). What can be done is to make
arch/arm/boot/install.sh print a friendlier error message, like the x86
version does:

if [ ! -f "$1" ]; then
	echo ""                                                   1>&2
	echo " *** Missing file: $1"                              1>&2
	echo ' *** You need to run "make" before "make install".' 1>&2
	echo ""                                                   1>&2
	exit 1
fi

Michal

  reply	other threads:[~2013-10-09 10:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 13:37 [GIT] kbuild changes for v3.11-rc1 Michal Marek
2013-07-11  2:11 ` Linus Torvalds
2013-07-11  4:26   ` Greg KH
2013-07-11 13:54   ` Michal Marek
2013-07-11 13:54     ` Michal Marek
2013-07-11 17:16     ` Linus Torvalds
2013-07-12 10:57       ` Robert Richter
2013-07-17 16:05         ` [PATCH] arm, kbuild: make "make install" not depend on vmlinux Robert Richter
2013-07-17 16:05           ` Robert Richter
2013-07-17 16:05           ` Robert Richter
2013-07-17 16:36           ` Linus Torvalds
2013-07-17 16:36             ` Linus Torvalds
2013-07-17 16:36             ` Linus Torvalds
2013-07-17 16:57             ` Robert Richter
2013-07-17 16:57               ` Robert Richter
2013-07-17 16:57               ` Robert Richter
2013-07-17 17:03               ` Linus Torvalds
2013-07-17 17:03                 ` Linus Torvalds
2013-07-17 17:03                 ` Linus Torvalds
2013-07-18  9:22                 ` Michal Marek
2013-07-18  9:22                   ` Michal Marek
2013-07-18  9:22                   ` Michal Marek
2013-09-30  8:49                   ` Robert Richter
2013-09-30  8:49                     ` Robert Richter
2013-09-30  8:49                     ` Robert Richter
2013-09-30 16:31                     ` Yann E. MORIN
2013-09-30 16:31                       ` Yann E. MORIN
2013-09-30 16:31                       ` Yann E. MORIN
2013-10-09  7:18                       ` Geert Uytterhoeven
2013-10-09  7:18                         ` Geert Uytterhoeven
2013-10-09  7:18                         ` Geert Uytterhoeven
2013-10-09 10:28                         ` Michal Marek [this message]
2013-10-09 10:28                           ` Michal Marek
2013-10-09 10:28                           ` Michal Marek
2013-10-09 10:46                           ` Geert Uytterhoeven
2013-10-09 10:46                             ` Geert Uytterhoeven
2013-10-09 10:46                             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52552FBA.7040806@suse.cz \
    --to=mmarek@suse.cz \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rric@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.