From: Linus Torvalds <torvalds@linux-foundation.org>
To: Robert Richter <rric@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>,
Michal Marek <mmarek@suse.cz>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm, kbuild: make "make install" not depend on vmlinux
Date: Wed, 17 Jul 2013 09:36:57 -0700 [thread overview]
Message-ID: <CA+55aFx4G5gME3ByqE0Wr-_t2x_6WkP3Ta4k1z4jfW+PrcK0og@mail.gmail.com> (raw)
In-Reply-To: <20130717160506.GI8731@rric.localhost>
On Wed, Jul 17, 2013 at 9:05 AM, Robert Richter <rric@kernel.org> wrote:
>
> I narrowed this down. The problem is that zinstall on ARCH=arm has a
> dependency to vmlinux which does a prepare/prepare3 and finally does a
> forced rebuild of kernel.release even if it exists already.
>
> Rebuilding it removes kernel.release first and then recreates it. This
> might race with another parallel make job running depmod.
>
> So on arm and maybe other archs we need the same as for x86:
>
> 1648e4f8 x86, kbuild: make "make install" not depend on vmlinux
>
> The patch below fixes this for arm. It is build-tested in my
> environment, but please test it in others too if possible.
Ack. This looks like the right thing to do.
That said, I think for clarity you might perhaps want to make the
unrelated change of adding double quotes around $(KERNELRELEASE) a
separate patch. Not a big deal, but it took me a moment to say "why
did he do that" (in fact, I'm not sure KERNEL_RELEASE can actually
validly have spaces in it, but quoting it is certainly not wrong
either - but it might be unnecessary.
Linus
WARNING: multiple messages have this Message-ID (diff)
From: torvalds@linux-foundation.org (Linus Torvalds)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm, kbuild: make "make install" not depend on vmlinux
Date: Wed, 17 Jul 2013 09:36:57 -0700 [thread overview]
Message-ID: <CA+55aFx4G5gME3ByqE0Wr-_t2x_6WkP3Ta4k1z4jfW+PrcK0og@mail.gmail.com> (raw)
In-Reply-To: <20130717160506.GI8731@rric.localhost>
On Wed, Jul 17, 2013 at 9:05 AM, Robert Richter <rric@kernel.org> wrote:
>
> I narrowed this down. The problem is that zinstall on ARCH=arm has a
> dependency to vmlinux which does a prepare/prepare3 and finally does a
> forced rebuild of kernel.release even if it exists already.
>
> Rebuilding it removes kernel.release first and then recreates it. This
> might race with another parallel make job running depmod.
>
> So on arm and maybe other archs we need the same as for x86:
>
> 1648e4f8 x86, kbuild: make "make install" not depend on vmlinux
>
> The patch below fixes this for arm. It is build-tested in my
> environment, but please test it in others too if possible.
Ack. This looks like the right thing to do.
That said, I think for clarity you might perhaps want to make the
unrelated change of adding double quotes around $(KERNELRELEASE) a
separate patch. Not a big deal, but it took me a moment to say "why
did he do that" (in fact, I'm not sure KERNEL_RELEASE can actually
validly have spaces in it, but quoting it is certainly not wrong
either - but it might be unnecessary.
Linus
next prev parent reply other threads:[~2013-07-17 16:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 13:37 [GIT] kbuild changes for v3.11-rc1 Michal Marek
2013-07-11 2:11 ` Linus Torvalds
2013-07-11 4:26 ` Greg KH
2013-07-11 13:54 ` Michal Marek
2013-07-11 13:54 ` Michal Marek
2013-07-11 17:16 ` Linus Torvalds
2013-07-12 10:57 ` Robert Richter
2013-07-17 16:05 ` [PATCH] arm, kbuild: make "make install" not depend on vmlinux Robert Richter
2013-07-17 16:05 ` Robert Richter
2013-07-17 16:05 ` Robert Richter
2013-07-17 16:36 ` Linus Torvalds [this message]
2013-07-17 16:36 ` Linus Torvalds
2013-07-17 16:36 ` Linus Torvalds
2013-07-17 16:57 ` Robert Richter
2013-07-17 16:57 ` Robert Richter
2013-07-17 16:57 ` Robert Richter
2013-07-17 17:03 ` Linus Torvalds
2013-07-17 17:03 ` Linus Torvalds
2013-07-17 17:03 ` Linus Torvalds
2013-07-18 9:22 ` Michal Marek
2013-07-18 9:22 ` Michal Marek
2013-07-18 9:22 ` Michal Marek
2013-09-30 8:49 ` Robert Richter
2013-09-30 8:49 ` Robert Richter
2013-09-30 8:49 ` Robert Richter
2013-09-30 16:31 ` Yann E. MORIN
2013-09-30 16:31 ` Yann E. MORIN
2013-09-30 16:31 ` Yann E. MORIN
2013-10-09 7:18 ` Geert Uytterhoeven
2013-10-09 7:18 ` Geert Uytterhoeven
2013-10-09 7:18 ` Geert Uytterhoeven
2013-10-09 10:28 ` Michal Marek
2013-10-09 10:28 ` Michal Marek
2013-10-09 10:28 ` Michal Marek
2013-10-09 10:46 ` Geert Uytterhoeven
2013-10-09 10:46 ` Geert Uytterhoeven
2013-10-09 10:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFx4G5gME3ByqE0Wr-_t2x_6WkP3Ta4k1z4jfW+PrcK0og@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mmarek@suse.cz \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.