All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: vinod.koul@intel.com
Cc: Simon Horman <horms@verge.net.au>,
	dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
Date: Wed, 09 Oct 2013 17:15:01 +0000	[thread overview]
Message-ID: <52559CCC.4040809@cogentembedded.com> (raw)
In-Reply-To: <20131003040031.GA7925@verge.net.au>

Hello.

On 03-10-2013 6:00, Simon Horman wrote:

>>> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
>>> resource allocation) got rid of shdma_free_irq() but  unfortunately got merged
>>> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
>>> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:

>>> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
>>> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
>>> `shdma_free_irq'

>>> Fix this compilation error by removing the remaining shdma_free_irq() calls.

>> Tested-by: Simon Horman <horms+renesas@verge.net.au>

>>> Reported-by: Simon Horman <horms@verge.net.au>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Vinod, could you consider taking this and the following patch
> as a fix for v3.12?

    Vinod, may I ask when these regression (induced by you) fixes gets merged?

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: vinod.koul@intel.com
Cc: Simon Horman <horms@verge.net.au>,
	dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
Date: Wed, 09 Oct 2013 20:13:32 +0200	[thread overview]
Message-ID: <52559CCC.4040809@cogentembedded.com> (raw)
In-Reply-To: <20131003040031.GA7925@verge.net.au>

Hello.

On 03-10-2013 6:00, Simon Horman wrote:

>>> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
>>> resource allocation) got rid of shdma_free_irq() but  unfortunately got merged
>>> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
>>> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:

>>> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
>>> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
>>> `shdma_free_irq'

>>> Fix this compilation error by removing the remaining shdma_free_irq() calls.

>> Tested-by: Simon Horman <horms+renesas@verge.net.au>

>>> Reported-by: Simon Horman <horms@verge.net.au>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Vinod, could you consider taking this and the following patch
> as a fix for v3.12?

    Vinod, may I ask when these regression (induced by you) fixes gets merged?

WBR, Sergei


  reply	other threads:[~2013-10-09 17:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 22:28 [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls Sergei Shtylyov
2013-09-25 22:28 ` Sergei Shtylyov
2013-09-26  2:14 ` Simon Horman
2013-09-26  2:14   ` Simon Horman
2013-10-03  4:00   ` Simon Horman
2013-10-03  4:00     ` Simon Horman
2013-10-09 17:15     ` Sergei Shtylyov [this message]
2013-10-09 18:13       ` Sergei Shtylyov
2013-10-11  1:55 ` Vinod Koul
2013-10-11  2:07   ` Vinod Koul
2013-10-15  0:42   ` Simon Horman
2013-10-15  0:42     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52559CCC.4040809@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=dan.j.williams@intel.com \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.