* [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
@ 2013-09-25 22:28 ` Sergei Shtylyov
0 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2013-09-25 22:28 UTC (permalink / raw)
To: vinod.koul, dan.j.williams; +Cc: linux-kernel, linux-sh, horms
Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
resource allocation) got rid of shdma_free_irq() but unfortunately got merged
later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
`shdma_free_irq'
Fix this compilation error by removing the remaining shdma_free_irq() calls.
Reported-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo.
drivers/dma/sh/rcar-hpbdma.c | 2 --
1 file changed, 2 deletions(-)
Index: slave-dma/drivers/dma/sh/rcar-hpbdma.c
=================================--- slave-dma.orig/drivers/dma/sh/rcar-hpbdma.c
+++ slave-dma/drivers/dma/sh/rcar-hpbdma.c
@@ -432,7 +432,6 @@ hpb_dmae_alloc_chan_resources(struct hpb
hpb_chan->xfer_mode = XFER_DOUBLE;
} else {
dev_err(hpb_chan->shdma_chan.dev, "DCR setting error");
- shdma_free_irq(&hpb_chan->shdma_chan);
return -EINVAL;
}
@@ -614,7 +613,6 @@ static void hpb_dmae_chan_remove(struct
shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) {
BUG_ON(!schan);
- shdma_free_irq(schan);
shdma_chan_remove(schan);
}
dma_dev->chancnt = 0;
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
@ 2013-09-25 22:28 ` Sergei Shtylyov
0 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2013-09-25 22:28 UTC (permalink / raw)
To: vinod.koul, dan.j.williams; +Cc: linux-kernel, linux-sh, horms
Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
resource allocation) got rid of shdma_free_irq() but unfortunately got merged
later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
`shdma_free_irq'
Fix this compilation error by removing the remaining shdma_free_irq() calls.
Reported-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo.
drivers/dma/sh/rcar-hpbdma.c | 2 --
1 file changed, 2 deletions(-)
Index: slave-dma/drivers/dma/sh/rcar-hpbdma.c
===================================================================
--- slave-dma.orig/drivers/dma/sh/rcar-hpbdma.c
+++ slave-dma/drivers/dma/sh/rcar-hpbdma.c
@@ -432,7 +432,6 @@ hpb_dmae_alloc_chan_resources(struct hpb
hpb_chan->xfer_mode = XFER_DOUBLE;
} else {
dev_err(hpb_chan->shdma_chan.dev, "DCR setting error");
- shdma_free_irq(&hpb_chan->shdma_chan);
return -EINVAL;
}
@@ -614,7 +613,6 @@ static void hpb_dmae_chan_remove(struct
shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) {
BUG_ON(!schan);
- shdma_free_irq(schan);
shdma_chan_remove(schan);
}
dma_dev->chancnt = 0;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
2013-09-25 22:28 ` Sergei Shtylyov
@ 2013-09-26 2:14 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-09-26 2:14 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: vinod.koul, dan.j.williams, linux-kernel, linux-sh
On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
>
> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> `shdma_free_irq'
>
> Fix this compilation error by removing the remaining shdma_free_irq() calls.
Tested-by: Simon Horman <horms+renesas@verge.net.au>
> Reported-by: Simon Horman <horms@verge.net.au>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo.
>
> drivers/dma/sh/rcar-hpbdma.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: slave-dma/drivers/dma/sh/rcar-hpbdma.c
> =================================> --- slave-dma.orig/drivers/dma/sh/rcar-hpbdma.c
> +++ slave-dma/drivers/dma/sh/rcar-hpbdma.c
> @@ -432,7 +432,6 @@ hpb_dmae_alloc_chan_resources(struct hpb
> hpb_chan->xfer_mode = XFER_DOUBLE;
> } else {
> dev_err(hpb_chan->shdma_chan.dev, "DCR setting error");
> - shdma_free_irq(&hpb_chan->shdma_chan);
> return -EINVAL;
> }
>
> @@ -614,7 +613,6 @@ static void hpb_dmae_chan_remove(struct
> shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) {
> BUG_ON(!schan);
>
> - shdma_free_irq(schan);
> shdma_chan_remove(schan);
> }
> dma_dev->chancnt = 0;
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
@ 2013-09-26 2:14 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-09-26 2:14 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: vinod.koul, dan.j.williams, linux-kernel, linux-sh
On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
>
> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> `shdma_free_irq'
>
> Fix this compilation error by removing the remaining shdma_free_irq() calls.
Tested-by: Simon Horman <horms+renesas@verge.net.au>
> Reported-by: Simon Horman <horms@verge.net.au>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo.
>
> drivers/dma/sh/rcar-hpbdma.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: slave-dma/drivers/dma/sh/rcar-hpbdma.c
> ===================================================================
> --- slave-dma.orig/drivers/dma/sh/rcar-hpbdma.c
> +++ slave-dma/drivers/dma/sh/rcar-hpbdma.c
> @@ -432,7 +432,6 @@ hpb_dmae_alloc_chan_resources(struct hpb
> hpb_chan->xfer_mode = XFER_DOUBLE;
> } else {
> dev_err(hpb_chan->shdma_chan.dev, "DCR setting error");
> - shdma_free_irq(&hpb_chan->shdma_chan);
> return -EINVAL;
> }
>
> @@ -614,7 +613,6 @@ static void hpb_dmae_chan_remove(struct
> shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) {
> BUG_ON(!schan);
>
> - shdma_free_irq(schan);
> shdma_chan_remove(schan);
> }
> dma_dev->chancnt = 0;
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
2013-09-26 2:14 ` Simon Horman
@ 2013-10-03 4:00 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-03 4:00 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: vinod.koul, dan.j.williams, linux-kernel, linux-sh
On Thu, Sep 26, 2013 at 11:14:17AM +0900, Simon Horman wrote:
> On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> > Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> > resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> > later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> > R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
> >
> > drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> > drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> > `shdma_free_irq'
> >
> > Fix this compilation error by removing the remaining shdma_free_irq() calls.
>
> Tested-by: Simon Horman <horms+renesas@verge.net.au>
>
> > Reported-by: Simon Horman <horms@verge.net.au>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Vinod, could you consider taking this and the following patch
as a fix for v3.12?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
@ 2013-10-03 4:00 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-03 4:00 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: vinod.koul, dan.j.williams, linux-kernel, linux-sh
On Thu, Sep 26, 2013 at 11:14:17AM +0900, Simon Horman wrote:
> On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> > Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> > resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> > later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> > R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
> >
> > drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> > drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> > `shdma_free_irq'
> >
> > Fix this compilation error by removing the remaining shdma_free_irq() calls.
>
> Tested-by: Simon Horman <horms+renesas@verge.net.au>
>
> > Reported-by: Simon Horman <horms@verge.net.au>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Vinod, could you consider taking this and the following patch
as a fix for v3.12?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
2013-10-03 4:00 ` Simon Horman
@ 2013-10-09 18:13 ` Sergei Shtylyov
-1 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2013-10-09 17:15 UTC (permalink / raw)
To: vinod.koul; +Cc: Simon Horman, dan.j.williams, linux-kernel, linux-sh
Hello.
On 03-10-2013 6:00, Simon Horman wrote:
>>> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
>>> resource allocation) got rid of shdma_free_irq() but unfortunately got merged
>>> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
>>> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
>>> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
>>> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
>>> `shdma_free_irq'
>>> Fix this compilation error by removing the remaining shdma_free_irq() calls.
>> Tested-by: Simon Horman <horms+renesas@verge.net.au>
>>> Reported-by: Simon Horman <horms@verge.net.au>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Vinod, could you consider taking this and the following patch
> as a fix for v3.12?
Vinod, may I ask when these regression (induced by you) fixes gets merged?
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
@ 2013-10-09 18:13 ` Sergei Shtylyov
0 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2013-10-09 18:13 UTC (permalink / raw)
To: vinod.koul; +Cc: Simon Horman, dan.j.williams, linux-kernel, linux-sh
Hello.
On 03-10-2013 6:00, Simon Horman wrote:
>>> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
>>> resource allocation) got rid of shdma_free_irq() but unfortunately got merged
>>> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
>>> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
>>> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
>>> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
>>> `shdma_free_irq'
>>> Fix this compilation error by removing the remaining shdma_free_irq() calls.
>> Tested-by: Simon Horman <horms+renesas@verge.net.au>
>>> Reported-by: Simon Horman <horms@verge.net.au>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Vinod, could you consider taking this and the following patch
> as a fix for v3.12?
Vinod, may I ask when these regression (induced by you) fixes gets merged?
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
2013-09-25 22:28 ` Sergei Shtylyov
@ 2013-10-11 2:07 ` Vinod Koul
-1 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2013-10-11 1:55 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: dan.j.williams, linux-kernel, linux-sh, horms
On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
>
> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> `shdma_free_irq'
>
> Fix this compilation error by removing the remaining shdma_free_irq() calls.
>
> Reported-by: Simon Horman <horms@verge.net.au>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied both, Thanks
~Vinod
>
> ---
> The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo.
>
> drivers/dma/sh/rcar-hpbdma.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: slave-dma/drivers/dma/sh/rcar-hpbdma.c
> ===================================================================
> --- slave-dma.orig/drivers/dma/sh/rcar-hpbdma.c
> +++ slave-dma/drivers/dma/sh/rcar-hpbdma.c
> @@ -432,7 +432,6 @@ hpb_dmae_alloc_chan_resources(struct hpb
> hpb_chan->xfer_mode = XFER_DOUBLE;
> } else {
> dev_err(hpb_chan->shdma_chan.dev, "DCR setting error");
> - shdma_free_irq(&hpb_chan->shdma_chan);
> return -EINVAL;
> }
>
> @@ -614,7 +613,6 @@ static void hpb_dmae_chan_remove(struct
> shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) {
> BUG_ON(!schan);
>
> - shdma_free_irq(schan);
> shdma_chan_remove(schan);
> }
> dma_dev->chancnt = 0;
--
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
@ 2013-10-11 2:07 ` Vinod Koul
0 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2013-10-11 2:07 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: dan.j.williams, linux-kernel, linux-sh, horms
On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
>
> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> `shdma_free_irq'
>
> Fix this compilation error by removing the remaining shdma_free_irq() calls.
>
> Reported-by: Simon Horman <horms@verge.net.au>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied both, Thanks
~Vinod
>
> ---
> The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo.
>
> drivers/dma/sh/rcar-hpbdma.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: slave-dma/drivers/dma/sh/rcar-hpbdma.c
> =================================> --- slave-dma.orig/drivers/dma/sh/rcar-hpbdma.c
> +++ slave-dma/drivers/dma/sh/rcar-hpbdma.c
> @@ -432,7 +432,6 @@ hpb_dmae_alloc_chan_resources(struct hpb
> hpb_chan->xfer_mode = XFER_DOUBLE;
> } else {
> dev_err(hpb_chan->shdma_chan.dev, "DCR setting error");
> - shdma_free_irq(&hpb_chan->shdma_chan);
> return -EINVAL;
> }
>
> @@ -614,7 +613,6 @@ static void hpb_dmae_chan_remove(struct
> shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) {
> BUG_ON(!schan);
>
> - shdma_free_irq(schan);
> shdma_chan_remove(schan);
> }
> dma_dev->chancnt = 0;
--
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
2013-10-11 2:07 ` Vinod Koul
@ 2013-10-15 0:42 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-15 0:42 UTC (permalink / raw)
To: Vinod Koul; +Cc: Sergei Shtylyov, dan.j.williams, linux-kernel, linux-sh
On Fri, Oct 11, 2013 at 07:25:02AM +0530, Vinod Koul wrote:
> On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> > Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> > resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> > later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> > R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
> >
> > drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> > drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> > `shdma_free_irq'
> >
> > Fix this compilation error by removing the remaining shdma_free_irq() calls.
> >
> > Reported-by: Simon Horman <horms@verge.net.au>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied both, Thanks
Thanks!
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls
@ 2013-10-15 0:42 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-15 0:42 UTC (permalink / raw)
To: Vinod Koul; +Cc: Sergei Shtylyov, dan.j.williams, linux-kernel, linux-sh
On Fri, Oct 11, 2013 at 07:25:02AM +0530, Vinod Koul wrote:
> On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote:
> > Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
> > resource allocation) got rid of shdma_free_irq() but unfortunately got merged
> > later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
> > R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:
> >
> > drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
> > drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
> > `shdma_free_irq'
> >
> > Fix this compilation error by removing the remaining shdma_free_irq() calls.
> >
> > Reported-by: Simon Horman <horms@verge.net.au>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied both, Thanks
Thanks!
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-10-15 0:42 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-25 22:28 [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls Sergei Shtylyov
2013-09-25 22:28 ` Sergei Shtylyov
2013-09-26 2:14 ` Simon Horman
2013-09-26 2:14 ` Simon Horman
2013-10-03 4:00 ` Simon Horman
2013-10-03 4:00 ` Simon Horman
2013-10-09 17:15 ` Sergei Shtylyov
2013-10-09 18:13 ` Sergei Shtylyov
2013-10-11 1:55 ` Vinod Koul
2013-10-11 2:07 ` Vinod Koul
2013-10-15 0:42 ` Simon Horman
2013-10-15 0:42 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.