From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com> To: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: The development of GRUB 2 <grub-devel@gnu.org>, Fabio Fantoni <fabio.fantoni@m2r.biz>, xen-devel <xen-devel@lists.xensource.com> Subject: Re: pvgrub2 is merged Date: Wed, 18 Dec 2013 21:20:34 +0100 [thread overview] Message-ID: <52B20392.9090001@gmail.com> (raw) In-Reply-To: <alpine.DEB.2.02.1312181936470.8667@kaball.uk.xensource.com> [-- Attachment #1.1: Type: text/plain, Size: 2756 bytes --] On 18.12.2013 20:39, Stefano Stabellini wrote: > On Wed, 18 Dec 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 17.12.2013 15:35, Fabio Fantoni wrote: >>> Il 17/12/2013 15:10, Fabio Fantoni ha scritto: >>>> Il 17/12/2013 15:08, Vladimir 'φ-coder/phcoder' Serbinenko ha scritto: >>>>>> Thanks. >>>>>> Now there is another error, probably introduced by xenfb support: >>>>>> >>>>> doesn't look like related to xenfb. Is it 64-bit or PAE guest? >>>> >>>> 64 bit >>> >>> I did "git reset --hard" to commit "Remove grub_bios_interrupt on >>> coreboot." and then I applied only >>> "grub-core/lib/x86_64/xen/relocator.S: Fix hypercall ABI violation." >>> commit. >>> Now the Sid domU boot correctly, therefore the regression is caused by >>> "xenfb" or "xen grants to v1" commit, should I find the exact commit >>> that causes that problem or these informations are enough for you? >> >> It's because of vfb. Apparently vfb framebuffer stays mapped as rw even >> after vfb shutdown >> phcoder@debian:15:52:40:~/grub2$ sudo xenstore-ls >> /local/domain/54/device/vfb >> 0 = "" >> backend = "/local/domain/0/backend/vfb/54/0" >> backend-id = "0" >> state = "1" >> phcoder@debian:15:52:51:~/grub2$ sudo xenstore-ls >> /local/domain/0/backend/vfb/54/0 >> frontend = "/local/domain/54/device/vfb/0" >> frontend-id = "54" >> online = "1" >> state = "2" >> domain = "grub" >> vnc = "1" >> vnclisten = "127.0.0.1" >> vncdisplay = "0" >> vncunused = "1" >> sdl = "0" >> opengl = "0" >> feature-resize = "1" >> hotplug-status = "connected" >> >> When I do "dry vfb": do everything except writing vfb state problem >> disappears. So my question would be: >> - how can I inspect how backend maps framebuffer pages? > > There is only one xenfb backend: hw/display/xenfb.c in the QEMU source > tree. > > >> - Why does it map as rw and not ro? It doesn't need to write to framebuffer? > > Actually it is mapping it RO, see hw/display/xenfb.c:xenfb_map_fb > ./tools/qemu-xen-dir-remote/hw/xenfb.c: xenfb->pixels = xc_map_foreign_pages(xen_xc, xenfb->c.xendev.dom, PROT_READ | PROT_WRITE, fbmfns, xenfb->fbpages); > >> - How do I force it to drop the mapping? > > Theoretically QEMU should drop the mapping at disconnect time: > > hw/display/xenfb.c:fb_disconnect > > /* > * FIXME: qemu can't un-init gfx display (yet?). > * Replacing the framebuffer with anonymous shared memory > * instead. This releases the guest pages and keeps qemu happy. > */ > fb->pixels = mmap(fb->pixels, fb->fbpages * XC_PAGE_SIZE, > PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANON, > -1, 0); > Could this fail? [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 291 bytes --] [-- Attachment #2: Type: text/plain, Size: 126 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com> To: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: The development of GRUB 2 <grub-devel@gnu.org>, Fabio Fantoni <fabio.fantoni@m2r.biz>, xen-devel <xen-devel@lists.xensource.com> Subject: Re: [Xen-devel] pvgrub2 is merged Date: Wed, 18 Dec 2013 21:20:34 +0100 [thread overview] Message-ID: <52B20392.9090001@gmail.com> (raw) In-Reply-To: <alpine.DEB.2.02.1312181936470.8667@kaball.uk.xensource.com> [-- Attachment #1: Type: text/plain, Size: 2756 bytes --] On 18.12.2013 20:39, Stefano Stabellini wrote: > On Wed, 18 Dec 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 17.12.2013 15:35, Fabio Fantoni wrote: >>> Il 17/12/2013 15:10, Fabio Fantoni ha scritto: >>>> Il 17/12/2013 15:08, Vladimir 'φ-coder/phcoder' Serbinenko ha scritto: >>>>>> Thanks. >>>>>> Now there is another error, probably introduced by xenfb support: >>>>>> >>>>> doesn't look like related to xenfb. Is it 64-bit or PAE guest? >>>> >>>> 64 bit >>> >>> I did "git reset --hard" to commit "Remove grub_bios_interrupt on >>> coreboot." and then I applied only >>> "grub-core/lib/x86_64/xen/relocator.S: Fix hypercall ABI violation." >>> commit. >>> Now the Sid domU boot correctly, therefore the regression is caused by >>> "xenfb" or "xen grants to v1" commit, should I find the exact commit >>> that causes that problem or these informations are enough for you? >> >> It's because of vfb. Apparently vfb framebuffer stays mapped as rw even >> after vfb shutdown >> phcoder@debian:15:52:40:~/grub2$ sudo xenstore-ls >> /local/domain/54/device/vfb >> 0 = "" >> backend = "/local/domain/0/backend/vfb/54/0" >> backend-id = "0" >> state = "1" >> phcoder@debian:15:52:51:~/grub2$ sudo xenstore-ls >> /local/domain/0/backend/vfb/54/0 >> frontend = "/local/domain/54/device/vfb/0" >> frontend-id = "54" >> online = "1" >> state = "2" >> domain = "grub" >> vnc = "1" >> vnclisten = "127.0.0.1" >> vncdisplay = "0" >> vncunused = "1" >> sdl = "0" >> opengl = "0" >> feature-resize = "1" >> hotplug-status = "connected" >> >> When I do "dry vfb": do everything except writing vfb state problem >> disappears. So my question would be: >> - how can I inspect how backend maps framebuffer pages? > > There is only one xenfb backend: hw/display/xenfb.c in the QEMU source > tree. > > >> - Why does it map as rw and not ro? It doesn't need to write to framebuffer? > > Actually it is mapping it RO, see hw/display/xenfb.c:xenfb_map_fb > ./tools/qemu-xen-dir-remote/hw/xenfb.c: xenfb->pixels = xc_map_foreign_pages(xen_xc, xenfb->c.xendev.dom, PROT_READ | PROT_WRITE, fbmfns, xenfb->fbpages); > >> - How do I force it to drop the mapping? > > Theoretically QEMU should drop the mapping at disconnect time: > > hw/display/xenfb.c:fb_disconnect > > /* > * FIXME: qemu can't un-init gfx display (yet?). > * Replacing the framebuffer with anonymous shared memory > * instead. This releases the guest pages and keeps qemu happy. > */ > fb->pixels = mmap(fb->pixels, fb->fbpages * XC_PAGE_SIZE, > PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANON, > -1, 0); > Could this fail? [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-12-18 20:20 UTC|newest] Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-11-09 20:52 pvgrub2 is merged Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-09 21:01 ` Samuel Thibault 2013-11-09 21:01 ` [Xen-devel] " Samuel Thibault 2013-11-10 4:47 ` Andrey Borzenkov 2013-11-11 11:51 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-11 11:51 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-13 19:06 ` M A Young 2013-11-13 19:06 ` [Xen-devel] " M A Young 2013-11-13 20:14 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 12:27 ` M A Young 2013-11-14 17:03 ` M A Young 2013-11-14 17:03 ` [Xen-devel] " M A Young 2013-11-14 17:32 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 18:48 ` M A Young 2013-11-14 18:57 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 18:57 ` [Xen-devel] " Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 18:59 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 21:11 ` M A Young 2013-11-14 21:11 ` [Xen-devel] " M A Young 2013-11-14 21:43 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 21:43 ` [Xen-devel] " Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-25 15:56 ` Fabio Fantoni 2013-11-25 15:56 ` [Xen-devel] " Fabio Fantoni [not found] ` <CAEaD8JOKf7J8ZRfRH_s03UQ9xw=qDziutHNoZs=NTKo3oN_vJg@mail.gmail.com> 2013-11-25 16:26 ` Fabio Fantoni 2013-11-25 19:35 ` M A Young 2013-11-25 19:35 ` [Xen-devel] " M A Young 2013-11-26 17:58 ` Fabio Fantoni 2013-11-26 18:12 ` Andrey Borzenkov 2013-11-26 18:12 ` [Xen-devel] " Andrey Borzenkov 2013-11-26 19:16 ` Andrew Cooper 2013-11-26 19:16 ` [Xen-devel] " Andrew Cooper 2013-11-27 11:32 ` Fabio Fantoni 2013-11-27 11:32 ` [Xen-devel] " Fabio Fantoni 2013-11-27 11:50 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-27 11:50 ` [Xen-devel] " Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-27 15:59 ` Fabio Fantoni 2013-11-27 15:59 ` [Xen-devel] " Fabio Fantoni 2013-11-27 16:03 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-27 16:24 ` Fabio Fantoni 2013-11-27 16:24 ` [Xen-devel] " Fabio Fantoni 2013-11-27 17:35 ` Andrey Borzenkov 2013-11-27 17:35 ` [Xen-devel] " Andrey Borzenkov 2013-11-28 13:07 ` Fabio Fantoni 2013-11-28 13:07 ` [Xen-devel] " Fabio Fantoni 2013-11-28 14:05 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-28 14:17 ` Fabio Fantoni 2013-11-29 11:28 ` Fabio Fantoni [not found] ` <52987D7F.3050006@gmail.com> [not found] ` <52988F86.6050008@m2r.biz> 2013-12-03 10:31 ` Fabio Fantoni 2013-12-03 10:31 ` Fabio Fantoni 2013-12-03 10:33 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-03 10:33 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-03 11:22 ` Fabio Fantoni 2013-12-03 11:22 ` Fabio Fantoni [not found] ` <529DC07E.8000201@gmail.com> [not found] ` <529DE3FD.90002@m2r.biz> 2013-12-03 15:33 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-03 16:16 ` Fabio Fantoni 2013-12-06 11:11 ` Fabio Fantoni 2013-12-06 11:32 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-06 14:44 ` Fabio Fantoni 2013-12-06 14:55 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-06 15:22 ` Fabio Fantoni 2013-12-07 10:06 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-09 10:06 ` Fabio Fantoni 2013-12-17 10:44 ` Fabio Fantoni 2013-12-17 11:03 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-17 13:11 ` Fabio Fantoni 2013-12-17 13:32 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-17 13:55 ` Fabio Fantoni 2013-12-17 13:55 ` Fabio Fantoni 2013-12-17 14:08 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-17 14:08 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-17 14:10 ` Fabio Fantoni 2013-12-17 14:10 ` Fabio Fantoni 2013-12-17 14:35 ` Fabio Fantoni 2013-12-17 14:35 ` Fabio Fantoni 2013-12-18 14:58 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-18 14:58 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-18 19:39 ` Stefano Stabellini 2013-12-18 19:39 ` Stefano Stabellini 2013-12-18 20:20 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message] 2013-12-18 20:20 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-19 11:54 ` Stefano Stabellini 2013-12-19 11:54 ` Stefano Stabellini 2013-12-20 12:14 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-20 12:14 ` Vladimir 'φ-coder/phcoder' Serbinenko 2014-01-06 12:23 ` Stefano Stabellini 2014-01-06 12:23 ` Stefano Stabellini 2014-11-07 15:20 ` Stefano Stabellini 2014-11-07 15:20 ` Stefano Stabellini 2013-12-17 11:59 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-05 15:50 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-05 15:50 ` [Xen-devel] " Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-05 16:04 ` Fabio Fantoni 2013-12-05 16:04 ` [Xen-devel] " Fabio Fantoni 2013-11-29 11:28 ` Fabio Fantoni 2013-11-28 14:17 ` Fabio Fantoni 2013-11-28 14:05 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-27 16:03 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-27 16:10 ` [Xen-devel] " M A Young 2013-11-27 16:10 ` M A Young 2013-11-26 17:58 ` Fabio Fantoni 2013-11-14 18:59 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 18:48 ` M A Young 2013-11-14 17:32 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 12:27 ` M A Young 2013-11-13 20:14 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-10 4:47 ` Andrey Borzenkov 2013-11-11 10:10 ` [Xen-devel] " Ian Campbell 2013-11-11 11:54 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-11 11:54 ` [Xen-devel] " Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-11 12:06 ` Ian Campbell 2013-11-11 12:06 ` [Xen-devel] " Ian Campbell 2013-11-11 12:52 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-11 12:52 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 9:48 ` Dario Faggioli 2013-11-14 9:48 ` [Xen-devel] " Dario Faggioli 2013-11-11 10:10 ` Ian Campbell 2013-11-13 16:36 ` Ian Campbell 2013-11-13 16:36 ` [Xen-devel] " Ian Campbell 2013-11-13 18:25 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-13 18:25 ` [Xen-devel] " Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 8:37 ` Ian Campbell 2013-12-11 11:47 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-11 11:51 ` Ian Campbell 2013-12-11 11:51 ` [Xen-devel] " Ian Campbell 2013-12-11 11:54 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-12-11 14:34 ` Dario Faggioli 2013-12-11 14:34 ` [Xen-devel] " Dario Faggioli 2013-12-14 17:13 ` Leif Lindholm 2013-12-14 17:13 ` [Xen-devel] " Leif Lindholm 2013-12-11 11:54 ` Vladimir 'φ-coder/phcoder' Serbinenko 2014-01-06 15:35 ` Lars Kurth 2014-01-06 15:35 ` [Xen-devel] " Lars Kurth 2013-12-11 11:47 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-14 8:37 ` Ian Campbell 2013-11-29 13:24 ` Colin Watson 2013-11-29 17:44 ` Andrey Borzenkov 2013-11-29 18:16 ` Colin Watson 2013-12-02 9:48 ` Ian Campbell 2013-12-02 9:48 ` [Xen-devel] " Ian Campbell 2013-12-02 10:37 ` Samuel Thibault 2013-12-02 10:46 ` Ian Campbell 2013-12-02 10:46 ` [Xen-devel] " Ian Campbell 2013-12-02 10:37 ` Samuel Thibault 2013-12-03 17:27 ` [Xen-devel] " Colin Watson 2013-12-03 17:41 ` Ian Campbell 2013-12-03 17:41 ` Ian Campbell 2013-12-03 17:27 ` Colin Watson 2013-11-29 17:44 ` Andrey Borzenkov 2013-11-30 10:36 ` Vladimir 'φ-coder/phcoder' Serbinenko 2013-11-09 20:52 Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=52B20392.9090001@gmail.com \ --to=phcoder@gmail.com \ --cc=fabio.fantoni@m2r.biz \ --cc=grub-devel@gnu.org \ --cc=stefano.stabellini@eu.citrix.com \ --cc=xen-devel@lists.xensource.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.